Skip to content

Commit 3fb4b6f

Browse files
committed
[ORC] Rename "TargetJD" parameter of redirect method to just "JD". NFC.
In JITLinkRedirectableSymbolManager::redirect we no longer need to disambiguate between the JD for the redirectable symbols and the one for the corresponding stubs (they're the same as of 529c091). Renaming it brings the parameter name into line with the one used in the base class's redirect method.
1 parent 529c091 commit 3fb4b6f

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

llvm/include/llvm/ExecutionEngine/Orc/JITLinkRedirectableSymbolManager.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ class JITLinkRedirectableSymbolManager : public RedirectableSymbolManager {
4242
void emitRedirectableSymbols(std::unique_ptr<MaterializationResponsibility> R,
4343
const SymbolAddrMap &InitialDests) override;
4444

45-
Error redirect(JITDylib &TargetJD, const SymbolAddrMap &NewDests) override;
45+
Error redirect(JITDylib &JD, const SymbolAddrMap &NewDests) override;
4646

4747
private:
4848
JITLinkRedirectableSymbolManager(

llvm/lib/ExecutionEngine/Orc/JITLinkRedirectableSymbolManager.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ void JITLinkRedirectableSymbolManager::emitRedirectableSymbols(
6767
}
6868

6969
Error JITLinkRedirectableSymbolManager::redirect(
70-
JITDylib &TargetJD, const SymbolAddrMap &NewDests) {
70+
JITDylib &JD, const SymbolAddrMap &NewDests) {
7171
auto &ES = ObjLinkingLayer.getExecutionSession();
7272
SymbolLookupSet LS;
7373
DenseMap<NonOwningSymbolStringPtr, SymbolStringPtr> PtrToStub;
@@ -76,8 +76,8 @@ Error JITLinkRedirectableSymbolManager::redirect(
7676
PtrToStub[NonOwningSymbolStringPtr(PtrName)] = StubName;
7777
LS.add(std::move(PtrName));
7878
}
79-
auto PtrSyms = ES.lookup({{&TargetJD, JITDylibLookupFlags::MatchAllSymbols}},
80-
std::move(LS));
79+
auto PtrSyms =
80+
ES.lookup({{&JD, JITDylibLookupFlags::MatchAllSymbols}}, std::move(LS));
8181
if (!PtrSyms)
8282
return PtrSyms.takeError();
8383

0 commit comments

Comments
 (0)