[Analysis] Avoid repeated hash lookups (NFC) (#126378)

kazutakahirata · web-flow · commit 451007173aba · 2025-02-08T11:35:17.000-08:00
diff --git a/clang/lib/Analysis/UninitializedValues.cpp b/clang/lib/Analysis/UninitializedValues.cpp
@@ -379,8 +379,10 @@ void ClassifyRefs::classify(const Expr *E, Class C) {
   }
 
   FindVarResult Var = findVar(E, DC);
-  if (const DeclRefExpr *DRE = Var.getDeclRefExpr())
-    Classification[DRE] = std::max(Classification[DRE], C);
+  if (const DeclRefExpr *DRE = Var.getDeclRefExpr()) {
+    auto &Class = Classification[DRE];
+    Class = std::max(Class, C);
+  }
 }
 
 void ClassifyRefs::VisitDeclStmt(DeclStmt *DS) {

Original file line number	Diff line number	Diff line change
`@@ -379,8 +379,10 @@ void ClassifyRefs::classify(const Expr *E, Class C) {`
`379`	`379`	`}`
`380`	`380`
`381`	`381`	`FindVarResult Var = findVar(E, DC);`
`382`		`- if (const DeclRefExpr *DRE = Var.getDeclRefExpr())`
`383`		`- Classification[DRE] = std::max(Classification[DRE], C);`
	`382`	`+ if (const DeclRefExpr *DRE = Var.getDeclRefExpr()) {`
	`383`	`+ auto &Class = Classification[DRE];`
	`384`	`+ Class = std::max(Class, C);`
	`385`	`+ }`
`384`	`386`	`}`
`385`	`387`
`386`	`388`	`void ClassifyRefs::VisitDeclStmt(DeclStmt *DS) {`