Skip to content

Commit 454398a

Browse files
authored
[MLIR] Add missing memory read effect on memref.reshape (#117130)
The memory read effect on a memref.reshape argument was missing. This in turn led to analyses relying on memory effects making incorrect conclusions.
1 parent 3f1e7ef commit 454398a

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

mlir/include/mlir/Dialect/MemRef/IR/MemRefOps.td

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1529,7 +1529,8 @@ def MemRef_ReshapeOp: MemRef_Op<"reshape", [
15291529
}];
15301530

15311531
let arguments = (ins AnyRankedOrUnrankedMemRef:$source,
1532-
MemRefRankOf<[AnySignlessInteger, Index], [1]>:$shape);
1532+
Arg<MemRefRankOf<[AnySignlessInteger, Index], [1]>,
1533+
"dynamically-sized shape", [MemRead]>:$shape);
15331534
let results = (outs AnyRankedOrUnrankedMemRef:$result);
15341535

15351536
let builders = [OpBuilder<

0 commit comments

Comments
 (0)