Skip to content

Commit 471ed86

Browse files
committed
!fixup update remaining tests accessing void *
1 parent befe3a6 commit 471ed86

File tree

2 files changed

+13
-17
lines changed

2 files changed

+13
-17
lines changed

clang/test/CodeGenOpenCL/amdgpu-enqueue-kernel.cl

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -651,7 +651,7 @@ kernel void test_target_features_kernel(global int *i) {
651651
//
652652
// GFX900: Function Attrs: convergent nounwind
653653
// GFX900-LABEL: define {{[^@]+}}@__test_block_invoke_3_kernel
654-
// GFX900-SAME: (<{ i32, i32, ptr, ptr addrspace(1), ptr addrspace(1), i64, i8 }> [[TMP0:%.*]], ptr addrspace(3) [[TMP1:%.*]]) #[[ATTR6]] !kernel_arg_addr_space [[META28:![0-9]+]] !kernel_arg_access_qual [[META29:![0-9]+]] !kernel_arg_type [[META30:![0-9]+]] !kernel_arg_base_type [[META30]] !kernel_arg_type_qual [[META31:![0-9]+]] {
654+
// GFX900-SAME: (<{ i32, i32, ptr, ptr addrspace(1), ptr addrspace(1), i64, i8 }> [[TMP0:%.*]], ptr addrspace(3) [[TMP1:%.*]]) #[[ATTR6]] !kernel_arg_addr_space [[META27:![0-9]+]] !kernel_arg_access_qual [[META28:![0-9]+]] !kernel_arg_type [[META29:![0-9]+]] !kernel_arg_base_type [[META29]] !kernel_arg_type_qual [[META30:![0-9]+]] {
655655
// GFX900-NEXT: entry:
656656
// GFX900-NEXT: [[TMP2:%.*]] = alloca <{ i32, i32, ptr, ptr addrspace(1), ptr addrspace(1), i64, i8 }>, align 8, addrspace(5)
657657
// GFX900-NEXT: store <{ i32, i32, ptr, ptr addrspace(1), ptr addrspace(1), i64, i8 }> [[TMP0]], ptr addrspace(5) [[TMP2]], align 8
@@ -688,7 +688,7 @@ kernel void test_target_features_kernel(global int *i) {
688688
//
689689
// GFX900: Function Attrs: convergent norecurse nounwind
690690
// GFX900-LABEL: define {{[^@]+}}@test_target_features_kernel
691-
// GFX900-SAME: (ptr addrspace(1) noundef align 4 [[I:%.*]]) #[[ATTR2]] !kernel_arg_addr_space [[META32:![0-9]+]] !kernel_arg_access_qual [[META23]] !kernel_arg_type [[META33:![0-9]+]] !kernel_arg_base_type [[META33]] !kernel_arg_type_qual [[META25]] {
691+
// GFX900-SAME: (ptr addrspace(1) noundef align 4 [[I:%.*]]) #[[ATTR2]] !kernel_arg_addr_space [[META31:![0-9]+]] !kernel_arg_access_qual [[META23]] !kernel_arg_type [[META32:![0-9]+]] !kernel_arg_base_type [[META32]] !kernel_arg_type_qual [[META25]] {
692692
// GFX900-NEXT: entry:
693693
// GFX900-NEXT: [[I_ADDR:%.*]] = alloca ptr addrspace(1), align 8, addrspace(5)
694694
// GFX900-NEXT: [[DEFAULT_QUEUE:%.*]] = alloca ptr addrspace(1), align 8, addrspace(5)
@@ -700,7 +700,7 @@ kernel void test_target_features_kernel(global int *i) {
700700
// GFX900-NEXT: [[FLAGS_ASCAST:%.*]] = addrspacecast ptr addrspace(5) [[FLAGS]] to ptr
701701
// GFX900-NEXT: [[NDRANGE_ASCAST:%.*]] = addrspacecast ptr addrspace(5) [[NDRANGE]] to ptr
702702
// GFX900-NEXT: [[TMP_ASCAST:%.*]] = addrspacecast ptr addrspace(5) [[TMP]] to ptr
703-
// GFX900-NEXT: store ptr addrspace(1) [[I]], ptr [[I_ADDR_ASCAST]], align 8, !tbaa [[TBAA34:![0-9]+]]
703+
// GFX900-NEXT: store ptr addrspace(1) [[I]], ptr [[I_ADDR_ASCAST]], align 8, !tbaa [[TBAA33:![0-9]+]]
704704
// GFX900-NEXT: call void @llvm.lifetime.start.p5(i64 8, ptr addrspace(5) [[DEFAULT_QUEUE]]) #[[ATTR8]]
705705
// GFX900-NEXT: call void @llvm.lifetime.start.p5(i64 4, ptr addrspace(5) [[FLAGS]]) #[[ATTR8]]
706706
// GFX900-NEXT: store i32 0, ptr [[FLAGS_ASCAST]], align 4, !tbaa [[TBAA17]]
@@ -803,16 +803,15 @@ kernel void test_target_features_kernel(global int *i) {
803803
// GFX900: [[META23]] = !{!"none"}
804804
// GFX900: [[META24]] = !{!"__block_literal"}
805805
// GFX900: [[META25]] = !{!""}
806-
// GFX900: [[TBAA26]] = !{[[META27:![0-9]+]], [[META27]], i64 0}
807-
// GFX900: [[META27]] = !{!"p1 void", [[META9]], i64 0}
808-
// GFX900: [[META28]] = !{i32 0, i32 3}
809-
// GFX900: [[META29]] = !{!"none", !"none"}
810-
// GFX900: [[META30]] = !{!"__block_literal", !"void*"}
811-
// GFX900: [[META31]] = !{!"", !""}
812-
// GFX900: [[META32]] = !{i32 1}
813-
// GFX900: [[META33]] = !{!"int*"}
814-
// GFX900: [[TBAA34]] = !{[[META35:![0-9]+]], [[META35]], i64 0}
815-
// GFX900: [[META35]] = !{!"p1 int", [[META9]], i64 0}
806+
// GFX900: [[TBAA26]] = !{[[META9]], [[META9]], i64 0}
807+
// GFX900: [[META27]] = !{i32 0, i32 3}
808+
// GFX900: [[META28]] = !{!"none", !"none"}
809+
// GFX900: [[META29]] = !{!"__block_literal", !"void*"}
810+
// GFX900: [[META30]] = !{!"", !""}
811+
// GFX900: [[META31]] = !{i32 1}
812+
// GFX900: [[META32]] = !{!"int*"}
813+
// GFX900: [[TBAA33]] = !{[[META34:![0-9]+]], [[META34]], i64 0}
814+
// GFX900: [[META34]] = !{!"p1 int", [[META9]], i64 0}
816815
//.
817816
//// NOTE: These prefixes are unused and the list is autogenerated. Do not add tests below this line:
818817
// CHECK: {{.*}}

clang/unittests/CodeGen/TBAAMetadataTest.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,10 +120,7 @@ TEST(TBAAMetadataTest, BasicTypes) {
120120
MInstruction(Instruction::Store,
121121
MValType(PointerType::getUnqual(Compiler.Context)),
122122
MMTuple(
123-
MMTuple(
124-
MMString("p1 void"),
125-
AnyPtr,
126-
MConstInt(0)),
123+
AnyPtr,
127124
MSameAs(0),
128125
MConstInt(0))));
129126
ASSERT_TRUE(I);

0 commit comments

Comments
 (0)