Skip to content

Commit 498704d

Browse files
committed
[NFC][exegesis] By default, don't dump objects to disk
It's a strictly-developer feature, which is useless most of the time. Fixes #59082 Reviewed By: RKSimon, gchatelet Differential Revision: https://reviews.llvm.org/D140700
1 parent 46575f6 commit 498704d

File tree

2 files changed

+14
-5
lines changed

2 files changed

+14
-5
lines changed
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
# RUN: llvm-exegesis -mtriple=x86_64-unknown-unknown -mcpu=x86-64 -mode=latency --skip-measurements -opcode-name=ADDPSrr -repetition-mode=duplicate -dump-object-to-disk=1 2>&1 | FileCheck %s --check-prefix=CHECK-ON
2+
# RUN: llvm-exegesis -mtriple=x86_64-unknown-unknown -mcpu=x86-64 -mode=latency --skip-measurements -opcode-name=ADDPSrr -repetition-mode=loop -dump-object-to-disk=1 2>&1 | FileCheck %s --check-prefix=CHECK-ON
3+
# RUN: llvm-exegesis -mtriple=x86_64-unknown-unknown -mcpu=x86-64 -mode=latency --skip-measurements -opcode-name=ADDPSrr -repetition-mode=duplicate -dump-object-to-disk=0 2>&1 | FileCheck %s --check-prefix=CHECK-OFF
4+
# RUN: llvm-exegesis -mtriple=x86_64-unknown-unknown -mcpu=x86-64 -mode=latency --skip-measurements -opcode-name=ADDPSrr -repetition-mode=loop -dump-object-to-disk=0 2>&1 | FileCheck %s --check-prefix=CHECK-OFF
5+
# RUN: llvm-exegesis -mtriple=x86_64-unknown-unknown -mcpu=x86-64 -mode=latency --skip-measurements -opcode-name=ADDPSrr -repetition-mode=duplicate 2>&1 | FileCheck %s --check-prefix=CHECK-OFF
6+
# RUN: llvm-exegesis -mtriple=x86_64-unknown-unknown -mcpu=x86-64 -mode=latency --skip-measurements -opcode-name=ADDPSrr -repetition-mode=loop 2>&1 | FileCheck %s --check-prefix=CHECK-OFF
7+
8+
CHECK-ON: Check generated assembly with
9+
CHECK-OFF-NOT: Check generated assembly with

llvm/tools/llvm-exegesis/llvm-exegesis.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -205,11 +205,11 @@ static cl::opt<std::string>
205205
cl::desc("Target a specific cpu type (-mcpu=help for details)"),
206206
cl::value_desc("cpu-name"), cl::cat(Options), cl::init("native"));
207207

208-
static cl::opt<bool>
209-
DumpObjectToDisk("dump-object-to-disk",
210-
cl::desc("dumps the generated benchmark object to disk "
211-
"and prints a message to access it"),
212-
cl::cat(BenchmarkOptions), cl::init(true));
208+
static cl::opt<bool> DumpObjectToDisk(
209+
"dump-object-to-disk",
210+
cl::desc("dumps the generated benchmark object to disk "
211+
"and prints a message to access it (default = false)"),
212+
cl::cat(BenchmarkOptions), cl::init(false));
213213

214214
static ExitOnError ExitOnErr("llvm-exegesis error: ");
215215

0 commit comments

Comments
 (0)