address reviewer comments

Author: fabianmcg

mlir/include/mlir/Dialect/Ptr/IR/PtrDialect.td

@@ -43,7 +43,7 @@ def Ptr_PtrType : Ptr_Type<"Ptr", "ptr", [
   let summary = "pointer type";
   let description = [{
     The `ptr` type is an opaque pointer type. This type typically represents
-    a reference to an object in memory. Pointers are optionally parameterized
+    a handle to an object in memory. Pointers are optionally parameterized
     by a memory space.
     Syntax:
 
@@ -57,10 +57,6 @@ def Ptr_PtrType : Ptr_Type<"Ptr", "ptr", [
   let builders = [
     TypeBuilder<(ins CArg<"Attribute", "nullptr">:$memorySpace), [{
       return $_get($_ctxt, memorySpace);
-    }]>,
-    TypeBuilder<(ins CArg<"unsigned">:$addressSpace), [{
-      return $_get($_ctxt, IntegerAttr::get(IntegerType::get($_ctxt, 32),
-                                            addressSpace));
     }]>
   ];
   let skipDefaultBuilders = 1;

mlir/lib/Dialect/Ptr/IR/CMakeLists.txt

@@ -3,11 +3,11 @@ add_mlir_dialect_library(
   PtrAttrs.cpp
   PtrTypes.cpp
   PtrDialect.cpp
-  ADDITIONAL_HEADER_DIRS
-  ${PROJECT_SOURCE_DIR}/mlir/Dialect/Pointer
+
   DEPENDS
   MLIRPtrOpsAttributesIncGen
   MLIRPtrOpsIncGen
+
   LINK_LIBS
   PUBLIC
   MLIRIR

mlir/lib/Dialect/Ptr/IR/PtrAttrs.cpp

@@ -27,11 +27,11 @@ LogicalResult SpecAttr::verify(function_ref<InFlightDiagnostic()> emitError,
                                uint32_t index) {
   if (size % kBitsInByte != 0)
     return emitError() << "size entry must be divisible by 8";
-  else if (abi % kBitsInByte != 0)
+  if (abi % kBitsInByte != 0)
     return emitError() << "abi entry must be divisible by 8";
-  else if (preferred % kBitsInByte != 0)
+  if (preferred % kBitsInByte != 0)
     return emitError() << "preferred entry must be divisible by 8";
-  else if (index != kOptionalSpecValue && index % kBitsInByte != 0)
+  if (index != kOptionalSpecValue && index % kBitsInByte != 0)
     return emitError() << "index entry must be divisible by 8";
   if (abi > preferred)
     return emitError() << "preferred alignment is expected to be at least "