Skip to content

Commit 4eb8458

Browse files
committed
[runtimes] Fix runtimes-test-depends
The dependency list is stored in a global property, so we need to fetch it to a variable before using that variable. We also need to add the list contents as dependencies correctly.
1 parent de7222b commit 4eb8458

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

runtimes/CMakeLists.txt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,12 @@ if(LLVM_INCLUDE_TESTS)
232232
# LLVM_RUNTIMES_LIT_DEPENDS is populated when lit tests are added between
233233
# umbrella_list_testsuite begin and end. The bootstrap runtimes builds
234234
# currently assumes this target exists.
235-
add_custom_target(runtimes-test-depends ${LLVM_RUNTIMES_LIT_DEPENDS})
235+
get_property(LLVM_RUNTIMES_LIT_DEPENDS GLOBAL PROPERTY LLVM_RUNTIMES_LIT_DEPENDS)
236+
add_custom_target(runtimes-test-depends)
237+
if(LLVM_RUNTIMES_LIT_DEPENDS)
238+
# add_dependencies complains if called with no dependencies
239+
add_dependencies(runtimes-test-depends ${LLVM_RUNTIMES_LIT_DEPENDS})
240+
endif()
236241
# Add a global check rule now that all subdirectories have been traversed
237242
# and we know the total set of lit testsuites.
238243
umbrella_lit_testsuite_end(check-runtimes)

0 commit comments

Comments
 (0)