Skip to content

Commit 56da799

Browse files
authored
[lldb] [NFC] Remove unused WatchpointResource::SetID method (#79389)
I originally thought to try to guesstimate the hardware watchpoint index number that a Resource was associated with, but gdb remote serial protocol doesn't give us the hardware register index used so it was only a guess. I changed my mind and simply use ever-incrementing ID numbers for the WatchpointResources, but forgot to remove the SetID method.
1 parent bddeef5 commit 56da799

File tree

2 files changed

+0
-10
lines changed

2 files changed

+0
-10
lines changed

lldb/include/lldb/Breakpoint/WatchpointResource.h

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -121,14 +121,6 @@ class WatchpointResource
121121
/// A copy of the Watchpoints which own this resource.
122122
WatchpointCollection CopyConstituentsList();
123123

124-
// The ID of the WatchpointResource is set by the WatchpointResourceList
125-
// when the Resource has been set in the inferior and is being added
126-
// to the List, in an attempt to match the hardware watchpoint register
127-
// ordering. If a Process can correctly identify the hardware watchpoint
128-
// register index when it has created the Resource, it may initialize it
129-
// before it is inserted in the WatchpointResourceList.
130-
void SetID(lldb::wp_resource_id_t);
131-
132124
lldb::wp_resource_id_t GetID() const;
133125

134126
bool Contains(lldb::addr_t addr);

lldb/source/Breakpoint/WatchpointResource.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,6 @@ void WatchpointResource::SetType(bool read, bool write) {
4242

4343
wp_resource_id_t WatchpointResource::GetID() const { return m_id; }
4444

45-
void WatchpointResource::SetID(wp_resource_id_t id) { m_id = id; }
46-
4745
bool WatchpointResource::Contains(addr_t addr) {
4846
if (addr >= m_addr && addr < m_addr + m_size)
4947
return true;

0 commit comments

Comments
 (0)