address comments

Author: Peiming Liu

mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensor.h

@@ -58,7 +58,7 @@ struct COOSegment {
   }
 };
 
-/// A simple wrapper to encode a bitset of defined  (at most 64) levels.
+/// A simple wrapper to encode a bitset of defined (at most 64) levels.
 class LevelSet {
   uint64_t bits = 0;
 
@@ -69,7 +69,7 @@ class LevelSet {
 
   LevelSet &set(unsigned i) {
     assert(i < 64);
-    bits |= 1 << i;
+    bits |= static_cast<uint64_t>(0x01u) << i;
     return *this;
   }
 

mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorAttrDefs.td

@@ -20,7 +20,7 @@ class SparseTensor_Attr<string name,
     : AttrDef<SparseTensor_Dialect, name, traits>;
 
 //===----------------------------------------------------------------------===//
-// A simple bitset attribute wrapped over a single int64_t to encode a set of
+// A simple bitset attribute wrapped around a single int64_t to encode a set of
 // sparse tensor levels.
 //===----------------------------------------------------------------------===//
 

mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorOps.td

@@ -1526,8 +1526,8 @@ def IterateOp : SparseTensor_Op<"iterate",
 
   let summary = "Iterate over a sparse iteration space";
   let description = [{
-      The `sparse_tensor.iterate` operations represents a loop over the
-      provided iteration space extracted from a specific sparse tensor.
+      The `sparse_tensor.iterate` operation represents a loop (nest) over
+      the provided iteration space extracted from a specific sparse tensor.
       The operation defines an SSA value for a sparse iterator that points
       to the current stored element in the sparse tensor and SSA values
       for coordinates of the stored element. The coordinates are always

mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp

@@ -2385,7 +2385,7 @@ LogicalResult IterateOp::verifyRegions() {
   return success();
 }
 
-/// IterateOp implemented OpInterfaces' methods.
+/// OpInterfaces' methods implemented by IterateOp.
 SmallVector<Region *> IterateOp::getLoopRegions() { return {&getRegion()}; }
 
 MutableArrayRef<OpOperand> IterateOp::getInitsMutable() {