Address comments

Signed-off-by: Jacques Pienaar <[email protected]>

Author: jpienaar

mlir/include/mlir/Bindings/Python/PybindAdaptors.h

@@ -206,7 +206,7 @@ struct type_caster<MlirFrozenRewritePatternSet> {
   bool load(handle src, bool) {
     py::object capsule = mlirApiObjectToCapsule(src);
     value = mlirPythonCapsuleToFrozenRewritePatternSet(capsule.ptr());
-    return !mlirModuleIsNull(value);
+    return value.ptr != nullptr;
   }
   static handle cast(MlirFrozenRewritePatternSet v, return_value_policy,
                      handle) {

mlir/python/mlir/dialects/pdl.py

@@ -6,7 +6,7 @@
 from ._pdl_ops_gen import _Dialect
 from .._mlir_libs._mlirDialectsPDL import *
 from .._mlir_libs._mlirDialectsPDL import OperationType
-
+from ..extras.meta import region_op
 
 try:
     from ..ir import *
@@ -127,6 +127,9 @@ def body(self):
         return self.regions[0].blocks[0]
 
 
+pattern = region_op(PatternOp.__base__)
+
+
 @_ods_cext.register_operation(_Dialect, replace=True)
 class ReplaceOp(ReplaceOp):
     """Specialization for PDL replace op class."""
@@ -195,6 +198,9 @@ def body(self):
         return self.regions[0].blocks[0]
 
 
+rewrite = region_op(RewriteOp)
+
+
 @_ods_cext.register_operation(_Dialect, replace=True)
 class TypeOp(TypeOp):
     """Specialization for PDL type op class."""

mlir/test/python/integration/dialects/pdl.py

@@ -38,8 +38,8 @@ def add_func(a, b):
         m = Module.create()
         with InsertionPoint(m.body):
             # Change all arith.addi with index types to arith.muli.
-            pattern = pdl.PatternOp(1, "addi_to_mul")
-            with InsertionPoint(pattern.body):
+            @pdl.pattern(benefit=1, sym_name="addi_to_mul")
+            def pat():
                 # Match arith.addi with index types.
                 index_type = pdl.TypeOp(IndexType.get())
                 operand0 = pdl.OperandOp(index_type)
@@ -49,8 +49,8 @@ def add_func(a, b):
                 )
 
                 # Replace the matched op with arith.muli.
-                rewrite = pdl.RewriteOp(op0)
-                with InsertionPoint(rewrite.add_body()):
+                @pdl.rewrite()
+                def rew():
                     newOp = pdl.OperationOp(
                         name="arith.muli", args=[operand0, operand1], types=[index_type]
                     )