Skip to content

Commit 65df99c

Browse files
authored
[NFC] Avoid potential nullptr deref by using castAs<> (#123395)
Use castAs<> instead of getAs<>
1 parent 07d03c8 commit 65df99c

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

clang/lib/CodeGen/CGBuiltin.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19333,9 +19333,9 @@ Value *CodeGenFunction::EmitHLSLBuiltinExpr(unsigned BuiltinID,
1933319333
assert(T0->isVectorTy() && T1->isVectorTy() &&
1933419334
"Dot product of vector and scalar is not supported.");
1933519335

19336-
auto *VecTy0 = E->getArg(0)->getType()->getAs<VectorType>();
19336+
auto *VecTy0 = E->getArg(0)->getType()->castAs<VectorType>();
1933719337
[[maybe_unused]] auto *VecTy1 =
19338-
E->getArg(1)->getType()->getAs<VectorType>();
19338+
E->getArg(1)->getType()->castAs<VectorType>();
1933919339

1934019340
assert(VecTy0->getElementType() == VecTy1->getElementType() &&
1934119341
"Dot product of vectors need the same element types.");
@@ -19428,7 +19428,7 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: {
1942819428
llvm::Type *Xty = Op0->getType();
1942919429
llvm::Type *retType = llvm::Type::getInt1Ty(this->getLLVMContext());
1943019430
if (Xty->isVectorTy()) {
19431-
auto *XVecTy = E->getArg(0)->getType()->getAs<VectorType>();
19431+
auto *XVecTy = E->getArg(0)->getType()->castAs<VectorType>();
1943219432
retType = llvm::VectorType::get(
1943319433
retType, ElementCount::getFixed(XVecTy->getNumElements()));
1943419434
}
@@ -19614,7 +19614,7 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: {
1961419614
llvm::Type *Xty = Op0->getType();
1961519615
llvm::Type *retType = llvm::Type::getInt32Ty(this->getLLVMContext());
1961619616
if (Xty->isVectorTy()) {
19617-
auto *XVecTy = Arg0->getType()->getAs<VectorType>();
19617+
auto *XVecTy = Arg0->getType()->castAs<VectorType>();
1961819618
retType = llvm::VectorType::get(
1961919619
retType, ElementCount::getFixed(XVecTy->getNumElements()));
1962019620
}

0 commit comments

Comments
 (0)