[lld][InstrProf] Do not use cstring offset hashes in function order for compression (#113606)

SharonXSharon · web-flow · commit 6827a00d4dfe · 2024-10-28T09:47:21.000-07:00
diff --git a/lld/MachO/BPSectionOrderer.cpp b/lld/MachO/BPSectionOrderer.cpp
@@ -53,11 +53,8 @@ getRelocHash(const Reloc &reloc,
     kind = ("Section " + Twine(static_cast<uint8_t>(isec->kind()))).str();
   if (auto *sym = reloc.referent.dyn_cast<Symbol *>()) {
     kind += (" Symbol " + Twine(static_cast<uint8_t>(sym->kind()))).str();
-    if (auto *d = dyn_cast<Defined>(sym)) {
-      if (isa_and_nonnull<CStringInputSection>(isec))
-        return getRelocHash(kind, 0, isec->getOffset(d->value), reloc.addend);
+    if (auto *d = dyn_cast<Defined>(sym))
       return getRelocHash(kind, sectionIdx.value_or(0), d->value, reloc.addend);
-    }
   }
   return getRelocHash(kind, sectionIdx.value_or(0), 0, reloc.addend);
 }

Original file line number	Diff line number	Diff line change
`@@ -53,11 +53,8 @@ getRelocHash(const Reloc &reloc,`
`53`	`53`	`kind = ("Section " + Twine(static_cast<uint8_t>(isec->kind()))).str();`
`54`	`54`	`if (auto sym = reloc.referent.dyn_cast<Symbol >()) {`
`55`	`55`	`kind += (" Symbol " + Twine(static_cast<uint8_t>(sym->kind()))).str();`
`56`		`- if (auto *d = dyn_cast<Defined>(sym)) {`
`57`		`- if (isa_and_nonnull<CStringInputSection>(isec))`
`58`		`- return getRelocHash(kind, 0, isec->getOffset(d->value), reloc.addend);`
	`56`	`+ if (auto *d = dyn_cast<Defined>(sym))`
`59`	`57`	`return getRelocHash(kind, sectionIdx.value_or(0), d->value, reloc.addend);`
`60`		`- }`
`61`	`58`	`}`
`62`	`59`	`return getRelocHash(kind, sectionIdx.value_or(0), 0, reloc.addend);`
`63`	`60`	`}`