Skip to content

Commit 6bb5041

Browse files
committed
[LVI][CVP] Add support for saturating add/sub
Adds support for the uadd.sat family of intrinsics in LVI, based on ConstantRange methods from D60946. Differential Revision: https://reviews.llvm.org/D62447 llvm-svn: 361703
1 parent 34d5a74 commit 6bb5041

File tree

2 files changed

+40
-4
lines changed

2 files changed

+40
-4
lines changed

llvm/lib/Analysis/LazyValueInfo.cpp

+36
Original file line numberDiff line numberDiff line change
@@ -432,6 +432,8 @@ namespace {
432432
BasicBlock *BB);
433433
bool solveBlockValueOverflowIntrinsic(
434434
ValueLatticeElement &BBLV, WithOverflowInst *WO, BasicBlock *BB);
435+
bool solveBlockValueIntrinsic(ValueLatticeElement &BBLV, IntrinsicInst *II,
436+
BasicBlock *BB);
435437
void intersectAssumeOrGuardBlockValueConstantRange(Value *Val,
436438
ValueLatticeElement &BBLV,
437439
Instruction *BBI);
@@ -649,6 +651,9 @@ bool LazyValueInfoImpl::solveBlockValueImpl(ValueLatticeElement &Res,
649651
if (auto *WO = dyn_cast<WithOverflowInst>(EVI->getAggregateOperand()))
650652
if (EVI->getNumIndices() == 1 && *EVI->idx_begin() == 0)
651653
return solveBlockValueOverflowIntrinsic(Res, WO, BB);
654+
655+
if (auto *II = dyn_cast<IntrinsicInst>(BBI))
656+
return solveBlockValueIntrinsic(Res, II, BB);
652657
}
653658

654659
LLVM_DEBUG(dbgs() << " compute BB '" << BB->getName()
@@ -1112,6 +1117,37 @@ bool LazyValueInfoImpl::solveBlockValueOverflowIntrinsic(
11121117
});
11131118
}
11141119

1120+
bool LazyValueInfoImpl::solveBlockValueIntrinsic(
1121+
ValueLatticeElement &BBLV, IntrinsicInst *II, BasicBlock *BB) {
1122+
switch (II->getIntrinsicID()) {
1123+
case Intrinsic::uadd_sat:
1124+
return solveBlockValueBinaryOpImpl(BBLV, II, BB,
1125+
[](const ConstantRange &CR1, const ConstantRange &CR2) {
1126+
return CR1.uadd_sat(CR2);
1127+
});
1128+
case Intrinsic::usub_sat:
1129+
return solveBlockValueBinaryOpImpl(BBLV, II, BB,
1130+
[](const ConstantRange &CR1, const ConstantRange &CR2) {
1131+
return CR1.usub_sat(CR2);
1132+
});
1133+
case Intrinsic::sadd_sat:
1134+
return solveBlockValueBinaryOpImpl(BBLV, II, BB,
1135+
[](const ConstantRange &CR1, const ConstantRange &CR2) {
1136+
return CR1.sadd_sat(CR2);
1137+
});
1138+
case Intrinsic::ssub_sat:
1139+
return solveBlockValueBinaryOpImpl(BBLV, II, BB,
1140+
[](const ConstantRange &CR1, const ConstantRange &CR2) {
1141+
return CR1.ssub_sat(CR2);
1142+
});
1143+
default:
1144+
LLVM_DEBUG(dbgs() << " compute BB '" << BB->getName()
1145+
<< "' - overdefined (unknown intrinsic).\n");
1146+
BBLV = ValueLatticeElement::getOverdefined();
1147+
return true;
1148+
}
1149+
}
1150+
11151151
static ValueLatticeElement getValueFromICmpCondition(Value *Val, ICmpInst *ICI,
11161152
bool isTrueDest) {
11171153
Value *LHS = ICI->getOperand(0);

llvm/test/Transforms/CorrelatedValuePropagation/basic.ll

+4-4
Original file line numberDiff line numberDiff line change
@@ -995,7 +995,7 @@ define i1 @uadd_sat_unknown(i32 %a) {
995995
; CHECK-NEXT: [[CMP2:%.*]] = icmp ugt i32 [[VAL]], 100
996996
; CHECK-NEXT: br i1 undef, label [[EXIT1:%.*]], label [[EXIT2:%.*]]
997997
; CHECK: exit1:
998-
; CHECK-NEXT: ret i1 [[CMP1]]
998+
; CHECK-NEXT: ret i1 true
999999
; CHECK: exit2:
10001000
; CHECK-NEXT: ret i1 [[CMP2]]
10011001
;
@@ -1018,7 +1018,7 @@ define i1 @usub_sat_unknown(i32 %a) {
10181018
; CHECK-NEXT: [[CMP2:%.*]] = icmp ult i32 [[VAL]], -101
10191019
; CHECK-NEXT: br i1 undef, label [[EXIT1:%.*]], label [[EXIT2:%.*]]
10201020
; CHECK: exit1:
1021-
; CHECK-NEXT: ret i1 [[CMP1]]
1021+
; CHECK-NEXT: ret i1 true
10221022
; CHECK: exit2:
10231023
; CHECK-NEXT: ret i1 [[CMP2]]
10241024
;
@@ -1041,7 +1041,7 @@ define i1 @sadd_sat_unknown(i32 %a) {
10411041
; CHECK-NEXT: [[CMP2:%.*]] = icmp sgt i32 [[VAL]], -2147483548
10421042
; CHECK-NEXT: br i1 undef, label [[EXIT1:%.*]], label [[EXIT2:%.*]]
10431043
; CHECK: exit1:
1044-
; CHECK-NEXT: ret i1 [[CMP1]]
1044+
; CHECK-NEXT: ret i1 true
10451045
; CHECK: exit2:
10461046
; CHECK-NEXT: ret i1 [[CMP2]]
10471047
;
@@ -1064,7 +1064,7 @@ define i1 @ssub_sat_unknown(i32 %a) {
10641064
; CHECK-NEXT: [[CMP2:%.*]] = icmp slt i32 [[VAL]], 2147483547
10651065
; CHECK-NEXT: br i1 undef, label [[EXIT1:%.*]], label [[EXIT2:%.*]]
10661066
; CHECK: exit1:
1067-
; CHECK-NEXT: ret i1 [[CMP1]]
1067+
; CHECK-NEXT: ret i1 true
10681068
; CHECK: exit2:
10691069
; CHECK-NEXT: ret i1 [[CMP2]]
10701070
;

0 commit comments

Comments
 (0)