Add comment about verification in the middle of the pass.

ingomueller-net · ingomueller-net · commit 71b40b1aeddf · 2023-10-06T07:39:00.000Z
diff --git a/mlir/lib/Dialect/Transform/Transforms/TransformInterpreterPassBase.cpp b/mlir/lib/Dialect/Transform/Transforms/TransformInterpreterPassBase.cpp
@@ -456,6 +456,8 @@ static LogicalResult mergeSymbolsInto(Operation *target,
     }
   }
 
+  // TODO: This duplicates pass infrastructure. We should split this pass into
+  //       several and let the pass infrastructure do the verification.
   for (auto *op : SmallVector<Operation *>{target, *other}) {
     if (failed(mlir::verify(op)))
       return op->emitError() << "failed to verify input op after renaming";

Original file line number	Diff line number	Diff line change
`@@ -456,6 +456,8 @@ static LogicalResult mergeSymbolsInto(Operation *target,`
`456`	`456`	`}`
`457`	`457`	`}`
`458`	`458`
	`459`	`+ // TODO: This duplicates pass infrastructure. We should split this pass into`
	`460`	`+ // several and let the pass infrastructure do the verification.`
`459`	`461`	`for (auto op : SmallVector<Operation >{target, *other}) {`
`460`	`462`	`if (failed(mlir::verify(op)))`
`461`	`463`	`return op->emitError() << "failed to verify input op after renaming";`