Skip to content

Commit 71e9cdc

Browse files
author
Peiming Liu
committed
address comments
1 parent 836b6b8 commit 71e9cdc

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

mlir/include/mlir/Dialect/SparseTensor/Transforms/Passes.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -471,7 +471,7 @@ def SparsificationAndBufferization : Pass<"sparsification-and-bufferization", "M
471471
def SparseSpaceCollapse : Pass<"sparse-space-collapse", "func::FuncOp"> {
472472
let summary = "(experimental) sparse space collpasing pass";
473473
let description = [{
474-
This pass collapse consecutive sparse spaces (extracted from the same tensor)
474+
This pass collapses consecutive sparse spaces (extracted from the same tensor)
475475
into one multi-dimensional space. The pass is not yet stablized.
476476
}];
477477
let constructor = "mlir::createSparseSpaceCollapsePass()";

mlir/lib/Dialect/SparseTensor/Transforms/SparseSpaceCollapse.cpp

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,14 @@
1414
#include "mlir/Dialect/SparseTensor/Transforms/Passes.h"
1515

1616
namespace mlir {
17-
1817
#define GEN_PASS_DEF_SPARSESPACECOLLAPSE
1918
#include "mlir/Dialect/SparseTensor/Transforms/Passes.h.inc"
19+
} // namespace mlir
20+
21+
using namespace mlir;
22+
using namespace sparse_tensor;
2023

21-
namespace sparse_tensor {
24+
namespace {
2225

2326
struct CollapseSpaceInfo {
2427
ExtractIterSpaceOp space;
@@ -174,10 +177,8 @@ struct SparseSpaceCollapsePass
174177
}
175178
};
176179

177-
} // namespace sparse_tensor
180+
} // namespace
178181

179-
std::unique_ptr<Pass> createSparseSpaceCollapsePass() {
180-
return std::make_unique<sparse_tensor::SparseSpaceCollapsePass>();
182+
std::unique_ptr<Pass> mlir::createSparseSpaceCollapsePass() {
183+
return std::make_unique<SparseSpaceCollapsePass>();
181184
}
182-
183-
} // namespace mlir

0 commit comments

Comments
 (0)