Meet review items

Author: AlexeyMerzlyakov

lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_riscv64.cpp

@@ -13,17 +13,15 @@
 using namespace lldb_private;
 
 std::unique_ptr<RegisterContextCorePOSIX_riscv64>
-RegisterContextCorePOSIX_riscv64::Create(
-    lldb_private::Thread &thread, const lldb_private::ArchSpec &arch,
-    const lldb_private::DataExtractor &gpregset,
-    llvm::ArrayRef<lldb_private::CoreNote> notes) {
+RegisterContextCorePOSIX_riscv64::Create(Thread &thread, const ArchSpec &arch,
+                                         const DataExtractor &gpregset,
+                                         llvm::ArrayRef<CoreNote> notes) {
   Flags flags = 0;
 
-  auto register_info_up =
-      std::make_unique<RegisterInfoPOSIX_riscv64>(arch, flags);
   return std::unique_ptr<RegisterContextCorePOSIX_riscv64>(
-      new RegisterContextCorePOSIX_riscv64(thread, std::move(register_info_up),
-                                           gpregset, notes));
+      new RegisterContextCorePOSIX_riscv64(
+          thread, std::make_unique<RegisterInfoPOSIX_riscv64>(arch, flags),
+          gpregset, notes));
 }
 
 RegisterContextCorePOSIX_riscv64::RegisterContextCorePOSIX_riscv64(
@@ -51,12 +49,12 @@ bool RegisterContextCorePOSIX_riscv64::ReadGPR() { return true; }
 bool RegisterContextCorePOSIX_riscv64::ReadFPR() { return true; }
 
 bool RegisterContextCorePOSIX_riscv64::WriteGPR() {
-  assert(0);
+  assert(false && "Writing registers is not allowed for core dumps");
   return false;
 }
 
 bool RegisterContextCorePOSIX_riscv64::WriteFPR() {
-  assert(0);
+  assert(false && "Writing registers is not allowed for core dumps");
   return false;
 }
 
@@ -67,9 +65,11 @@ bool RegisterContextCorePOSIX_riscv64::ReadRegister(
 
   if (IsGPR(reg_info->kinds[lldb::eRegisterKindLLDB])) {
     src = m_gpr.GetDataStart();
-  } else { // IsFPR
+  } else if (IsFPR(reg_info->kinds[lldb::eRegisterKindLLDB])) {
     src = m_fpr.GetDataStart();
     offset -= GetGPRSize();
+  } else {
+    return false;
   }
 
   Status error;