using llvm_unreachable

Author: fschlimb

mlir/lib/CAPI/IR/IR.cpp

@@ -736,8 +736,7 @@ static mlir::WalkResult unwrap(MlirWalkResult result) {
   case MlirWalkResultSkip:
     return mlir::WalkResult::skip();
   }
-  assert("unknown result in WalkResult::unwrap" == nullptr);
-  return {};
+  llvm_unreachable("unknown result in WalkResult::unwrap");
 }
 
 void mlirOperationWalk(MlirOperation op, MlirOperationWalkCallback callback,

mlir/lib/Conversion/ArmSMEToLLVM/ArmSMEToLLVM.cpp

@@ -80,8 +80,7 @@ static Operation *createLoadTileSliceIntrinsic(
       break;
     }
   }
-  assert("unknown type in createLoadTileSliceIntrinsic" == nullptr);
-  return nullptr;
+  llvm_unreachable("unknown type in createLoadTileSliceIntrinsic");
 }
 
 /// Helper to create an arm_sme.intr.st1*.(horiz|vert)' intrinsic.
@@ -126,8 +125,7 @@ static Operation *createStoreTileSliceIntrinsic(
           loc, maskOp, ptr, tileId, tileSliceI32);
     }
   }
-  assert("unknown type in createStoreTileSliceIntrinsic" == nullptr);
-  return nullptr;
+  llvm_unreachable("unknown type in createStoreTileSliceIntrinsic");
 }
 
 IntegerAttr getTileIdOrError(arm_sme::ArmSMETileOpInterface op) {
@@ -852,8 +850,7 @@ struct StreamingVLOpConversion
       case arm_sme::TypeSize::Double:
         return rewriter.create<arm_sme::aarch64_sme_cntsd>(loc, i64Type);
       }
-      assert("unknown type in StreamingVLOpConversion" == nullptr);
-      return nullptr;
+      llvm_unreachable("unknown type in StreamingVLOpConversion");
     }();
     rewriter.replaceOpWithNewOp<arith::IndexCastOp>(
         streamingVlOp, rewriter.getIndexType(), intrOp->getResult(0));

mlir/lib/Conversion/IndexToSPIRV/IndexToSPIRV.cpp

@@ -310,8 +310,7 @@ struct ConvertIndexCmpPattern final : OpConversionPattern<CmpOp> {
     case IndexCmpPredicate::ULT:
       return rewriteCmpOp<spirv::ULessThanOp>(op, adaptor, rewriter);
     }
-    assert("Unknown predicate in ConvertIndexCmpPattern" == nullptr);
-    return failure();
+    llvm_unreachable("Unknown predicate in ConvertIndexCmpPattern");
   }
 };
 

mlir/lib/Dialect/ArmSME/Transforms/TileAllocation.cpp

@@ -137,8 +137,7 @@ static ArrayRef<TileMask> getMasks(ArmSMETileType type) {
   case ArmSMETileType::ZAQ:
     return ZA_Q_MASKS;
   }
-  assert("unknown type in getMasks" == nullptr);
-  return {};
+  llvm_unreachable("unknown type in getMasks");
 }
 
 class TileAllocator {

mlir/lib/Dialect/Index/IR/IndexOps.cpp

@@ -594,8 +594,7 @@ static bool compareSameArgs(IndexCmpPredicate pred) {
   case IndexCmpPredicate::ULT:
     return false;
   }
-  assert("unknown predicate in compareSameArgs" == nullptr);
-  return {};
+  llvm_unreachable("unknown predicate in compareSameArgs");
 }
 
 OpFoldResult CmpOp::fold(FoldAdaptor adaptor) {