handle review comments

Author: ergawy

flang/lib/Lower/OpenMP/DataSharingProcessor.cpp

@@ -557,9 +557,8 @@ void DataSharingProcessor::doPrivatize(const semantics::Symbol *sym,
                                  : firOpBuilder.createConvert(
                                        cloneAddr.getLoc(), symType, cloneAddr);
 
-      auto yieldOp = firOpBuilder.create<mlir::omp::YieldOp>(
-          hsb.getAddr().getLoc(), yieldedValue);
-      yieldOp.getOperand(0).getType();
+      firOpBuilder.create<mlir::omp::YieldOp>(hsb.getAddr().getLoc(),
+                                              yieldedValue);
       symTable->popScope();
     }
 

mlir/test/Target/LLVMIR/openmp-private.mlir

@@ -263,9 +263,10 @@ omp.private {type = firstprivate} @_QFequivalenceEx_firstprivate_ptr_f32 : !llvm
 }
 
 // CHECK: define internal void @_QPequivalence..omp_par
+// CHECK-NOT: define {{.*}} @{{.*}}
 // CHECK:   %[[PRIV_ALLOC:.*]] = alloca float, i64 1, align 4
 // CHECK:   %[[HOST_VAL:.*]] = load float, ptr %{{.*}}, align 4
-// Test that we initialzie the firstprivate variable.
+// Test that we initialize the firstprivate variable.
 // CHECK:   store float %[[HOST_VAL]], ptr %[[PRIV_ALLOC]], align 4
 // Test that we inlined the body of the parallel region.
 // CHECK:   store float 0x{{.*}}, ptr %[[PRIV_ALLOC]], align 4