Skip to content

Commit 74db5c8

Browse files
committed
Revert rG6a605b97a200 due to excessive memory use
Over in the comments for D116821, some use-cases have cropped up where there's a substantial increase in memory usage. A quick inspection shows that a) it's a lot of memory and b) there are several things to be done to reduce it. Reverting (via disabling this feature by default) to avoid bothering people in the meantime.
1 parent 80532eb commit 74db5c8

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

llvm/lib/CodeGen/LiveDebugValues/LiveDebugValues.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,10 +124,13 @@ bool LiveDebugValues::runOnMachineFunction(MachineFunction &MF) {
124124

125125
bool llvm::debuginfoShouldUseDebugInstrRef(const Triple &T) {
126126
// Enable by default on x86_64, disable if explicitly turned off on cmdline.
127+
// Disabled while https://reviews.llvm.org/D116821 is investigated.
128+
#if 0
127129
if (T.getArch() == llvm::Triple::x86_64 &&
128130
ValueTrackingVariableLocations != cl::boolOrDefault::BOU_FALSE)
129131
return true;
132+
#endif
130133

131-
// Otherwise: enable if explicitly requestedo n command line.
134+
// Otherwise: enable if explicitly requested on command line.
132135
return ValueTrackingVariableLocations == cl::boolOrDefault::BOU_TRUE;
133136
}

llvm/test/DebugInfo/X86/instr-ref-flag.ll

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@
1313
;; by llc by default, and that it can be turned explicitly on or off as
1414
;; desired.
1515

16+
;; Xfail due to faults found in the discussion on
17+
;; https://reviews.llvm.org/D116821
18+
; XFAIL: *
19+
1620
; INSTRREFON: DBG_INSTR_REF
1721
; INSTRREFOFF: DBG_VALUE
1822

0 commit comments

Comments
 (0)