Skip to content

Commit 75d7a52

Browse files
broxigarchenbroxigarchen
committed
address comments
1 parent 25dc466 commit 75d7a52

File tree

4 files changed

+60
-71
lines changed

4 files changed

+60
-71
lines changed

‎llvm/test/MC/AMDGPU/gfx11_asm_t16.s

Lines changed: 0 additions & 59 deletions
This file was deleted.

‎llvm/test/MC/AMDGPU/gfx11_asm_vop1.s

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2630,6 +2630,36 @@ v_log_f32 v5, src_scc
26302630
v_log_f32 v255, 0xaf123456
26312631
// GFX11: v_log_f32_e32 v255, 0xaf123456 ; encoding: [0xff,0x4e,0xfe,0x7f,0x56,0x34,0x12,0xaf]
26322632

2633+
v_mov_b16_e32 v0.l, v1.l
2634+
// GFX11: v_mov_b16_e32 v0.l, v1.l ; encoding: [0x01,0x39,0x00,0x7e]
2635+
2636+
v_mov_b16_e32 v0.l, s1
2637+
// GFX11: v_mov_b16_e32 v0.l, s1 ; encoding: [0x01,0x38,0x00,0x7e]
2638+
2639+
v_mov_b16_e32 v0.h, 0
2640+
// GFX11: v_mov_b16_e32 v0.h, 0 ; encoding: [0x80,0x38,0x00,0x7f]
2641+
2642+
v_mov_b16_e32 v0.h, 1.0
2643+
// GFX11: v_mov_b16_e32 v0.h, 1.0 ; encoding: [0xf2,0x38,0x00,0x7f]
2644+
2645+
v_mov_b16_e32 v0.l, 0x1234
2646+
// GFX11: v_mov_b16_e32 v0.l, 0x1234 ; encoding: [0xff,0x38,0x00,0x7e,0x34,0x12,0x00,0x00]
2647+
2648+
v_mov_b16_e64 v0.l, v1.l
2649+
// GFX11: v_mov_b16_e64 v0.l, v1.l ; encoding: [0x00,0x00,0x9c,0xd5,0x01,0x01,0x00,0x00]
2650+
2651+
v_mov_b16_e64 v200.l, v1.h
2652+
// GFX11: v_mov_b16_e64 v200.l, v1.h op_sel:[1,0] ; encoding: [0xc8,0x08,0x9c,0xd5,0x01,0x01,0x00,0x00]
2653+
2654+
v_mov_b16_e64 v0.l, s1
2655+
// GFX11: v_mov_b16_e64 v0.l, s1 ; encoding: [0x00,0x00,0x9c,0xd5,0x01,0x00,0x00,0x00]
2656+
2657+
v_mov_b16_e64 v200.h, 1
2658+
// GFX11: v_mov_b16_e64 v200.h, 1 op_sel:[0,1] ; encoding: [0xc8,0x40,0x9c,0xd5,0x81,0x00,0x00,0x00]
2659+
2660+
v_mov_b16_e64 v0.l, 0x1234
2661+
// GFX11: v_mov_b16_e64 v0.l, 0x1234 ; encoding: [0x00,0x00,0x9c,0xd5,0xff,0x00,0x00,0x00,0x34,0x12,0x00,0x00]
2662+
26332663
v_mov_b32 v5, v1
26342664
// GFX11: v_mov_b32_e32 v5, v1 ; encoding: [0x01,0x03,0x0a,0x7e]
26352665

‎llvm/test/MC/AMDGPU/gfx11_asm_vop3_features.s

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,6 @@
44
// RUN: not llvm-mc -triple=amdgcn -mcpu=gfx1100 -mattr=+wavefrontsize32,+real-true16 -filetype=null %s 2>&1 | FileCheck --check-prefixes=W32-ERR,GFX11-ERR --implicit-check-not=error: %s
55
// RUN: not llvm-mc -triple=amdgcn -mcpu=gfx1100 -mattr=+wavefrontsize64,+real-true16 -filetype=null %s 2>&1 | FileCheck --check-prefixes=W64-ERR,GFX11-ERR --implicit-check-not=error: %s
66

7-
//===----------------------------------------------------------------------===//
8-
// FIXME-TRUE16
9-
// It is unknown whether fp inline constants are allowed by hardware. Upstream
10-
// LLVM allows them
11-
//===----------------------------------------------------------------------===//
12-
13-
v_alignbit_b32 v5, v1, v2, 0.5
14-
// GFX11: v_alignbit_b32 v5, v1, v2, 0.5 ; encoding: [0x05,0x00,0x16,0xd6,0x01,0x05,0xc2,0x03]
15-
16-
v_alignbyte_b32 v5, v1, v2, 0.5
17-
// GFX11: v_alignbyte_b32 v5, v1, v2, 0.5 ; encoding: [0x05,0x00,0x17,0xd6,0x01,0x05,0xc2,0x03]
18-
197
//===----------------------------------------------------------------------===//
208
// HW correctly handles fp inline constants for src2 (they have f16 type).
219
// Check that inline constants are not converted to literals.

‎llvm/test/MC/AMDGPU/gfx12_asm_vop1.s

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2696,6 +2696,36 @@ v_log_f32 v5, src_scc
26962696
v_log_f32 v255, 0xaf123456
26972697
// GFX12: v_log_f32_e32 v255, 0xaf123456 ; encoding: [0xff,0x4e,0xfe,0x7f,0x56,0x34,0x12,0xaf]
26982698

2699+
v_mov_b16_e32 v0.l, v1.l
2700+
// GFX12: v_mov_b16_e32 v0.l, v1.l ; encoding: [0x01,0x39,0x00,0x7e]
2701+
2702+
v_mov_b16_e32 v0.l, s1
2703+
// GFX12: v_mov_b16_e32 v0.l, s1 ; encoding: [0x01,0x38,0x00,0x7e]
2704+
2705+
v_mov_b16_e32 v0.h, 0
2706+
// GFX12: v_mov_b16_e32 v0.h, 0 ; encoding: [0x80,0x38,0x00,0x7f]
2707+
2708+
v_mov_b16_e32 v0.h, 1.0
2709+
// GFX12: v_mov_b16_e32 v0.h, 1.0 ; encoding: [0xf2,0x38,0x00,0x7f]
2710+
2711+
v_mov_b16_e32 v0.l, 0x1234
2712+
// GFX12: v_mov_b16_e32 v0.l, 0x1234 ; encoding: [0xff,0x38,0x00,0x7e,0x34,0x12,0x00,0x00]
2713+
2714+
v_mov_b16_e64 v0.l, v1.l
2715+
// GFX12: v_mov_b16_e64 v0.l, v1.l ; encoding: [0x00,0x00,0x9c,0xd5,0x01,0x01,0x00,0x00]
2716+
2717+
v_mov_b16_e64 v200.l, v1.h
2718+
// GFX12: v_mov_b16_e64 v200.l, v1.h op_sel:[1,0] ; encoding: [0xc8,0x08,0x9c,0xd5,0x01,0x01,0x00,0x00]
2719+
2720+
v_mov_b16_e64 v0.l, s1
2721+
// GFX12: v_mov_b16_e64 v0.l, s1 ; encoding: [0x00,0x00,0x9c,0xd5,0x01,0x00,0x00,0x00]
2722+
2723+
v_mov_b16_e64 v200.h, 1
2724+
// GFX12: v_mov_b16_e64 v200.h, 1 op_sel:[0,1] ; encoding: [0xc8,0x40,0x9c,0xd5,0x81,0x00,0x00,0x00]
2725+
2726+
v_mov_b16_e64 v0.l, 0x1234
2727+
// GFX12: v_mov_b16_e64 v0.l, 0x1234 ; encoding: [0x00,0x00,0x9c,0xd5,0xff,0x00,0x00,0x00,0x34,0x12,0x00,0x00]
2728+
26992729
v_mov_b32 v5, v1
27002730
// GFX12: v_mov_b32_e32 v5, v1 ; encoding: [0x01,0x03,0x0a,0x7e]
27012731

0 commit comments

Comments
 (0)