File tree 1 file changed +18
-0
lines changed
1 file changed +18
-0
lines changed Original file line number Diff line number Diff line change @@ -272,3 +272,21 @@ Developers should participate in code reviews as both reviewers and
272
272
authors. If someone is kind enough to review your code, you should return the
273
273
favor for someone else. Note that anyone is welcome to review and give feedback
274
274
on a patch, but approval of patches should be consistent with the policy above.
275
+
276
+ Upstreaming Changes to LLVM
277
+ ===========================
278
+
279
+ When upstreaming your own changes from a downstream project to LLVM, simply
280
+ follow the process outlined above.
281
+
282
+ When upstreaming changes originally written by someone else:
283
+
284
+ * Ensure that there are no obstacles to upstreaming the code. In some cases,
285
+ this simply means checking with the original author(s) to ensure they are
286
+ aware of and approve the upstreaming. In other cases, licensing
287
+ considerations may be more complex.
288
+ * Properly attribute the original changes, e.g., by creating a commit with
289
+ multiple authors (`GitHub guide <https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors >`_).
290
+ * Invite the original author(s) to review the changes, and also include
291
+ additional reviewers. Specifically, an LGTM from a (co-)author should not be
292
+ taken as approval to land a change.
You can’t perform that action at this time.
0 commit comments