Skip to content

Commit 7830c3e

Browse files
authored
Revert "[Driver] Add toolchain for X86_64 UEFI target (#76838)"
This reverts commit d1335fb.
1 parent 221f15f commit 7830c3e

File tree

10 files changed

+0
-244
lines changed

10 files changed

+0
-244
lines changed

clang/lib/Basic/Targets.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -613,9 +613,6 @@ std::unique_ptr<TargetInfo> AllocateTarget(const llvm::Triple &Triple,
613613
case llvm::Triple::Solaris:
614614
return std::make_unique<SolarisTargetInfo<X86_64TargetInfo>>(Triple,
615615
Opts);
616-
case llvm::Triple::UEFI:
617-
return std::make_unique<UEFIX86_64TargetInfo>(Triple, Opts);
618-
619616
case llvm::Triple::Win32: {
620617
switch (Triple.getEnvironment()) {
621618
case llvm::Triple::Cygnus:

clang/lib/Basic/Targets/OSTargets.h

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -778,21 +778,6 @@ class LLVM_LIBRARY_VISIBILITY ZOSTargetInfo : public OSTargetInfo<Target> {
778778
}
779779
};
780780

781-
// UEFI target
782-
template <typename Target>
783-
class LLVM_LIBRARY_VISIBILITY UEFITargetInfo : public OSTargetInfo<Target> {
784-
protected:
785-
void getOSDefines(const LangOptions &Opts, const llvm::Triple &Triple,
786-
MacroBuilder &Builder) const override {}
787-
788-
public:
789-
UEFITargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts)
790-
: OSTargetInfo<Target>(Triple, Opts) {
791-
this->WCharType = TargetInfo::UnsignedShort;
792-
this->WIntType = TargetInfo::UnsignedShort;
793-
}
794-
};
795-
796781
void addWindowsDefines(const llvm::Triple &Triple, const LangOptions &Opts,
797782
MacroBuilder &Builder);
798783

clang/lib/Basic/Targets/X86.h

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -814,43 +814,6 @@ class LLVM_LIBRARY_VISIBILITY X86_64TargetInfo : public X86TargetInfo {
814814
}
815815
};
816816

817-
// x86-64 UEFI target
818-
class LLVM_LIBRARY_VISIBILITY UEFIX86_64TargetInfo
819-
: public UEFITargetInfo<X86_64TargetInfo> {
820-
public:
821-
UEFIX86_64TargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts)
822-
: UEFITargetInfo<X86_64TargetInfo>(Triple, Opts) {
823-
this->TheCXXABI.set(TargetCXXABI::Microsoft);
824-
this->MaxTLSAlign = 8192u * this->getCharWidth();
825-
this->resetDataLayout("e-m:w-p270:32:32-p271:32:32-p272:64:64-"
826-
"i64:64-i128:128-f80:128-n8:16:32:64-S128");
827-
}
828-
829-
void getTargetDefines(const LangOptions &Opts,
830-
MacroBuilder &Builder) const override {
831-
getOSDefines(Opts, X86TargetInfo::getTriple(), Builder);
832-
}
833-
834-
BuiltinVaListKind getBuiltinVaListKind() const override {
835-
return TargetInfo::CharPtrBuiltinVaList;
836-
}
837-
838-
CallingConvCheckResult checkCallingConvention(CallingConv CC) const override {
839-
switch (CC) {
840-
case CC_C:
841-
case CC_Win64:
842-
return CCCR_OK;
843-
default:
844-
return CCCR_Warning;
845-
}
846-
}
847-
848-
TargetInfo::CallingConvKind
849-
getCallingConvKind(bool ClangABICompat4) const override {
850-
return CCK_MicrosoftWin64;
851-
}
852-
};
853-
854817
// x86-64 Windows target
855818
class LLVM_LIBRARY_VISIBILITY WindowsX86_64TargetInfo
856819
: public WindowsTargetInfo<X86_64TargetInfo> {

clang/lib/Driver/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ add_clang_library(clangDriver
7878
ToolChains/Solaris.cpp
7979
ToolChains/SPIRV.cpp
8080
ToolChains/TCE.cpp
81-
ToolChains/UEFI.cpp
8281
ToolChains/VEToolchain.cpp
8382
ToolChains/WebAssembly.cpp
8483
ToolChains/XCore.cpp

clang/lib/Driver/Driver.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545
#include "ToolChains/SPIRV.h"
4646
#include "ToolChains/Solaris.h"
4747
#include "ToolChains/TCE.h"
48-
#include "ToolChains/UEFI.h"
4948
#include "ToolChains/VEToolchain.h"
5049
#include "ToolChains/WebAssembly.h"
5150
#include "ToolChains/XCore.h"
@@ -6417,9 +6416,6 @@ const ToolChain &Driver::getToolChain(const ArgList &Args,
64176416
case llvm::Triple::Mesa3D:
64186417
TC = std::make_unique<toolchains::AMDGPUToolChain>(*this, Target, Args);
64196418
break;
6420-
case llvm::Triple::UEFI:
6421-
TC = std::make_unique<toolchains::UEFI>(*this, Target, Args);
6422-
break;
64236419
case llvm::Triple::Win32:
64246420
switch (Target.getEnvironment()) {
64256421
default:

clang/lib/Driver/ToolChains/UEFI.cpp

Lines changed: 0 additions & 88 deletions
This file was deleted.

clang/lib/Driver/ToolChains/UEFI.h

Lines changed: 0 additions & 59 deletions
This file was deleted.

clang/test/CodeGen/X86/uefi-data-layout.c

Lines changed: 0 additions & 3 deletions
This file was deleted.

clang/test/Driver/uefi-constructed-args.c

Lines changed: 0 additions & 13 deletions
This file was deleted.

clang/unittests/Driver/ToolChainTest.cpp

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
#include "clang/Basic/DiagnosticIDs.h"
1515
#include "clang/Basic/DiagnosticOptions.h"
1616
#include "clang/Basic/LLVM.h"
17-
#include "clang/Basic/TargetInfo.h"
1817
#include "clang/Basic/TargetOptions.h"
1918
#include "clang/Driver/Compilation.h"
2019
#include "clang/Driver/Driver.h"
@@ -575,26 +574,6 @@ TEST(CompilerInvocation, SplitSwarfSingleCrash) {
575574
EXPECT_TRUE(CI); // no-crash
576575
}
577576

578-
TEST(ToolChainTest, UEFICallingConventionTest) {
579-
clang::CompilerInstance compiler;
580-
compiler.createDiagnostics();
581-
582-
std::string TrStr = "x86_64-unknown-uefi";
583-
llvm::Triple Tr(TrStr);
584-
Tr.setOS(llvm::Triple::OSType::UEFI);
585-
Tr.setVendor(llvm::Triple::VendorType::UnknownVendor);
586-
Tr.setEnvironment(llvm::Triple::EnvironmentType::UnknownEnvironment);
587-
Tr.setArch(llvm::Triple::ArchType::x86_64);
588-
589-
compiler.getTargetOpts().Triple = Tr.getTriple();
590-
compiler.setTarget(clang::TargetInfo::CreateTargetInfo(
591-
compiler.getDiagnostics(),
592-
std::make_shared<clang::TargetOptions>(compiler.getTargetOpts())));
593-
594-
EXPECT_EQ(compiler.getTarget().getCallingConvKind(true),
595-
TargetInfo::CallingConvKind::CCK_MicrosoftWin64);
596-
}
597-
598577
TEST(GetDriverMode, PrefersLastDriverMode) {
599578
static constexpr const char *Args[] = {"clang-cl", "--driver-mode=foo",
600579
"--driver-mode=bar", "foo.cpp"};

0 commit comments

Comments
 (0)