Skip to content

Commit 79567a1

Browse files
apivovarovapivovarov
committed
Add f8E4M3 IEEE 754 type
1 parent e5fb4d8 commit 79567a1

File tree

29 files changed

+204
-13
lines changed

29 files changed

+204
-13
lines changed

‎clang/include/clang/AST/Stmt.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -460,10 +460,10 @@ class alignas(void *) Stmt {
460460
unsigned : NumExprBits;
461461

462462
static_assert(
463-
llvm::APFloat::S_MaxSemantics < 16,
464-
"Too many Semantics enum values to fit in bitfield of size 4");
463+
llvm::APFloat::S_MaxSemantics < 32,
464+
"Too many Semantics enum values to fit in bitfield of size 5");
465465
LLVM_PREFERRED_TYPE(llvm::APFloat::Semantics)
466-
unsigned Semantics : 4; // Provides semantics for APFloat construction
466+
unsigned Semantics : 5; // Provides semantics for APFloat construction
467467
LLVM_PREFERRED_TYPE(bool)
468468
unsigned IsExact : 1;
469469
};

‎clang/lib/AST/MicrosoftMangle.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -946,6 +946,7 @@ void MicrosoftCXXNameMangler::mangleFloat(llvm::APFloat Number) {
946946
case APFloat::S_IEEEquad: Out << 'Y'; break;
947947
case APFloat::S_PPCDoubleDouble: Out << 'Z'; break;
948948
case APFloat::S_Float8E5M2:
949+
case APFloat::S_Float8E4M3:
949950
case APFloat::S_Float8E4M3FN:
950951
case APFloat::S_Float8E5M2FNUZ:
951952
case APFloat::S_Float8E4M3FNUZ:

‎llvm/include/llvm/ADT/APFloat.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,9 @@ struct APFloatBase {
166166
// This format's exponent bias is 16, instead of the 15 (2 ** (5 - 1) - 1)
167167
// that IEEE precedent would imply.
168168
S_Float8E5M2FNUZ,
169+
// 8-bit floating point number following IEEE-754 conventions with bit
170+
// layout S1E4M3.
171+
S_Float8E4M3,
169172
// 8-bit floating point number mostly following IEEE-754 conventions with
170173
// bit layout S1E4M3 as described in https://arxiv.org/abs/2209.05433.
171174
// Unlike IEEE-754 types, there are no infinity values, and NaN is
@@ -217,6 +220,7 @@ struct APFloatBase {
217220
static const fltSemantics &PPCDoubleDouble() LLVM_READNONE;
218221
static const fltSemantics &Float8E5M2() LLVM_READNONE;
219222
static const fltSemantics &Float8E5M2FNUZ() LLVM_READNONE;
223+
static const fltSemantics &Float8E4M3() LLVM_READNONE;
220224
static const fltSemantics &Float8E4M3FN() LLVM_READNONE;
221225
static const fltSemantics &Float8E4M3FNUZ() LLVM_READNONE;
222226
static const fltSemantics &Float8E4M3B11FNUZ() LLVM_READNONE;
@@ -638,6 +642,7 @@ class IEEEFloat final : public APFloatBase {
638642
APInt convertPPCDoubleDoubleAPFloatToAPInt() const;
639643
APInt convertFloat8E5M2APFloatToAPInt() const;
640644
APInt convertFloat8E5M2FNUZAPFloatToAPInt() const;
645+
APInt convertFloat8E4M3APFloatToAPInt() const;
641646
APInt convertFloat8E4M3FNAPFloatToAPInt() const;
642647
APInt convertFloat8E4M3FNUZAPFloatToAPInt() const;
643648
APInt convertFloat8E4M3B11FNUZAPFloatToAPInt() const;
@@ -656,6 +661,7 @@ class IEEEFloat final : public APFloatBase {
656661
void initFromPPCDoubleDoubleAPInt(const APInt &api);
657662
void initFromFloat8E5M2APInt(const APInt &api);
658663
void initFromFloat8E5M2FNUZAPInt(const APInt &api);
664+
void initFromFloat8E4M3APInt(const APInt &api);
659665
void initFromFloat8E4M3FNAPInt(const APInt &api);
660666
void initFromFloat8E4M3FNUZAPInt(const APInt &api);
661667
void initFromFloat8E4M3B11FNUZAPInt(const APInt &api);

‎llvm/lib/Support/APFloat.cpp

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ static constexpr fltSemantics semIEEEquad = {16383, -16382, 113, 128};
136136
static constexpr fltSemantics semFloat8E5M2 = {15, -14, 3, 8};
137137
static constexpr fltSemantics semFloat8E5M2FNUZ = {
138138
15, -15, 3, 8, fltNonfiniteBehavior::NanOnly, fltNanEncoding::NegativeZero};
139+
static constexpr fltSemantics semFloat8E4M3 = {7, -6, 4, 8};
139140
static constexpr fltSemantics semFloat8E4M3FN = {
140141
8, -6, 4, 8, fltNonfiniteBehavior::NanOnly, fltNanEncoding::AllOnes};
141142
static constexpr fltSemantics semFloat8E4M3FNUZ = {
@@ -208,6 +209,8 @@ const llvm::fltSemantics &APFloatBase::EnumToSemantics(Semantics S) {
208209
return Float8E5M2();
209210
case S_Float8E5M2FNUZ:
210211
return Float8E5M2FNUZ();
212+
case S_Float8E4M3:
213+
return Float8E4M3();
211214
case S_Float8E4M3FN:
212215
return Float8E4M3FN();
213216
case S_Float8E4M3FNUZ:
@@ -246,6 +249,8 @@ APFloatBase::SemanticsToEnum(const llvm::fltSemantics &Sem) {
246249
return S_Float8E5M2;
247250
else if (&Sem == &llvm::APFloat::Float8E5M2FNUZ())
248251
return S_Float8E5M2FNUZ;
252+
else if (&Sem == &llvm::APFloat::Float8E4M3())
253+
return S_Float8E4M3;
249254
else if (&Sem == &llvm::APFloat::Float8E4M3FN())
250255
return S_Float8E4M3FN;
251256
else if (&Sem == &llvm::APFloat::Float8E4M3FNUZ())
@@ -276,6 +281,7 @@ const fltSemantics &APFloatBase::PPCDoubleDouble() {
276281
}
277282
const fltSemantics &APFloatBase::Float8E5M2() { return semFloat8E5M2; }
278283
const fltSemantics &APFloatBase::Float8E5M2FNUZ() { return semFloat8E5M2FNUZ; }
284+
const fltSemantics &APFloatBase::Float8E4M3() { return semFloat8E4M3; }
279285
const fltSemantics &APFloatBase::Float8E4M3FN() { return semFloat8E4M3FN; }
280286
const fltSemantics &APFloatBase::Float8E4M3FNUZ() { return semFloat8E4M3FNUZ; }
281287
const fltSemantics &APFloatBase::Float8E4M3B11FNUZ() {
@@ -3617,6 +3623,11 @@ APInt IEEEFloat::convertFloat8E5M2FNUZAPFloatToAPInt() const {
36173623
return convertIEEEFloatToAPInt<semFloat8E5M2FNUZ>();
36183624
}
36193625

3626+
APInt IEEEFloat::convertFloat8E4M3APFloatToAPInt() const {
3627+
assert(partCount() == 1);
3628+
return convertIEEEFloatToAPInt<semFloat8E4M3>();
3629+
}
3630+
36203631
APInt IEEEFloat::convertFloat8E4M3FNAPFloatToAPInt() const {
36213632
assert(partCount() == 1);
36223633
return convertIEEEFloatToAPInt<semFloat8E4M3FN>();
@@ -3681,6 +3692,9 @@ APInt IEEEFloat::bitcastToAPInt() const {
36813692
if (semantics == (const llvm::fltSemantics *)&semFloat8E5M2FNUZ)
36823693
return convertFloat8E5M2FNUZAPFloatToAPInt();
36833694

3695+
if (semantics == (const llvm::fltSemantics *)&semFloat8E4M3)
3696+
return convertFloat8E4M3APFloatToAPInt();
3697+
36843698
if (semantics == (const llvm::fltSemantics *)&semFloat8E4M3FN)
36853699
return convertFloat8E4M3FNAPFloatToAPInt();
36863700

@@ -3902,6 +3916,10 @@ void IEEEFloat::initFromFloat8E5M2FNUZAPInt(const APInt &api) {
39023916
initFromIEEEAPInt<semFloat8E5M2FNUZ>(api);
39033917
}
39043918

3919+
void IEEEFloat::initFromFloat8E4M3APInt(const APInt &api) {
3920+
initFromIEEEAPInt<semFloat8E4M3>(api);
3921+
}
3922+
39053923
void IEEEFloat::initFromFloat8E4M3FNAPInt(const APInt &api) {
39063924
initFromIEEEAPInt<semFloat8E4M3FN>(api);
39073925
}
@@ -3951,6 +3969,8 @@ void IEEEFloat::initFromAPInt(const fltSemantics *Sem, const APInt &api) {
39513969
return initFromFloat8E5M2APInt(api);
39523970
if (Sem == &semFloat8E5M2FNUZ)
39533971
return initFromFloat8E5M2FNUZAPInt(api);
3972+
if (Sem == &semFloat8E4M3)
3973+
return initFromFloat8E4M3APInt(api);
39543974
if (Sem == &semFloat8E4M3FN)
39553975
return initFromFloat8E4M3FNAPInt(api);
39563976
if (Sem == &semFloat8E4M3FNUZ)

‎llvm/unittests/ADT/APFloatTest.cpp

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2133,6 +2133,8 @@ TEST(APFloatTest, getZero) {
21332133
{&APFloat::Float8E5M2(), true, true, {0x80ULL, 0}, 1},
21342134
{&APFloat::Float8E5M2FNUZ(), false, false, {0, 0}, 1},
21352135
{&APFloat::Float8E5M2FNUZ(), true, false, {0, 0}, 1},
2136+
{&APFloat::Float8E4M3(), false, true, {0, 0}, 1},
2137+
{&APFloat::Float8E4M3(), true, true, {0x80ULL, 0}, 1},
21362138
{&APFloat::Float8E4M3FN(), false, true, {0, 0}, 1},
21372139
{&APFloat::Float8E4M3FN(), true, true, {0x80ULL, 0}, 1},
21382140
{&APFloat::Float8E4M3FNUZ(), false, false, {0, 0}, 1},
@@ -6846,6 +6848,42 @@ TEST(APFloatTest, Float8E5M2ToFloat) {
68466848
EXPECT_TRUE(std::isnan(QNaN.convertToFloat()));
68476849
}
68486850

6851+
TEST(APFloatTest, Float8E4M3ToFloat) {
6852+
APFloat PosZero = APFloat::getZero(APFloat::Float8E4M3());
6853+
APFloat PosZeroToFloat(PosZero.convertToFloat());
6854+
EXPECT_TRUE(PosZeroToFloat.isPosZero());
6855+
APFloat NegZero = APFloat::getZero(APFloat::Float8E4M3(), true);
6856+
APFloat NegZeroToFloat(NegZero.convertToFloat());
6857+
EXPECT_TRUE(NegZeroToFloat.isNegZero());
6858+
6859+
APFloat One(APFloat::Float8E4M3(), "1.0");
6860+
EXPECT_EQ(1.0F, One.convertToFloat());
6861+
APFloat Two(APFloat::Float8E4M3(), "2.0");
6862+
EXPECT_EQ(2.0F, Two.convertToFloat());
6863+
6864+
APFloat PosLargest = APFloat::getLargest(APFloat::Float8E4M3(), false);
6865+
EXPECT_EQ(240.0F, PosLargest.convertToFloat());
6866+
APFloat NegLargest = APFloat::getLargest(APFloat::Float8E4M3(), true);
6867+
EXPECT_EQ(-240.0F, NegLargest.convertToFloat());
6868+
APFloat PosSmallest =
6869+
APFloat::getSmallestNormalized(APFloat::Float8E4M3(), false);
6870+
EXPECT_EQ(0x1.p-6, PosSmallest.convertToFloat());
6871+
APFloat NegSmallest =
6872+
APFloat::getSmallestNormalized(APFloat::Float8E4M3(), true);
6873+
EXPECT_EQ(-0x1.p-6, NegSmallest.convertToFloat());
6874+
6875+
APFloat SmallestDenorm = APFloat::getSmallest(APFloat::Float8E4M3(), false);
6876+
EXPECT_TRUE(SmallestDenorm.isDenormal());
6877+
EXPECT_EQ(0x1.p-9, SmallestDenorm.convertToFloat());
6878+
6879+
APFloat PosInf = APFloat::getInf(APFloat::Float8E4M3());
6880+
EXPECT_EQ(std::numeric_limits<float>::infinity(), PosInf.convertToFloat());
6881+
APFloat NegInf = APFloat::getInf(APFloat::Float8E4M3(), true);
6882+
EXPECT_EQ(-std::numeric_limits<float>::infinity(), NegInf.convertToFloat());
6883+
APFloat QNaN = APFloat::getQNaN(APFloat::Float8E4M3());
6884+
EXPECT_TRUE(std::isnan(QNaN.convertToFloat()));
6885+
}
6886+
68496887
TEST(APFloatTest, Float8E4M3FNToFloat) {
68506888
APFloat PosZero = APFloat::getZero(APFloat::Float8E4M3FN());
68516889
APFloat PosZeroToFloat(PosZero.convertToFloat());

‎mlir/include/mlir-c/BuiltinTypes.h

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,16 @@ MLIR_CAPI_EXPORTED bool mlirTypeIsAFloat8E5M2(MlirType type);
8989
/// context.
9090
MLIR_CAPI_EXPORTED MlirType mlirFloat8E5M2TypeGet(MlirContext ctx);
9191

92+
/// Returns the typeID of an Float8E4M3 type.
93+
MLIR_CAPI_EXPORTED MlirTypeID mlirFloat8E4M3TypeGetTypeID(void);
94+
95+
/// Checks whether the given type is an f8E4M3 type.
96+
MLIR_CAPI_EXPORTED bool mlirTypeIsAFloat8E4M3(MlirType type);
97+
98+
/// Creates an f8E4M3 type in the given context. The type is owned by the
99+
/// context.
100+
MLIR_CAPI_EXPORTED MlirType mlirFloat8E4M3TypeGet(MlirContext ctx);
101+
92102
/// Returns the typeID of an Float8E4M3FN type.
93103
MLIR_CAPI_EXPORTED MlirTypeID mlirFloat8E4M3FNTypeGetTypeID(void);
94104

‎mlir/include/mlir/IR/Builders.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ class Builder {
6161

6262
// Types.
6363
FloatType getFloat8E5M2Type();
64+
FloatType getFloat8E4M3Type();
6465
FloatType getFloat8E4M3FNType();
6566
FloatType getFloat8E5M2FNUZType();
6667
FloatType getFloat8E4M3FNUZType();

‎mlir/include/mlir/IR/BuiltinTypes.h

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ class FloatType : public Type {
5656
static FloatType getF80(MLIRContext *ctx);
5757
static FloatType getF128(MLIRContext *ctx);
5858
static FloatType getFloat8E5M2(MLIRContext *ctx);
59+
static FloatType getFloat8E4M3(MLIRContext *ctx);
5960
static FloatType getFloat8E4M3FN(MLIRContext *ctx);
6061
static FloatType getFloat8E5M2FNUZ(MLIRContext *ctx);
6162
static FloatType getFloat8E4M3FNUZ(MLIRContext *ctx);
@@ -405,16 +406,20 @@ inline bool BaseMemRefType::isValidElementType(Type type) {
405406
}
406407

407408
inline bool FloatType::classof(Type type) {
408-
return llvm::isa<Float8E5M2Type, Float8E4M3FNType, Float8E5M2FNUZType,
409-
Float8E4M3FNUZType, Float8E4M3B11FNUZType, BFloat16Type,
410-
Float16Type, FloatTF32Type, Float32Type, Float64Type,
411-
Float80Type, Float128Type>(type);
409+
return llvm::isa<
410+
Float8E5M2Type, Float8E4M3Type, Float8E4M3FNType, Float8E5M2FNUZType,
411+
Float8E4M3FNUZType, Float8E4M3B11FNUZType, BFloat16Type, Float16Type,
412+
FloatTF32Type, Float32Type, Float64Type, Float80Type, Float128Type>(type);
412413
}
413414

414415
inline FloatType FloatType::getFloat8E5M2(MLIRContext *ctx) {
415416
return Float8E5M2Type::get(ctx);
416417
}
417418

419+
inline FloatType FloatType::getFloat8E4M3(MLIRContext *ctx) {
420+
return Float8E4M3Type::get(ctx);
421+
}
422+
418423
inline FloatType FloatType::getFloat8E4M3FN(MLIRContext *ctx) {
419424
return Float8E4M3FNType::get(ctx);
420425
}

‎mlir/include/mlir/IR/BuiltinTypes.td

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,25 @@ def Builtin_Float8E5M2 : Builtin_FloatType<"Float8E5M2", "f8E5M2"> {
9797
}];
9898
}
9999

100+
//===----------------------------------------------------------------------===//
101+
// Float8E4M3Type
102+
103+
def Builtin_Float8E4M3 : Builtin_FloatType<"Float8E4M3", "f8E4M3"> {
104+
let summary = "8-bit floating point with 3 bit mantissa";
105+
let description = [{
106+
An 8-bit floating point type with 1 sign bit, 4 bits exponent and 3 bits
107+
mantissa. This is not a standard type as defined by IEEE-754, but it
108+
follows similar conventions with the following characteristics:
109+
110+
* bit encoding: S1E4M3
111+
* exponent bias: 7
112+
* infinities: supported with exponent set to all 1s and mantissa 0s
113+
* NaNs: supported with exponent bits set to all 1s and mantissa of
114+
(001, 010, 011, 100, 101, 110, 111)
115+
* denormals when exponent is 0
116+
}];
117+
}
118+
100119
//===----------------------------------------------------------------------===//
101120
// Float8E4M3FNType
102121

‎mlir/include/mlir/IR/CommonTypeConstraints.td

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -331,6 +331,8 @@ def F8E4M3FN : Type<CPred<"$_self.isFloat8E4M3FN()">, "f8E4M3FN type">,
331331
BuildableType<"$_builder.getFloat8E4M3FNType()">;
332332
def F8E5M2 : Type<CPred<"$_self.isFloat8E5M2()">, "f8E5M2 type">,
333333
BuildableType<"$_builder.getFloat8E5M2Type()">;
334+
def F8E4M3 : Type<CPred<"$_self.isFloat8E4M3()">, "f8E4M3 type">,
335+
BuildableType<"$_builder.getFloat8E4M3Type()">;
334336
def F8E4M3FNUZ : Type<CPred<"$_self.isFloat8E4M3FNUZ()">, "f8E4M3FNUZ type">,
335337
BuildableType<"$_builder.getFloat8E4M3FNUZType()">;
336338
def F8E4M3B11FNUZ : Type<CPred<"$_self.isFloat8E4M3B11FNUZ()">, "f8E4M3B11FNUZ type">,

‎mlir/include/mlir/IR/Types.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@ class Type {
126126
// derived types should use isa/dyn_cast.
127127
bool isIndex() const;
128128
bool isFloat8E5M2() const;
129+
bool isFloat8E4M3() const;
129130
bool isFloat8E4M3FN() const;
130131
bool isFloat8E5M2FNUZ() const;
131132
bool isFloat8E4M3FNUZ() const;

‎mlir/lib/AsmParser/TokenKinds.def

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ TOK_KEYWORD(f32)
9595
TOK_KEYWORD(f64)
9696
TOK_KEYWORD(f80)
9797
TOK_KEYWORD(f8E5M2)
98+
TOK_KEYWORD(f8E4M3)
9899
TOK_KEYWORD(f8E4M3FN)
99100
TOK_KEYWORD(f8E5M2FNUZ)
100101
TOK_KEYWORD(f8E4M3FNUZ)

‎mlir/lib/AsmParser/TypeParser.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ OptionalParseResult Parser::parseOptionalType(Type &type) {
4141
case Token::kw_vector:
4242
case Token::inttype:
4343
case Token::kw_f8E5M2:
44+
case Token::kw_f8E4M3:
4445
case Token::kw_f8E4M3FN:
4546
case Token::kw_f8E5M2FNUZ:
4647
case Token::kw_f8E4M3FNUZ:
@@ -305,6 +306,9 @@ Type Parser::parseNonFunctionType() {
305306
case Token::kw_f8E5M2:
306307
consumeToken(Token::kw_f8E5M2);
307308
return builder.getFloat8E5M2Type();
309+
case Token::kw_f8E4M3:
310+
consumeToken(Token::kw_f8E4M3);
311+
return builder.getFloat8E4M3Type();
308312
case Token::kw_f8E4M3FN:
309313
consumeToken(Token::kw_f8E4M3FN);
310314
return builder.getFloat8E4M3FNType();

‎mlir/lib/Bindings/Python/IRTypes.cpp

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ class PyFloat8E4M3FNType
143143
}
144144
};
145145

146-
/// Floating Point Type subclass - Float8M5E2Type.
146+
/// Floating Point Type subclass - Float8E5M2Type.
147147
class PyFloat8E5M2Type : public PyConcreteType<PyFloat8E5M2Type, PyFloatType> {
148148
public:
149149
static constexpr IsAFunctionTy isaFunction = mlirTypeIsAFloat8E5M2;
@@ -163,6 +163,26 @@ class PyFloat8E5M2Type : public PyConcreteType<PyFloat8E5M2Type, PyFloatType> {
163163
}
164164
};
165165

166+
/// Floating Point Type subclass - Float8E4M3Type.
167+
class PyFloat8E4M3Type : public PyConcreteType<PyFloat8E4M3Type, PyFloatType> {
168+
public:
169+
static constexpr IsAFunctionTy isaFunction = mlirTypeIsAFloat8E4M3;
170+
static constexpr GetTypeIDFunctionTy getTypeIdFunction =
171+
mlirFloat8E4M3TypeGetTypeID;
172+
static constexpr const char *pyClassName = "Float8E4M3Type";
173+
using PyConcreteType::PyConcreteType;
174+
175+
static void bindDerived(ClassTy &c) {
176+
c.def_static(
177+
"get",
178+
[](DefaultingPyMlirContext context) {
179+
MlirType t = mlirFloat8E4M3TypeGet(context->get());
180+
return PyFloat8E4M3Type(context->getRef(), t);
181+
},
182+
py::arg("context") = py::none(), "Create a float8_e4m3 type.");
183+
}
184+
};
185+
166186
/// Floating Point Type subclass - Float8E4M3FNUZ.
167187
class PyFloat8E4M3FNUZType
168188
: public PyConcreteType<PyFloat8E4M3FNUZType, PyFloatType> {
@@ -840,6 +860,7 @@ void mlir::python::populateIRTypes(py::module &m) {
840860
PyIndexType::bind(m);
841861
PyFloat8E4M3FNType::bind(m);
842862
PyFloat8E5M2Type::bind(m);
863+
PyFloat8E4M3Type::bind(m);
843864
PyFloat8E4M3FNUZType::bind(m);
844865
PyFloat8E4M3B11FNUZType::bind(m);
845866
PyFloat8E5M2FNUZType::bind(m);

‎mlir/lib/CAPI/IR/BuiltinTypes.cpp

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,18 @@ MlirType mlirFloat8E5M2TypeGet(MlirContext ctx) {
9898
return wrap(FloatType::getFloat8E5M2(unwrap(ctx)));
9999
}
100100

101+
MlirTypeID mlirFloat8E4M3TypeGetTypeID() {
102+
return wrap(Float8E4M3Type::getTypeID());
103+
}
104+
105+
bool mlirTypeIsAFloat8E4M3(MlirType type) {
106+
return unwrap(type).isFloat8E4M3();
107+
}
108+
109+
MlirType mlirFloat8E4M3TypeGet(MlirContext ctx) {
110+
return wrap(FloatType::getFloat8E4M3(unwrap(ctx)));
111+
}
112+
101113
MlirTypeID mlirFloat8E4M3FNTypeGetTypeID() {
102114
return wrap(Float8E4M3FNType::getTypeID());
103115
}

‎mlir/lib/Conversion/LLVMCommon/TypeConverter.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -233,8 +233,9 @@ Type LLVMTypeConverter::convertIntegerType(IntegerType type) const {
233233
}
234234

235235
Type LLVMTypeConverter::convertFloatType(FloatType type) const {
236-
if (type.isFloat8E5M2() || type.isFloat8E4M3FN() || type.isFloat8E5M2FNUZ() ||
237-
type.isFloat8E4M3FNUZ() || type.isFloat8E4M3B11FNUZ())
236+
if (type.isFloat8E5M2() || type.isFloat8E4M3() || type.isFloat8E4M3FN() ||
237+
type.isFloat8E5M2FNUZ() || type.isFloat8E4M3FNUZ() ||
238+
type.isFloat8E4M3B11FNUZ())
238239
return IntegerType::get(&getContext(), type.getWidth());
239240
return type;
240241
}

‎mlir/lib/Dialect/Arith/Transforms/EmulateUnsupportedFloats.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ static std::optional<FloatType> parseFloatType(MLIRContext *ctx,
5656
Builder b(ctx);
5757
return llvm::StringSwitch<std::optional<FloatType>>(name)
5858
.Case("f8E5M2", b.getFloat8E5M2Type())
59+
.Case("f8E4M3", b.getFloat8E4M3Type())
5960
.Case("f8E4M3FN", b.getFloat8E4M3FNType())
6061
.Case("f8E5M2FNUZ", b.getFloat8E5M2FNUZType())
6162
.Case("f8E4M3FNUZ", b.getFloat8E4M3FNUZType())

0 commit comments

Comments
 (0)