Populate the llvm::GlobalVariable ELF section, with the attribute from the ObjectAttrs (#117246)

Author: Renaud-K

mlir/lib/Target/LLVMIR/Dialect/GPU/SelectObjectAttr.cpp

@@ -121,6 +121,13 @@ LogicalResult SelectObjectAttrImpl::embedBinary(
       new llvm::GlobalVariable(*module, binary->getType(), true,
                                llvm::GlobalValue::LinkageTypes::InternalLinkage,
                                binary, getBinaryIdentifier(op.getName()));
+
+  if (object.getProperties()) {
+    if (auto section = mlir::dyn_cast_or_null<mlir::StringAttr>(
+            object.getProperties().get("section"))) {
+      serializedObj->setSection(section.getValue());
+    }
+  }
   serializedObj->setLinkage(llvm::GlobalValue::LinkageTypes::InternalLinkage);
   serializedObj->setAlignment(llvm::MaybeAlign(8));
   serializedObj->setUnnamedAddr(llvm::GlobalValue::UnnamedAddr::None);

mlir/test/Target/LLVMIR/gpu.mlir

@@ -101,3 +101,11 @@ module attributes {gpu.container_module} {
     llvm.return
   }
 }
+
+// -----
+
+// Checking that ELF section is populated
+module attributes {gpu.container_module} {
+  // CHECK: @cuda_device_mod_bin_cst = internal constant [4 x i8] c"BLOB", section "__nv_rel_fatbin", align 8
+  gpu.binary @cuda_device_mod  [#gpu.object<#nvvm.target, properties = {section = "__nv_rel_fatbin"}, "BLOB">]
+}