Skip to content

Commit 85507f1

Browse files
authored
[analyzer] Ignore assignment to Ref / RefPtr in alpha.webkit.UncountedCallArgsChecker. (#80810)
1 parent 52cf071 commit 85507f1

File tree

3 files changed

+28
-0
lines changed

3 files changed

+28
-0
lines changed

clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedCallArgsChecker.cpp

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,16 @@ class UncountedCallArgsChecker
125125
// of object on LHS.
126126
if (auto *MemberOp = dyn_cast<CXXOperatorCallExpr>(CE)) {
127127
// Note: assignemnt to built-in type isn't derived from CallExpr.
128+
if (MemberOp->getOperator() ==
129+
OO_Equal) { // Ignore assignment to Ref/RefPtr.
130+
auto *callee = MemberOp->getDirectCallee();
131+
if (auto *calleeDecl = dyn_cast<CXXMethodDecl>(callee)) {
132+
if (const CXXRecordDecl *classDecl = calleeDecl->getParent()) {
133+
if (isRefCounted(classDecl))
134+
return true;
135+
}
136+
}
137+
}
128138
if (MemberOp->isAssignmentOp())
129139
return false;
130140
}
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.webkit.UncountedCallArgsChecker -verify %s
2+
// expected-no-diagnostics
3+
4+
#include "mock-types.h"
5+
6+
class Node {
7+
public:
8+
Node* nextSibling() const;
9+
10+
void ref() const;
11+
void deref() const;
12+
};
13+
14+
static void removeDetachedChildren(Node* firstChild)
15+
{
16+
for (RefPtr child = firstChild; child; child = child->nextSibling());
17+
}

clang/test/Analysis/Checkers/WebKit/mock-types.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ template <typename T> struct RefPtr {
2020
T *operator->() { return t; }
2121
T &operator*() { return *t; }
2222
RefPtr &operator=(T *) { return *this; }
23+
operator bool() { return t; }
2324
};
2425

2526
template <typename T> bool operator==(const RefPtr<T> &, const RefPtr<T> &) {

0 commit comments

Comments
 (0)