Skip to content

Commit 85df005

Browse files
committed
Add TODO message
1 parent 3114a12 commit 85df005

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

flang/lib/Lower/OpenMP/ReductionProcessor.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -339,6 +339,10 @@ mlir::omp::ReductionDeclareOp ReductionProcessor::createReductionDecl(
339339
return decl;
340340
}
341341

342+
// TODO: By-ref vs by-val reductions are currently toggled for the whole
343+
// operation (possibly effecting multiple reduction variables).
344+
// This could cause a problem with openmp target reductions because
345+
// by-ref trivial types may not be supported.
342346
bool ReductionProcessor::doReductionByRef(
343347
const llvm::SmallVectorImpl<mlir::Value> &reductionVars) {
344348
if (reductionVars.empty())

0 commit comments

Comments
 (0)