Skip to content

Commit 8aeb34d

Browse files
committed
Apply AS, remove dead assert
1 parent 3ff9c45 commit 8aeb34d

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

llvm/lib/CodeGen/RegAllocEvictionAdvisor.cpp

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,6 @@ void RegAllocEvictionAdvisorAnalysis::initializeProvider(
130130
Provider.reset(
131131
new DefaultEvictionAdvisorProvider(/*NotAsRequested=*/true, Ctx));
132132
#endif
133-
assert(Provider && "EvictionAdvisorProvider cannot be null");
134133
return;
135134
case RegAllocEvictionAdvisorAnalysisLegacy::AdvisorMode::Release:
136135
Provider.reset(createReleaseModeAdvisorProvider(Ctx));
@@ -151,20 +150,22 @@ Pass *llvm::callDefaultCtor<RegAllocEvictionAdvisorAnalysisLegacy>() {
151150
Pass *Ret = nullptr;
152151
switch (Mode) {
153152
case RegAllocEvictionAdvisorAnalysisLegacy::AdvisorMode::Default:
154-
return new DefaultEvictionAdvisorAnalysisLegacy(/*NotAsRequested*/ false);
153+
return new DefaultEvictionAdvisorAnalysisLegacy(/*NotAsRequested=*/false);
155154
case RegAllocEvictionAdvisorAnalysisLegacy::AdvisorMode::Release:
156155
Ret = createReleaseModeAdvisorAnalysisLegacy();
156+
// release mode advisor may not be supported
157+
if (!Ret)
158+
Ret = new DefaultEvictionAdvisorAnalysisLegacy(/*NotAsRequested=*/true);
157159
break;
158160
case RegAllocEvictionAdvisorAnalysisLegacy::AdvisorMode::Development:
159161
#if defined(LLVM_HAVE_TFLITE)
160162
Ret = createDevelopmentModeAdvisorAnalysisLegacy();
163+
#else
164+
Ret = new DefaultEvictionAdvisorAnalysisLegacy(/*NotAsRequested=*/true);
161165
#endif
162166
break;
163167
}
164168

165-
// release or development mode advisor may not be supported
166-
if (!Ret)
167-
Ret = new DefaultEvictionAdvisorAnalysisLegacy(/*NotAsRequested*/ true);
168169
return Ret;
169170
}
170171

0 commit comments

Comments
 (0)