Address comments

Author: vgvassilev

clang/include/clang/Interpreter/Interpreter.h

@@ -173,7 +173,7 @@ class Interpreter {
 private:
   size_t getEffectivePTUSize() const;
   void markUserCodeStart();
-  llvm::Expected<Expr *> AttachValuePrinting(Expr *E);
+  llvm::Expected<Expr *> ExtractValueFromExpr(Expr *E);
   llvm::Expected<llvm::orc::ExecutorAddr> CompileDtorCall(CXXRecordDecl *CXXRD);
 
   CodeGenerator *getCodeGen() const;

clang/lib/Interpreter/Interpreter.cpp

@@ -253,14 +253,12 @@ class InProcessPrintingASTConsumer final : public MultiplexConsumer {
   bool HandleTopLevelDecl(DeclGroupRef DGR) override final {
     if (DGR.isNull())
       return true;
-    // if (!Consumer)
-    //   return true;
 
     for (Decl *D : DGR)
       if (auto *TLSD = llvm::dyn_cast<TopLevelStmtDecl>(D))
         if (TLSD && TLSD->isSemiMissing()) {
           auto ExprOrErr =
-              Interp.AttachValuePrinting(cast<Expr>(TLSD->getStmt()));
+              Interp.ExtractValueFromExpr(cast<Expr>(TLSD->getStmt()));
           if (llvm::Error E = ExprOrErr.takeError()) {
             llvm::logAllUnhandledErrors(std::move(E), llvm::errs(),
                                         "Value printing failed: ");

clang/lib/Interpreter/InterpreterValuePrinter.cpp

@@ -156,7 +156,7 @@ class InterfaceKindVisitor
 //   // 3. If x is a struct, but a rvalue.
 //   new (__clang_Interpreter_SetValueWithAlloc(ThisInterp, OpaqueValue,
 //   xQualType)) (x);
-llvm::Expected<Expr *> Interpreter::AttachValuePrinting(Expr *E) {
+llvm::Expected<Expr *> Interpreter::ExtractValueFromExpr(Expr *E) {
   Sema &S = getCompilerInstance()->getSema();
   ASTContext &Ctx = S.getASTContext();