remove hlsl error to go with a more generic one

Author: farzonl

clang/include/clang/Basic/DiagnosticSemaKinds.td

@@ -12118,9 +12118,6 @@ def err_hlsl_param_qualifier_mismatch :
 def warn_hlsl_impcast_vector_truncation : Warning<
   "implicit conversion truncates vector: %0 to %1">, InGroup<Conversion>;
 
-def warn_hlsl_impcast_bitwidth_reduction : Warning<
-  "implicit conversion from larger type: %0 to smaller type %1, possible loss of data">, InGroup<Conversion>;
-
 // Layout randomization diagnostics.
 def err_non_designated_init_used : Error<
   "a randomized struct can only be initialized with a designated initializer">;

clang/lib/Sema/SemaChecking.cpp

@@ -5235,14 +5235,10 @@ void CheckVectorFloatPromotion(Sema *S, ExprResult &source, QualType targetTy,
   if (!vecElemT->isFloatingType() && targetTy->isFloatingType()) {
     QualType floatVecTy = S->Context.getVectorType(
         S->Context.FloatTy, vecTyTarget->getNumElements(), VectorKind::Generic);
-    int floatByteSize =
-        S->Context.getTypeSizeInChars(S->Context.FloatTy).getQuantity();
-    int vecElemByteSize = S->Context.getTypeSizeInChars(vecElemT).getQuantity();
-    if (vecElemByteSize > floatByteSize)
-      S->Diag(BuiltinLoc, diag::warn_hlsl_impcast_bitwidth_reduction)
-          << source.get()->getType() << floatVecTy
-          << source.get()->getSourceRange() << targetSrcRange;
 
+    S->Diag(BuiltinLoc, diag::warn_impcast_integer_float_precision)
+        << source.get()->getType() << floatVecTy
+        << source.get()->getSourceRange() << targetSrcRange;
     source = S->SemaConvertVectorExpr(
         source.get(), S->Context.CreateTypeSourceInfo(floatVecTy), BuiltinLoc,
         source.get()->getBeginLoc());

clang/test/SemaHLSL/BuiltIns/dot-errors.hlsl

@@ -1,6 +1,6 @@
 // RUN: %clang_cc1 -std=hlsl2021 -finclude-default-header -x hlsl -triple \
-// RUN:   dxil-pc-shadermodel6.3-library %s -fnative-half-type \
-// RUN:   -emit-llvm -disable-llvm-passes -verify -verify-ignore-unexpected
+// RUN:   dxil-pc-shadermodel6.3-library %s -fnative-half-type -emit-llvm \
+// RUN:   -disable-llvm-passes -verify -verify-ignore-unexpected
 
 float test_no_second_arg ( float2 p0) {
   return __builtin_hlsl_dot ( p0 );
@@ -28,11 +28,6 @@ float test_dot_builtin_vector_size_mismatch ( float3 p0, float2 p1 ) {
   // expected-warning@-1 {{implicit conversion truncates vector: 'float3' (aka 'vector<float, 3>') to 'float2' (aka 'vector<float, 2>')}}
 }
 
-float test_dot_builtin_vector_elem_size_reduction ( int64_t2 p0, float p1 ) {
-  return __builtin_hlsl_dot ( p0, p1 );
-  // expected-warning@-1 {{conversion from larger type: 'int64_t2' (aka 'vector<int64_t, 2>') to smaller type '__attribute__((__vector_size__(2 * sizeof(float)))) float' (vector of 2 'float' values), possible loss of data}}
-}
-
 float test_dot_scalar_mismatch ( float p0, int p1 ) {
   return dot ( p0, p1 );
   // expected-error@-1 {{call to 'dot' is ambiguous}}

clang/test/SemaHLSL/BuiltIns/dot-warning.hlsl

@@ -0,0 +1,14 @@
+// RUN: %clang_cc1 -std=hlsl2021 -finclude-default-header -x hlsl -triple \
+// RUN:   dxil-pc-shadermodel6.3-library %s -fnative-half-type -emit-llvm \
+// RUN:   -disable-llvm-passes -Wimplicit-int-float-conversion-verify -verify-ignore-unexpected
+
+
+float test_dot_builtin_vector_elem_size_reduction ( int64_t2 p0, float p1 ) {
+  return __builtin_hlsl_dot ( p0, p1 );
+  // expected-Warning@-1 {{implicit conversion from 'int64_t2' (aka 'vector<int64_t, 2>') to '__attribute__((__vector_size__(2 * sizeof(float)))) float' (vector of 2 'float' values) may lose precision}}
+}
+
+float test_dot_builtin_int_vector_elem_size_reduction ( int2 p0, float p1 ) {
+  return __builtin_hlsl_dot ( p0, p1 );
+  // expected-Warning@-1 {{implicit conversion from 'int2' (aka 'vector<int, 2>') to '__attribute__((__vector_size__(2 * sizeof(float)))) float' (vector of 2 'float' values) may lose precision}}
+}