Skip to content

Commit 8d8fff0

Browse files
authored
[Object][COFF][NFC] Don't use inline function for COFFImportFile::printSymbolName. (#87195)
Fixes BUILD_SHARED_LIBS builds after #87191 made helpers non-inline.
1 parent 154cea4 commit 8d8fff0

File tree

2 files changed

+22
-20
lines changed

2 files changed

+22
-20
lines changed

llvm/include/llvm/Object/COFFImportFile.h

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -45,26 +45,7 @@ class COFFImportFile : public SymbolicFile {
4545

4646
void moveSymbolNext(DataRefImpl &Symb) const override { ++Symb.p; }
4747

48-
Error printSymbolName(raw_ostream &OS, DataRefImpl Symb) const override {
49-
switch (Symb.p) {
50-
case ImpSymbol:
51-
OS << "__imp_";
52-
break;
53-
case ECAuxSymbol:
54-
OS << "__imp_aux_";
55-
break;
56-
}
57-
const char *Name = Data.getBufferStart() + sizeof(coff_import_header);
58-
if (Symb.p != ECThunkSymbol && COFF::isArm64EC(getMachine())) {
59-
if (std::optional<std::string> DemangledName =
60-
getArm64ECDemangledFunctionName(Name)) {
61-
OS << StringRef(*DemangledName);
62-
return Error::success();
63-
}
64-
}
65-
OS << StringRef(Name);
66-
return Error::success();
67-
}
48+
Error printSymbolName(raw_ostream &OS, DataRefImpl Symb) const override;
6849

6950
Expected<uint32_t> getSymbolFlags(DataRefImpl Symb) const override {
7051
return SymbolRef::SF_Global;

llvm/lib/Object/COFFImportFile.cpp

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,27 @@ StringRef COFFImportFile::getExportName() const {
8484
return name;
8585
}
8686

87+
Error COFFImportFile::printSymbolName(raw_ostream &OS, DataRefImpl Symb) const {
88+
switch (Symb.p) {
89+
case ImpSymbol:
90+
OS << "__imp_";
91+
break;
92+
case ECAuxSymbol:
93+
OS << "__imp_aux_";
94+
break;
95+
}
96+
const char *Name = Data.getBufferStart() + sizeof(coff_import_header);
97+
if (Symb.p != ECThunkSymbol && COFF::isArm64EC(getMachine())) {
98+
if (std::optional<std::string> DemangledName =
99+
getArm64ECDemangledFunctionName(Name)) {
100+
OS << StringRef(*DemangledName);
101+
return Error::success();
102+
}
103+
}
104+
OS << StringRef(Name);
105+
return Error::success();
106+
}
107+
87108
static uint16_t getImgRelRelocation(MachineTypes Machine) {
88109
switch (Machine) {
89110
default:

0 commit comments

Comments
 (0)