fixup! rename API; move notifyInsertion to after new data was written

Author: Michael137

libcxxabi/src/demangle/Utility.h

@@ -96,8 +96,8 @@ class OutputBuffer {
   /// Called when we write to this object anywhere other than the end.
   virtual void notifyInsertion(size_t /*Position*/, size_t /*Count*/) {}
 
-  /// Called when we reset the \c CurrentPosition of this object.
-  virtual void notifyPositionChanged(size_t /*OldPos*/, size_t /*NewPos*/) {}
+  /// Called when we make the \c CurrentPosition of this object smaller.
+  virtual void notifyDeletion(size_t /*OldPos*/, size_t /*NewPos*/) {}
 
   /// If a ParameterPackExpansion (or similar type) is encountered, the offset
   /// into the pack that we're currently printing.
@@ -137,13 +137,13 @@ class OutputBuffer {
   OutputBuffer &prepend(std::string_view R) {
     size_t Size = R.size();
 
-    notifyInsertion(/*Position=*/0, /*Count=*/Size);
-
     grow(Size);
     std::memmove(Buffer + Size, Buffer, CurrentPosition);
     std::memcpy(Buffer, &*R.begin(), Size);
     CurrentPosition += Size;
 
+    notifyInsertion(/*Position=*/0, /*Count=*/Size);
+
     return *this;
   }
 
@@ -180,17 +180,17 @@ class OutputBuffer {
     if (N == 0)
       return;
 
-    notifyInsertion(Pos, N);
-
     grow(N);
     std::memmove(Buffer + Pos + N, Buffer + Pos, CurrentPosition - Pos);
     std::memcpy(Buffer + Pos, S, N);
     CurrentPosition += N;
+
+    notifyInsertion(Pos, N);
   }
 
   size_t getCurrentPosition() const { return CurrentPosition; }
   void setCurrentPosition(size_t NewPos) {
-    notifyPositionChanged(CurrentPosition, NewPos);
+    notifyDeletion(CurrentPosition, NewPos);
     CurrentPosition = NewPos;
   }
 

llvm/include/llvm/Demangle/Utility.h

@@ -96,8 +96,8 @@ class OutputBuffer {
   /// Called when we write to this object anywhere other than the end.
   virtual void notifyInsertion(size_t /*Position*/, size_t /*Count*/) {}
 
-  /// Called when we reset the \c CurrentPosition of this object.
-  virtual void notifyPositionChanged(size_t /*OldPos*/, size_t /*NewPos*/) {}
+  /// Called when we make the \c CurrentPosition of this object smaller.
+  virtual void notifyDeletion(size_t /*OldPos*/, size_t /*NewPos*/) {}
 
   /// If a ParameterPackExpansion (or similar type) is encountered, the offset
   /// into the pack that we're currently printing.
@@ -137,13 +137,13 @@ class OutputBuffer {
   OutputBuffer &prepend(std::string_view R) {
     size_t Size = R.size();
 
-    notifyInsertion(/*Position=*/0, /*Count=*/Size);
-
     grow(Size);
     std::memmove(Buffer + Size, Buffer, CurrentPosition);
     std::memcpy(Buffer, &*R.begin(), Size);
     CurrentPosition += Size;
 
+    notifyInsertion(/*Position=*/0, /*Count=*/Size);
+
     return *this;
   }
 
@@ -180,17 +180,17 @@ class OutputBuffer {
     if (N == 0)
       return;
 
-    notifyInsertion(Pos, N);
-
     grow(N);
     std::memmove(Buffer + Pos + N, Buffer + Pos, CurrentPosition - Pos);
     std::memcpy(Buffer + Pos, S, N);
     CurrentPosition += N;
+
+    notifyInsertion(Pos, N);
   }
 
   size_t getCurrentPosition() const { return CurrentPosition; }
   void setCurrentPosition(size_t NewPos) {
-    notifyPositionChanged(CurrentPosition, NewPos);
+    notifyDeletion(CurrentPosition, NewPos);
     CurrentPosition = NewPos;
   }
 

llvm/unittests/Demangle/OutputBufferTest.cpp

@@ -99,7 +99,7 @@ TEST(OutputBufferTest, Notifications) {
     size_t Inserted = 0;
     size_t LatestPos = 0;
 
-    void notifyPositionChanged(size_t OldPos, size_t NewPos) override {
+    void notifyDeletion(size_t OldPos, size_t NewPos) override {
       LatestPos = NewPos;
     }