Skip to content

Commit 98c0e55

Browse files
authored
Revert "SelectionDAG: Avoid using MachineFunction::getMMI" (#99777)
Reverts #99696 https://lab.llvm.org/buildbot/#/builders/164/builds/1262
1 parent 1492e5f commit 98c0e55

8 files changed

+16
-27
lines changed

llvm/include/llvm/CodeGen/SelectionDAG.h

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,6 @@ class SelectionDAG {
245245

246246
ProfileSummaryInfo *PSI = nullptr;
247247
BlockFrequencyInfo *BFI = nullptr;
248-
MachineModuleInfo *MMI = nullptr;
249248

250249
/// List of non-single value types.
251250
FoldingSet<SDVTListNode> VTListMap;
@@ -460,15 +459,14 @@ class SelectionDAG {
460459
void init(MachineFunction &NewMF, OptimizationRemarkEmitter &NewORE,
461460
Pass *PassPtr, const TargetLibraryInfo *LibraryInfo,
462461
UniformityInfo *UA, ProfileSummaryInfo *PSIin,
463-
BlockFrequencyInfo *BFIin, MachineModuleInfo &MMI,
464-
FunctionVarLocs const *FnVarLocs);
462+
BlockFrequencyInfo *BFIin, FunctionVarLocs const *FnVarLocs);
465463

466464
void init(MachineFunction &NewMF, OptimizationRemarkEmitter &NewORE,
467465
MachineFunctionAnalysisManager &AM,
468466
const TargetLibraryInfo *LibraryInfo, UniformityInfo *UA,
469467
ProfileSummaryInfo *PSIin, BlockFrequencyInfo *BFIin,
470-
MachineModuleInfo &MMI, FunctionVarLocs const *FnVarLocs) {
471-
init(NewMF, NewORE, nullptr, LibraryInfo, UA, PSIin, BFIin, MMI, FnVarLocs);
468+
FunctionVarLocs const *FnVarLocs) {
469+
init(NewMF, NewORE, nullptr, LibraryInfo, UA, PSIin, BFIin, FnVarLocs);
472470
MFAM = &AM;
473471
}
474472

@@ -502,7 +500,6 @@ class SelectionDAG {
502500
OptimizationRemarkEmitter &getORE() const { return *ORE; }
503501
ProfileSummaryInfo *getPSI() const { return PSI; }
504502
BlockFrequencyInfo *getBFI() const { return BFI; }
505-
MachineModuleInfo *getMMI() const { return MMI; }
506503

507504
FlagInserter *getFlagInserter() { return Inserter; }
508505
void setFlagInserter(FlagInserter *FI) { Inserter = FI; }

llvm/include/llvm/CodeGen/SelectionDAGISel.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ class SelectionDAGISel {
4848
std::unique_ptr<FunctionLoweringInfo> FuncInfo;
4949
SwiftErrorValueTracking *SwiftError;
5050
MachineFunction *MF;
51-
MachineModuleInfo *MMI;
5251
MachineRegisterInfo *RegInfo;
5352
SelectionDAG *CurDAG;
5453
std::unique_ptr<SelectionDAGBuilder> SDB;

llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1333,7 +1333,7 @@ void SelectionDAG::init(MachineFunction &NewMF,
13331333
OptimizationRemarkEmitter &NewORE, Pass *PassPtr,
13341334
const TargetLibraryInfo *LibraryInfo,
13351335
UniformityInfo *NewUA, ProfileSummaryInfo *PSIin,
1336-
BlockFrequencyInfo *BFIin, MachineModuleInfo &MMIin,
1336+
BlockFrequencyInfo *BFIin,
13371337
FunctionVarLocs const *VarLocs) {
13381338
MF = &NewMF;
13391339
SDAGISelPass = PassPtr;
@@ -1345,7 +1345,6 @@ void SelectionDAG::init(MachineFunction &NewMF,
13451345
UA = NewUA;
13461346
PSI = PSIin;
13471347
BFI = BFIin;
1348-
MMI = &MMIin;
13491348
FnVarLocs = VarLocs;
13501349
}
13511350

llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6707,11 +6707,11 @@ void SelectionDAGBuilder::visitIntrinsicCall(const CallInst &I,
67076707
getValue(I.getArgOperand(0))));
67086708
return;
67096709
case Intrinsic::eh_sjlj_callsite: {
6710+
MachineModuleInfo &MMI = DAG.getMachineFunction().getMMI();
67106711
ConstantInt *CI = cast<ConstantInt>(I.getArgOperand(0));
6711-
assert(DAG.getMMI()->getCurrentCallSite() == 0 &&
6712-
"Overlapping call sites!");
6712+
assert(MMI.getCurrentCallSite() == 0 && "Overlapping call sites!");
67136713

6714-
DAG.getMMI()->setCurrentCallSite(CI->getZExtValue());
6714+
MMI.setCurrentCallSite(CI->getZExtValue());
67156715
return;
67166716
}
67176717
case Intrinsic::eh_sjlj_functioncontext: {

llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -509,7 +509,7 @@ void SelectionDAGISel::initializeAnalysisResults(
509509
FnVarLocs = &FAM.getResult<DebugAssignmentTrackingAnalysis>(Fn);
510510

511511
auto *UA = FAM.getCachedResult<UniformityInfoAnalysis>(Fn);
512-
CurDAG->init(*MF, *ORE, MFAM, LibInfo, UA, PSI, BFI, *MMI, FnVarLocs);
512+
CurDAG->init(*MF, *ORE, MFAM, LibInfo, UA, PSI, BFI, FnVarLocs);
513513

514514
// Now get the optional analyzes if we want to.
515515
// This is based on the possibly changed OptLevel (after optnone is taken
@@ -562,11 +562,7 @@ void SelectionDAGISel::initializeAnalysisResults(MachineFunctionPass &MFP) {
562562
UniformityInfo *UA = nullptr;
563563
if (auto *UAPass = MFP.getAnalysisIfAvailable<UniformityInfoWrapperPass>())
564564
UA = &UAPass->getUniformityInfo();
565-
566-
MachineModuleInfo &MMI =
567-
MFP.getAnalysis<MachineModuleInfoWrapperPass>().getMMI();
568-
569-
CurDAG->init(*MF, *ORE, &MFP, LibInfo, UA, PSI, BFI, MMI, FnVarLocs);
565+
CurDAG->init(*MF, *ORE, &MFP, LibInfo, UA, PSI, BFI, FnVarLocs);
570566

571567
// Now get the optional analyzes if we want to.
572568
// This is based on the possibly changed OptLevel (after optnone is taken
@@ -800,7 +796,7 @@ bool SelectionDAGISel::runOnMachineFunction(MachineFunction &mf) {
800796
}
801797

802798
// Determine if floating point is used for msvc
803-
computeUsesMSVCFloatingPoint(TM.getTargetTriple(), Fn, *CurDAG->getMMI());
799+
computeUsesMSVCFloatingPoint(TM.getTargetTriple(), Fn, MF->getMMI());
804800

805801
// Release function-specific state. SDB and CurDAG are already cleared
806802
// at this point.
@@ -1447,6 +1443,7 @@ bool SelectionDAGISel::PrepareEHLandingPad() {
14471443

14481444
// Mark and Report IPToState for each Block under IsEHa
14491445
void SelectionDAGISel::reportIPToStateForBlocks(MachineFunction *MF) {
1446+
MachineModuleInfo &MMI = MF->getMMI();
14501447
llvm::WinEHFuncInfo *EHInfo = MF->getWinEHFuncInfo();
14511448
if (!EHInfo)
14521449
return;
@@ -1461,8 +1458,8 @@ void SelectionDAGISel::reportIPToStateForBlocks(MachineFunction *MF) {
14611458
continue;
14621459

14631460
// Insert EH Labels
1464-
MCSymbol *BeginLabel = MF->getContext().createTempSymbol();
1465-
MCSymbol *EndLabel = MF->getContext().createTempSymbol();
1461+
MCSymbol *BeginLabel = MMI.getContext().createTempSymbol();
1462+
MCSymbol *EndLabel = MMI.getContext().createTempSymbol();
14661463
EHInfo->addIPToStateRange(State, BeginLabel, EndLabel);
14671464
BuildMI(MBB, MBBb, SDB->getCurDebugLoc(),
14681465
TII->get(TargetOpcode::EH_LABEL))

llvm/unittests/CodeGen/AArch64SelectionDAGTest.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,7 @@ class AArch64SelectionDAGTest : public testing::Test {
6868
if (!DAG)
6969
report_fatal_error("DAG?");
7070
OptimizationRemarkEmitter ORE(F);
71-
DAG->init(*MF, ORE, nullptr, nullptr, nullptr, nullptr, nullptr, MMI,
72-
nullptr);
71+
DAG->init(*MF, ORE, nullptr, nullptr, nullptr, nullptr, nullptr, nullptr);
7372
}
7473

7574
TargetLoweringBase::LegalizeTypeAction getTypeAction(EVT VT) {

llvm/unittests/CodeGen/SelectionDAGAddressAnalysisTest.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,7 @@ class SelectionDAGAddressAnalysisTest : public testing::Test {
7878
if (!DAG)
7979
report_fatal_error("DAG?");
8080
OptimizationRemarkEmitter ORE(F);
81-
DAG->init(*MF, ORE, nullptr, nullptr, nullptr, nullptr, nullptr, MMI,
82-
nullptr);
81+
DAG->init(*MF, ORE, nullptr, nullptr, nullptr, nullptr, nullptr, nullptr);
8382
}
8483

8584
TargetLoweringBase::LegalizeTypeAction getTypeAction(EVT VT) {

llvm/unittests/CodeGen/SelectionDAGPatternMatchTest.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,7 @@ class SelectionDAGPatternMatchTest : public testing::Test {
7777
if (!DAG)
7878
report_fatal_error("DAG?");
7979
OptimizationRemarkEmitter ORE(F);
80-
DAG->init(*MF, ORE, nullptr, nullptr, nullptr, nullptr, nullptr, MMI,
81-
nullptr);
80+
DAG->init(*MF, ORE, nullptr, nullptr, nullptr, nullptr, nullptr, nullptr);
8281
}
8382

8483
TargetLoweringBase::LegalizeTypeAction getTypeAction(EVT VT) {

0 commit comments

Comments
 (0)