fix prefix regex validation

klensy · klensy · commit 9b0152275585 · 2024-05-15T13:52:26.000+03:00
"prefix must start with a letter and contain only alphanumeric characters, hyphens, and underscores"
but current regex didn't enforced that rule, fix this.
diff --git a/llvm/lib/FileCheck/FileCheck.cpp b/llvm/lib/FileCheck/FileCheck.cpp
@@ -2474,7 +2474,7 @@ static bool ValidatePrefixes(StringRef Kind, StringSet<> &UniquePrefixes,
              << "string\n";
       return false;
     }
-    static const Regex Validator("^[a-zA-Z0-9_-]*$");
+    static const Regex Validator("^[a-zA-Z][a-zA-Z0-9_-]*$");
     if (!Validator.match(Prefix)) {
       errs() << "error: supplied " << Kind << " prefix must start with a "
              << "letter and contain only alphanumeric characters, hyphens, and "

Original file line number	Diff line number	Diff line change
`@@ -2474,7 +2474,7 @@ static bool ValidatePrefixes(StringRef Kind, StringSet<> &UniquePrefixes,`
`2474`	`2474`	`<< "string\n";`
`2475`	`2475`	`return false;`
`2476`	`2476`	`}`
`2477`		`- static const Regex Validator("^[a-zA-Z0-9_-]*$");`
	`2477`	`+ static const Regex Validator("^[a-zA-Z][a-zA-Z0-9_-]*$");`
`2478`	`2478`	`if (!Validator.match(Prefix)) {`
`2479`	`2479`	`errs() << "error: supplied " << Kind << " prefix must start with a "`
`2480`	`2480`	`<< "letter and contain only alphanumeric characters, hyphens, and "`