Remove ThreadMinidump calculate stop info which was causing a hang in test, reset them to main. Run git clang format and run tests.

Author: Jlalond

lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp

@@ -395,21 +395,17 @@ bool ProcessMinidump::DoUpdateThreadList(ThreadList &old_thread_list,
   for (const minidump::Thread &thread : m_thread_list) {
     LocationDescriptor context_location = thread.Context;
 
-    std::optional<minidump::Exception> exception;
     // If the minidump contains an exception context, use it
-    if (m_exceptions_by_tid.count(thread.ThreadId) > 0) {
+    if (m_exceptions_by_tid.count(thread.ThreadId) > 0)
       context_location = m_exceptions_by_tid[thread.ThreadId].ThreadContext;
-      exception = m_exceptions_by_tid[thread.ThreadId].ExceptionRecord;
-    }
 
     llvm::ArrayRef<uint8_t> context;
     if (!m_is_wow64)
       context = m_minidump_parser->GetThreadContext(context_location);
     else
       context = m_minidump_parser->GetThreadContextWow64(thread);
 
-    lldb::ThreadSP thread_sp(
-        new ThreadMinidump(*this, thread, context, exception));
+    lldb::ThreadSP thread_sp(new ThreadMinidump(*this, thread, context));
     new_thread_list.AddThread(thread_sp);
   }
   return new_thread_list.GetSize(false) > 0;

lldb/source/Plugins/Process/minidump/ThreadMinidump.cpp

@@ -34,10 +34,9 @@ using namespace lldb_private;
 using namespace minidump;
 
 ThreadMinidump::ThreadMinidump(Process &process, const minidump::Thread &td,
-                               llvm::ArrayRef<uint8_t> gpregset_data,
-                               std::optional<minidump::Exception> exception)
+                               llvm::ArrayRef<uint8_t> gpregset_data)
     : Thread(process, td.ThreadId), m_thread_reg_ctx_sp(),
-      m_gpregset_data(gpregset_data), m_exception(exception) {}
+      m_gpregset_data(gpregset_data) {}
 
 ThreadMinidump::~ThreadMinidump() = default;
 
@@ -116,15 +115,4 @@ ThreadMinidump::CreateRegisterContextForFrame(StackFrame *frame) {
   return reg_ctx_sp;
 }
 
-// This method doesn't end up getting called for minidump
-// because the stopinfo is set in `ProcessMinidump::RefreshStateAfterStop`
-bool ThreadMinidump::CalculateStopInfo() {
-  if (!m_exception)
-    return false;
-
-  minidump::Exception thread_exception = m_exception.value();
-  SetStopInfo(StopInfo::CreateStopReasonWithSignal(
-      *this, thread_exception.ExceptionCode, /*description=*/nullptr,
-      thread_exception.ExceptionCode));
-  return true;
-}
+bool ThreadMinidump::CalculateStopInfo() { return false; }

lldb/source/Plugins/Process/minidump/ThreadMinidump.h

@@ -21,8 +21,7 @@ namespace minidump {
 class ThreadMinidump : public Thread {
 public:
   ThreadMinidump(Process &process, const minidump::Thread &td,
-                 llvm::ArrayRef<uint8_t> gpregset_data,
-                 std::optional<minidump::Exception> exception);
+                 llvm::ArrayRef<uint8_t> gpregset_data);
 
   ~ThreadMinidump() override;
 
@@ -36,7 +35,6 @@ class ThreadMinidump : public Thread {
 protected:
   lldb::RegisterContextSP m_thread_reg_ctx_sp;
   llvm::ArrayRef<uint8_t> m_gpregset_data;
-  std::optional<minidump::Exception> m_exception;
 
   bool CalculateStopInfo() override;
 };