Skip to content

Commit a16f646

Browse files
committed
[TTI] improveShuffleKindFromMask - detect SK_ExtractSubvector patterns from SK_PermuteSingleSrc
1 parent 94795a3 commit a16f646

File tree

3 files changed

+13
-18
lines changed

3 files changed

+13
-18
lines changed

llvm/include/llvm/CodeGen/BasicTTIImpl.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -944,6 +944,11 @@ class BasicTTIImplBase : public TargetTransformInfoImplCRTPBase<T> {
944944
return TTI::SK_Reverse;
945945
if (ShuffleVectorInst::isZeroEltSplatMask(Mask, NumSrcElts))
946946
return TTI::SK_Broadcast;
947+
if (ShuffleVectorInst::isExtractSubvectorMask(Mask, NumSrcElts, Index) &&
948+
(Index + Mask.size()) <= NumSrcElts) {
949+
SubTy = FixedVectorType::get(Ty->getElementType(), Mask.size());
950+
return TTI::SK_ExtractSubvector;
951+
}
947952
break;
948953
case TTI::SK_PermuteTwoSrc: {
949954
int NumSubElts;

llvm/test/Transforms/VectorCombine/X86/shuffle-inseltpoison.ll

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -68,15 +68,10 @@ define <16 x i16> @bitcast_shuf_narrow_element_concat_subvectors(<2 x i64> %v) {
6868
}
6969

7070
define <16 x i8> @bitcast_shuf_extract_subvector(<8 x i32> %v) {
71-
; SSE-LABEL: @bitcast_shuf_extract_subvector(
72-
; SSE-NEXT: [[TMP1:%.*]] = bitcast <8 x i32> [[V:%.*]] to <32 x i8>
73-
; SSE-NEXT: [[R:%.*]] = shufflevector <32 x i8> [[TMP1]], <32 x i8> poison, <16 x i32> <i32 16, i32 17, i32 18, i32 19, i32 20, i32 21, i32 22, i32 23, i32 24, i32 25, i32 26, i32 27, i32 28, i32 29, i32 30, i32 31>
74-
; SSE-NEXT: ret <16 x i8> [[R]]
75-
;
76-
; AVX-LABEL: @bitcast_shuf_extract_subvector(
77-
; AVX-NEXT: [[SHUF:%.*]] = shufflevector <8 x i32> [[V:%.*]], <8 x i32> poison, <4 x i32> <i32 4, i32 5, i32 6, i32 7>
78-
; AVX-NEXT: [[R:%.*]] = bitcast <4 x i32> [[SHUF]] to <16 x i8>
79-
; AVX-NEXT: ret <16 x i8> [[R]]
71+
; CHECK-LABEL: @bitcast_shuf_extract_subvector(
72+
; CHECK-NEXT: [[TMP1:%.*]] = bitcast <8 x i32> [[V:%.*]] to <32 x i8>
73+
; CHECK-NEXT: [[R:%.*]] = shufflevector <32 x i8> [[TMP1]], <32 x i8> poison, <16 x i32> <i32 16, i32 17, i32 18, i32 19, i32 20, i32 21, i32 22, i32 23, i32 24, i32 25, i32 26, i32 27, i32 28, i32 29, i32 30, i32 31>
74+
; CHECK-NEXT: ret <16 x i8> [[R]]
8075
;
8176
%shuf = shufflevector <8 x i32> %v, <8 x i32> poison, <4 x i32> <i32 4, i32 5, i32 6, i32 7>
8277
%r = bitcast <4 x i32> %shuf to <16 x i8>

llvm/test/Transforms/VectorCombine/X86/shuffle.ll

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -68,15 +68,10 @@ define <16 x i16> @bitcast_shuf_narrow_element_concat_subvectors(<2 x i64> %v) {
6868
}
6969

7070
define <16 x i8> @bitcast_shuf_extract_subvector(<8 x i32> %v) {
71-
; SSE-LABEL: @bitcast_shuf_extract_subvector(
72-
; SSE-NEXT: [[TMP1:%.*]] = bitcast <8 x i32> [[V:%.*]] to <32 x i8>
73-
; SSE-NEXT: [[R:%.*]] = shufflevector <32 x i8> [[TMP1]], <32 x i8> poison, <16 x i32> <i32 16, i32 17, i32 18, i32 19, i32 20, i32 21, i32 22, i32 23, i32 24, i32 25, i32 26, i32 27, i32 28, i32 29, i32 30, i32 31>
74-
; SSE-NEXT: ret <16 x i8> [[R]]
75-
;
76-
; AVX-LABEL: @bitcast_shuf_extract_subvector(
77-
; AVX-NEXT: [[SHUF:%.*]] = shufflevector <8 x i32> [[V:%.*]], <8 x i32> poison, <4 x i32> <i32 4, i32 5, i32 6, i32 7>
78-
; AVX-NEXT: [[R:%.*]] = bitcast <4 x i32> [[SHUF]] to <16 x i8>
79-
; AVX-NEXT: ret <16 x i8> [[R]]
71+
; CHECK-LABEL: @bitcast_shuf_extract_subvector(
72+
; CHECK-NEXT: [[TMP1:%.*]] = bitcast <8 x i32> [[V:%.*]] to <32 x i8>
73+
; CHECK-NEXT: [[R:%.*]] = shufflevector <32 x i8> [[TMP1]], <32 x i8> poison, <16 x i32> <i32 16, i32 17, i32 18, i32 19, i32 20, i32 21, i32 22, i32 23, i32 24, i32 25, i32 26, i32 27, i32 28, i32 29, i32 30, i32 31>
74+
; CHECK-NEXT: ret <16 x i8> [[R]]
8075
;
8176
%shuf = shufflevector <8 x i32> %v, <8 x i32> poison, <4 x i32> <i32 4, i32 5, i32 6, i32 7>
8277
%r = bitcast <4 x i32> %shuf to <16 x i8>

0 commit comments

Comments
 (0)