Skip to content

Commit a902015

Browse files
committed
[lldb] Fix grammar in error message emitted by IRExecutionUnit
The error message "Couldn't lookup symbols" emitted from IRExecutionUnit is grammatically incorrect. "Lookup" is noun when spelled without a space. Update the error message to use the verb "look up" instead.
1 parent 6be47fb commit a902015

File tree

7 files changed

+13
-12
lines changed

7 files changed

+13
-12
lines changed

cross-project-tests/debuginfo-tests/dexter/dex/debugger/lldb/LLDB.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -288,6 +288,7 @@ def evaluate_expression(self, expression, frame_idx=0) -> ValueIR:
288288
"use of undeclared identifier",
289289
"no member named",
290290
"Couldn't lookup symbols",
291+
"Couldn't look up symbols",
291292
"reference to local variable",
292293
"invalid use of 'this' outside of a non-static member function",
293294
]

lldb/source/Expression/IRExecutionUnit.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -419,7 +419,7 @@ void IRExecutionUnit::GetRunnableInfo(Status &error, lldb::addr_t &func_addr,
419419
if (m_failed_lookups.size()) {
420420
StreamString ss;
421421

422-
ss.PutCString("Couldn't lookup symbols:\n");
422+
ss.PutCString("Couldn't look up symbols:\n");
423423

424424
bool emitNewLine = false;
425425

lldb/test/API/commands/expression/import-std-module/empty-module/TestEmptyStdModule.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,5 +38,5 @@ def test(self):
3838
# Try to access our mock std::vector. This should fail but not crash LLDB as the
3939
# std::vector template should be missing from the std module.
4040
self.expect(
41-
"expr (size_t)v.size()", substrs=["Couldn't lookup symbols"], error=True
41+
"expr (size_t)v.size()", substrs=["Couldn't look up symbols"], error=True
4242
)

lldb/test/API/lang/cpp/const_static_integral_member/TestConstStaticIntegralMember.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ def test(self):
9090
self.expect(
9191
"expr const int *i = &A::int_val; *i",
9292
error=True,
93-
substrs=["Couldn't lookup symbols:"],
93+
substrs=["Couldn't look up symbols:"],
9494
)
9595

9696
# This should work on all platforms.

lldb/test/API/lang/cpp/const_static_integral_member_int128/TestConstStaticIntegralMemberInt128.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,14 @@ def test_int128(self):
2323
# for them and just treats them as normal variables (which will lead
2424
# to linker errors as they are not defined anywhere).
2525
self.expect(
26-
"expr A::int128_max", error=True, substrs=["Couldn't lookup symbols:"]
26+
"expr A::int128_max", error=True, substrs=["Couldn't look up symbols:"]
2727
)
2828
self.expect(
29-
"expr A::uint128_max", error=True, substrs=["Couldn't lookup symbols:"]
29+
"expr A::uint128_max", error=True, substrs=["Couldn't look up symbols:"]
3030
)
3131
self.expect(
32-
"expr A::int128_min", error=True, substrs=["Couldn't lookup symbols:"]
32+
"expr A::int128_min", error=True, substrs=["Couldn't look up symbols:"]
3333
)
3434
self.expect(
35-
"expr A::uint128_min", error=True, substrs=["Couldn't lookup symbols:"]
35+
"expr A::uint128_min", error=True, substrs=["Couldn't look up symbols:"]
3636
)

lldb/test/API/lang/cpp/constructors/TestCppConstructors.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,19 +35,19 @@ def test_constructors(self):
3535
self.expect(
3636
"expr ClassWithDefaultedCtor().foo()",
3737
error=True,
38-
substrs=["Couldn't lookup symbols:"],
38+
substrs=["Couldn't look up symbols:"],
3939
)
4040

4141
# FIXME: Calling deleted constructors should fail before linking.
4242
self.expect(
4343
"expr ClassWithDeletedCtor(1).value",
4444
error=True,
45-
substrs=["Couldn't lookup symbols:"],
45+
substrs=["Couldn't look up symbols:"],
4646
)
4747
self.expect(
4848
"expr ClassWithDeletedDefaultCtor().value",
4949
error=True,
50-
substrs=["Couldn't lookup symbols:"],
50+
substrs=["Couldn't look up symbols:"],
5151
)
5252

5353
@skipIfWindows # Can't find operator new.

lldb/test/API/lang/cpp/unique-types4/TestUniqueTypes4.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,12 @@ def do_test(self, debug_flags):
3030
)
3131
self.expect(
3232
"expression ns::FooDouble::value",
33-
substrs=["Couldn't lookup symbols"],
33+
substrs=["Couldn't look up symbols"],
3434
error=True,
3535
)
3636
self.expect(
3737
"expression ns::FooInt::value",
38-
substrs=["Couldn't lookup symbols"],
38+
substrs=["Couldn't look up symbols"],
3939
error=True,
4040
)
4141

0 commit comments

Comments
 (0)