[IRMover] Remove unnecessary pointer bitcast (NFC)

nikic · nikic · commit b3529ed1d8a9 · 2025-04-25T15:13:48.000+02:00
diff --git a/llvm/lib/Linker/IRMover.cpp b/llvm/lib/Linker/IRMover.cpp
@@ -969,8 +969,6 @@ IRLinker::linkAppendingVarProto(GlobalVariable *DstGV,
   NG->copyAttributesFrom(SrcGV);
   forceRenaming(NG, SrcGV->getName());
 
-  Constant *Ret = ConstantExpr::getBitCast(NG, TypeMap.get(SrcGV->getType()));
-
   Mapper.scheduleMapAppendingVariable(
       *NG,
       (DstGV && !DstGV->isDeclaration()) ? DstGV->getInitializer() : nullptr,
@@ -982,7 +980,7 @@ IRLinker::linkAppendingVarProto(GlobalVariable *DstGV,
     RAUWWorklist.push_back(std::make_pair(DstGV, NG));
   }
 
-  return Ret;
+  return NG;
 }
 
 bool IRLinker::shouldLink(GlobalValue *DGV, GlobalValue &SGV) {

Original file line number	Diff line number	Diff line change
`@@ -969,8 +969,6 @@ IRLinker::linkAppendingVarProto(GlobalVariable *DstGV,`
`969`	`969`	`NG->copyAttributesFrom(SrcGV);`
`970`	`970`	`forceRenaming(NG, SrcGV->getName());`
`971`	`971`
`972`		`- Constant *Ret = ConstantExpr::getBitCast(NG, TypeMap.get(SrcGV->getType()));`
`973`		`-`
`974`	`972`	`Mapper.scheduleMapAppendingVariable(`
`975`	`973`	`*NG,`
`976`	`974`	`(DstGV && !DstGV->isDeclaration()) ? DstGV->getInitializer() : nullptr,`
`@@ -982,7 +980,7 @@ IRLinker::linkAppendingVarProto(GlobalVariable *DstGV,`
`982`	`980`	`RAUWWorklist.push_back(std::make_pair(DstGV, NG));`
`983`	`981`	`}`
`984`	`982`
`985`		`- return Ret;`
	`983`	`+ return NG;`
`986`	`984`	`}`
`987`	`985`
`988`	`986`	`bool IRLinker::shouldLink(GlobalValue *DGV, GlobalValue &SGV) {`