Skip to content

Commit b3e1f1b

Browse files
authored
[lldb] Fix help syntax for add-dsym (target symbols add) (#98976)
The help output incorrectly states that this command takes a shared library name (<shlib-name>) while really it takes a path to a symbol file. rdar://131777043
1 parent 4497ec2 commit b3e1f1b

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

lldb/source/Commands/CommandObjectTarget.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4252,7 +4252,7 @@ class CommandObjectTargetSymbolsAdd : public CommandObjectParsed {
42524252
m_option_group.Append(&m_current_stack_option, LLDB_OPT_SET_2,
42534253
LLDB_OPT_SET_2);
42544254
m_option_group.Finalize();
4255-
AddSimpleArgumentList(eArgTypeShlibName);
4255+
AddSimpleArgumentList(eArgTypeFilename);
42564256
}
42574257

42584258
~CommandObjectTargetSymbolsAdd() override = default;
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# REQUIRES: system-darwin
22

3+
# RUN: %lldb -o 'help add-dsym' | FileCheck %s --check-prefix=HELP
4+
# HELP: Syntax: add-dsym <cmd-options> <filename>
5+
36
# RUN: yaml2obj %S/Inputs/a.yaml -o %t.out
47
# RUN: LLDB_APPLE_DSYMFORUUID_EXECUTABLE=%S/Inputs/dsymforuuid.sh %lldb %t.out -o 'add-dsym -u 41945CA4-5D9D-3CDE-82B4-37E4C09750B5' 2>&1 | FileCheck %s
58
# CHECK: UUID information was not found

0 commit comments

Comments
 (0)