Skip to content

Commit bb21a68

Browse files
[mlir][memref] Move AllocLikeConversion.h helpers into MemRefToLLVM.cpp (#136424)
This commit moves code around: The helper functions/classes are moved into `MemRefToLLVM.cpp`. This simplifies the code a bit: fewer templatized functions, fewer function calls, fewer lines of code. This commit also moves checks in `matchAndRewrite` to the beginning of the functions, such that patterns bail out (`return failure()`) before starting to modify any IR. (Apart from that, this change is NFC.) This is in preparation of the One-Shot Dialect Conversion refactoring, which will disallow pattern rollbacks.
1 parent 90c845f commit bb21a68

File tree

4 files changed

+301
-405
lines changed

4 files changed

+301
-405
lines changed

mlir/include/mlir/Conversion/MemRefToLLVM/AllocLikeConversion.h

Lines changed: 0 additions & 153 deletions
This file was deleted.

mlir/lib/Conversion/MemRefToLLVM/AllocLikeConversion.cpp

Lines changed: 0 additions & 195 deletions
This file was deleted.

mlir/lib/Conversion/MemRefToLLVM/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
add_mlir_conversion_library(MLIRMemRefToLLVM
2-
AllocLikeConversion.cpp
32
MemRefToLLVM.cpp
43

54
ADDITIONAL_HEADER_DIRS

0 commit comments

Comments
 (0)