Skip to content

Commit bc81f8c

Browse files
authored
[mlir][vector] Drop incorrect startRootUpdate calls in vector distribution (#71988)
Fixes asan failures in https://lab.llvm.org/buildbot/#/builders/5/builds/38191 introduced by #71964.
1 parent fa7e07e commit bc81f8c

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

mlir/lib/Dialect/Vector/Transforms/VectorDistribute.cpp

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -646,10 +646,6 @@ struct WarpOpElementwise : public OpRewritePattern<WarpExecuteOnLane0Op> {
646646
if (!yieldOperand)
647647
return failure();
648648

649-
// Notify the rewriter that the warp op is changing (see the comment on
650-
// the WarpOpTransferRead pattern).
651-
rewriter.startRootUpdate(warpOp);
652-
653649
Operation *elementWise = yieldOperand->get().getDefiningOp();
654650
unsigned operandIndex = yieldOperand->getOperandNumber();
655651
Value distributedVal = warpOp.getResult(operandIndex);
@@ -688,7 +684,6 @@ struct WarpOpElementwise : public OpRewritePattern<WarpExecuteOnLane0Op> {
688684
{newWarpOp.getResult(operandIndex).getType()});
689685
rewriter.replaceAllUsesWith(newWarpOp.getResult(operandIndex),
690686
newOp->getResult(0));
691-
rewriter.finalizeRootUpdate(warpOp);
692687
return success();
693688
}
694689
};
@@ -1058,9 +1053,6 @@ struct WarpOpBroadcast : public OpRewritePattern<WarpExecuteOnLane0Op> {
10581053
if (vector::isBroadcastableTo(broadcastSrcType, destVecType) !=
10591054
vector::BroadcastableToResult::Success)
10601055
return failure();
1061-
// Notify the rewriter that the warp op is changing (see the comment on
1062-
// the WarpOpTransferRead pattern).
1063-
rewriter.startRootUpdate(warpOp);
10641056
SmallVector<size_t> newRetIndices;
10651057
WarpExecuteOnLane0Op newWarpOp = moveRegionToNewWarpOpAndAppendReturns(
10661058
rewriter, warpOp, {broadcastSrc}, {broadcastSrcType}, newRetIndices);
@@ -1069,7 +1061,6 @@ struct WarpOpBroadcast : public OpRewritePattern<WarpExecuteOnLane0Op> {
10691061
loc, destVecType, newWarpOp->getResult(newRetIndices[0]));
10701062
rewriter.replaceAllUsesWith(newWarpOp->getResult(operandNumber),
10711063
broadcasted);
1072-
rewriter.finalizeRootUpdate(warpOp);
10731064
return success();
10741065
}
10751066
};

0 commit comments

Comments
 (0)