Skip to content

Commit bcd7526

Browse files
committed
expandFMINIMUMNUM_FMAXIMUMNUM: Quiet is not needed for NaN vs NaN
New LangRef doesn't requires quieting for NaN vs NaN, aka the result may be sNaN for sNaN vs NaN. See: #139228
1 parent a6ca703 commit bcd7526

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8690,11 +8690,6 @@ SDValue TargetLowering::expandFMINIMUMNUM_FMAXIMUMNUM(SDNode *Node,
86908690

86918691
SDValue MinMax =
86928692
DAG.getSelectCC(DL, LHS, RHS, LHS, RHS, IsMax ? ISD::SETGT : ISD::SETLT);
8693-
// If MinMax is NaN, let's quiet it.
8694-
if (!Flags.hasNoNaNs() && !DAG.isKnownNeverNaN(LHS) &&
8695-
!DAG.isKnownNeverNaN(RHS)) {
8696-
MinMax = DAG.getNode(ISD::FCANONICALIZE, DL, VT, MinMax, Flags);
8697-
}
86988693

86998694
// Fixup signed zero behavior.
87008695
if (Options.NoSignedZerosFPMath || Flags.hasNoSignedZeros() ||

0 commit comments

Comments
 (0)