Skip to content

Commit bf3cba7

Browse files
committed
Revert "[runtime] Build compiler-rt with --unwindlib=none"
This reverts commit 102bc63 because some tests are failing on sanitizer bots.
1 parent 1bffc75 commit bf3cba7

File tree

2 files changed

+0
-18
lines changed

2 files changed

+0
-18
lines changed

compiler-rt/CMakeLists.txt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -506,11 +506,6 @@ list(APPEND COMPILER_RT_COMMON_LINK_FLAGS ${stdlib_flag})
506506

507507
macro(append_libcxx_libs var)
508508
if (${var}_INTREE)
509-
# If we're linking directly against the libunwind that we're building
510-
# in the same invocation, don't try to link in the toolchain's
511-
# default libunwind (which may be missing still).
512-
append_list_if(CXX_SUPPORTS_UNWINDLIB_NONE_FLAG --unwindlib=none SANITIZER_COMMON_LINK_FLAGS)
513-
514509
if (SANITIZER_USE_STATIC_LLVM_UNWINDER AND (TARGET unwind_static OR HAVE_LIBUNWIND))
515510
list(APPEND ${var}_LIBRARIES unwind_static)
516511
elseif (TARGET unwind_shared OR HAVE_LIBUNWIND)

compiler-rt/cmake/config-ix.cmake

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -4,22 +4,9 @@ include(CheckCCompilerFlag)
44
include(CheckCXXCompilerFlag)
55
include(CheckIncludeFiles)
66
include(CheckLibraryExists)
7-
include(LLVMCheckCompilerLinkerFlag)
87
include(CheckSymbolExists)
98
include(TestBigEndian)
109

11-
# The compiler driver may be implicitly trying to link against libunwind.
12-
# This is normally ok (libcxx relies on an unwinder), but if libunwind is
13-
# built in the same cmake invocation as compiler-rt and we're using the
14-
# in tree version of runtimes, we'd be linking against the just-built
15-
# libunwind (and the compiler implicit -lunwind wouldn't succeed as the newly
16-
# built libunwind isn't installed yet). For those cases, it'd be good to
17-
# link with --uwnindlib=none. Check if that option works.
18-
llvm_check_compiler_linker_flag(C "--unwindlib=none" CXX_SUPPORTS_UNWINDLIB_NONE_FLAG)
19-
if (CXX_SUPPORTS_UNWINDLIB_NONE_FLAG)
20-
set(CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS} --unwindlib=none")
21-
endif()
22-
2310
check_library_exists(c fopen "" COMPILER_RT_HAS_LIBC)
2411
if (COMPILER_RT_USE_BUILTINS_LIBRARY)
2512
include(HandleCompilerRT)

0 commit comments

Comments
 (0)