Skip to content

Commit bf51e77

Browse files
committed
Update the names and description in RISCVFeatures.td
1 parent c963067 commit bf51e77

File tree

3 files changed

+12
-14
lines changed

3 files changed

+12
-14
lines changed

llvm/lib/Target/RISCV/RISCVFeatures.td

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -206,19 +206,17 @@ def HasStdExtM : Predicate<"Subtarget->hasStdExtM()">,
206206
def FeatureStdExtZaamo
207207
: RISCVExtension<"zaamo", 1, 0,
208208
"'Zaamo' (Atomic Memory Operations)">;
209-
def HasStdExtAOrZaamo
209+
def HasStdExtZaamo
210210
: Predicate<"Subtarget->hasStdExtZaamo()">,
211211
AssemblerPredicate<(any_of FeatureStdExtZaamo),
212-
"'A' (Atomic Instructions) or "
213212
"'Zaamo' (Atomic Memory Operations)">;
214213

215214
def FeatureStdExtZalrsc
216215
: RISCVExtension<"zalrsc", 1, 0,
217216
"'Zalrsc' (Load-Reserved/Store-Conditional)">;
218-
def HasStdExtAOrZalrsc
217+
def HasStdExtZalrsc
219218
: Predicate<"Subtarget->hasStdExtZalrsc()">,
220219
AssemblerPredicate<(any_of FeatureStdExtZalrsc),
221-
"'A' (Atomic Instructions) or "
222220
"'Zalrsc' (Load-Reserved/Store-Conditional)">;
223221

224222
def FeatureStdExtA

llvm/lib/Target/RISCV/RISCVInstrInfoA.td

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -60,13 +60,13 @@ multiclass AMO_rr_aq_rl<bits<5> funct5, bits<3> funct3, string opcodestr> {
6060
// Instructions
6161
//===----------------------------------------------------------------------===//
6262

63-
let Predicates = [HasStdExtAOrZalrsc], IsSignExtendingOpW = 1 in {
63+
let Predicates = [HasStdExtZalrsc], IsSignExtendingOpW = 1 in {
6464
defm LR_W : LR_r_aq_rl<0b010, "lr.w">, Sched<[WriteAtomicLDW, ReadAtomicLDW]>;
6565
defm SC_W : SC_r_aq_rl<0b010, "sc.w">,
6666
Sched<[WriteAtomicSTW, ReadAtomicSTW, ReadAtomicSTW]>;
67-
} // Predicates = [HasStdExtAOrZalrsc], IsSignExtendingOpW = 1
67+
} // Predicates = [HasStdExtZalrsc], IsSignExtendingOpW = 1
6868

69-
let Predicates = [HasStdExtAOrZaamo], IsSignExtendingOpW = 1 in {
69+
let Predicates = [HasStdExtZaamo], IsSignExtendingOpW = 1 in {
7070
defm AMOSWAP_W : AMO_rr_aq_rl<0b00001, 0b010, "amoswap.w">,
7171
Sched<[WriteAtomicW, ReadAtomicWA, ReadAtomicWD]>;
7272
defm AMOADD_W : AMO_rr_aq_rl<0b00000, 0b010, "amoadd.w">,
@@ -85,15 +85,15 @@ defm AMOMINU_W : AMO_rr_aq_rl<0b11000, 0b010, "amominu.w">,
8585
Sched<[WriteAtomicW, ReadAtomicWA, ReadAtomicWD]>;
8686
defm AMOMAXU_W : AMO_rr_aq_rl<0b11100, 0b010, "amomaxu.w">,
8787
Sched<[WriteAtomicW, ReadAtomicWA, ReadAtomicWD]>;
88-
} // Predicates = [HasStdExtAOrZaamo], IsSignExtendingOpW = 1
88+
} // Predicates = [HasStdExtZaamo], IsSignExtendingOpW = 1
8989

90-
let Predicates = [HasStdExtAOrZalrsc, IsRV64] in {
90+
let Predicates = [HasStdExtZalrsc, IsRV64] in {
9191
defm LR_D : LR_r_aq_rl<0b011, "lr.d">, Sched<[WriteAtomicLDD, ReadAtomicLDD]>;
9292
defm SC_D : SC_r_aq_rl<0b011, "sc.d">,
9393
Sched<[WriteAtomicSTD, ReadAtomicSTD, ReadAtomicSTD]>;
94-
} // Predicates = [HasStdExtAOrZalrsc, IsRV64]
94+
} // Predicates = [HasStdExtZalrsc, IsRV64]
9595

96-
let Predicates = [HasStdExtAOrZaamo, IsRV64] in {
96+
let Predicates = [HasStdExtZaamo, IsRV64] in {
9797
defm AMOSWAP_D : AMO_rr_aq_rl<0b00001, 0b011, "amoswap.d">,
9898
Sched<[WriteAtomicD, ReadAtomicDA, ReadAtomicDD]>;
9999
defm AMOADD_D : AMO_rr_aq_rl<0b00000, 0b011, "amoadd.d">,
@@ -112,7 +112,7 @@ defm AMOMINU_D : AMO_rr_aq_rl<0b11000, 0b011, "amominu.d">,
112112
Sched<[WriteAtomicD, ReadAtomicDA, ReadAtomicDD]>;
113113
defm AMOMAXU_D : AMO_rr_aq_rl<0b11100, 0b011, "amomaxu.d">,
114114
Sched<[WriteAtomicD, ReadAtomicDA, ReadAtomicDD]>;
115-
} // Predicates = [HasStdExtAOrZaamo, IsRV64]
115+
} // Predicates = [HasStdExtZaamo, IsRV64]
116116

117117
//===----------------------------------------------------------------------===//
118118
// Pseudo-instructions and codegen patterns

llvm/test/MC/RISCV/rv32i-invalid.s

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,8 +183,8 @@ xor s2, s2 # CHECK: :[[@LINE]]:1: error: too few operands for instruction
183183

184184
# Instruction not in the base ISA
185185
div a4, ra, s0 # CHECK: :[[@LINE]]:1: error: instruction requires the following: 'M' (Integer Multiplication and Division){{$}}
186-
amomaxu.w s5, s4, (s3) # CHECK: :[[@LINE]]:1: error: instruction requires the following: 'A' (Atomic Instructions) or 'Zaamo' (Atomic Memory Operations){{$}}
187-
lr.w t0, (t1) # CHECK: :[[@LINE]]:1: error: instruction requires the following: 'A' (Atomic Instructions) or 'Zalrsc' (Load-Reserved/Store-Conditional){{$}}
186+
amomaxu.w s5, s4, (s3) # CHECK: :[[@LINE]]:1: error: instruction requires the following: 'Zaamo' (Atomic Memory Operations){{$}}
187+
lr.w t0, (t1) # CHECK: :[[@LINE]]:1: error: instruction requires the following: 'Zalrsc' (Load-Reserved/Store-Conditional){{$}}
188188
fadd.s ft0, ft1, ft2 # CHECK: :[[@LINE]]:1: error: instruction requires the following: 'F' (Single-Precision Floating-Point){{$}}
189189
fadd.h ft0, ft1, ft2 # CHECK: :[[@LINE]]:1: error: instruction requires the following: 'Zfh' (Half-Precision Floating-Point){{$}}
190190
fadd.s a0, a1, a2 # CHECK: :[[@LINE]]:1: error: instruction requires the following: 'Zfinx' (Float in Integer){{$}}

0 commit comments

Comments
 (0)