address comments

Peiming Liu · Peiming Liu · commit c1e4fb762c0d · 2024-06-14T17:22:26.000Z
diff --git a/mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorOps.td b/mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorOps.td
@@ -1603,7 +1603,7 @@ def IterateOp : SparseTensor_Op<"iterate",
     }
     std::optional<BlockArgument> getLvlCrd(Level lvl) {
       if (getCrdUsedLvls()[lvl]) {
-        uint64_t mask = (1 << lvl) - 1;
+        uint64_t mask = (static_cast<uint64_t>(0x01u) << lvl) - 1;
         return getCrds()[llvm::popcount(mask & getCrdUsedLvls())];
       }
       return std::nullopt;

Original file line number	Diff line number	Diff line change
`@@ -1603,7 +1603,7 @@ def IterateOp : SparseTensor_Op<"iterate",`
`1603`	`1603`	`}`
`1604`	`1604`	`std::optional<BlockArgument> getLvlCrd(Level lvl) {`
`1605`	`1605`	`if (getCrdUsedLvls()[lvl]) {`
`1606`		`- uint64_t mask = (1 << lvl) - 1;`
	`1606`	`+ uint64_t mask = (static_cast<uint64_t>(0x01u) << lvl) - 1;`
`1607`	`1607`	`return getCrds()[llvm::popcount(mask & getCrdUsedLvls())];`
`1608`	`1608`	`}`
`1609`	`1609`	`return std::nullopt;`