Skip to content

Commit c3c443b

Browse files
goldsteinngoldsteinn
committed
[InstCombine] Add transforms (icmp spred (and X, Y), X) if X or Y are known signed/unsigned
Several transforms: 1) If known `Y < 0`: - slt -> ult: https://alive2.llvm.org/ce/z/9zt2iK - sle -> ule: https://alive2.llvm.org/ce/z/SPoPNF - sgt -> ugt: https://alive2.llvm.org/ce/z/IGNxAk - sge -> uge: https://alive2.llvm.org/ce/z/joqTvR 2) If known `Y >= 0`: - `(X & PosY) s> X --> X s< 0` - https://alive2.llvm.org/ce/z/7e-5BQ - `(X & PosY) s> X --> X s< 0` - https://alive2.llvm.org/ce/z/jvT4Gb 3) If known `X < 0`: - `(NegX & Y) s> NegX --> Y s>= 0` - https://alive2.llvm.org/ce/z/ApkaEh - `(NegX & Y) s<= NegX --> Y s< 0` - https://alive2.llvm.org/ce/z/oRnfHp Closes #94417
1 parent afc7292 commit c3c443b

7 files changed

+74
-71
lines changed

‎llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4745,6 +4745,29 @@ static Instruction *foldICmpAndXX(ICmpInst &I, const SimplifyQuery &Q,
47454745
Constant::getNullValue(Op1->getType()));
47464746
}
47474747

4748+
if (!ICmpInst::isSigned(Pred))
4749+
return nullptr;
4750+
4751+
KnownBits KnownY = IC.computeKnownBits(A, /*Depth=*/0, &I);
4752+
// (X & NegY) spred X --> (X & NegY) upred X
4753+
if (KnownY.isNegative())
4754+
return new ICmpInst(ICmpInst::getUnsignedPredicate(Pred), Op0, Op1);
4755+
4756+
if (Pred != ICmpInst::ICMP_SLE && Pred != ICmpInst::ICMP_SGT)
4757+
return nullptr;
4758+
4759+
if (KnownY.isNonNegative())
4760+
// (X & PosY) s<= X --> X s>= 0
4761+
// (X & PosY) s> X --> X s< 0
4762+
return new ICmpInst(ICmpInst::getSwappedPredicate(Pred), Op1,
4763+
Constant::getNullValue(Op1->getType()));
4764+
4765+
if (isKnownNegative(Op1, IC.getSimplifyQuery().getWithInstruction(&I)))
4766+
// (NegX & Y) s<= NegX --> Y s< 0
4767+
// (NegX & Y) s> NegX --> Y s>= 0
4768+
return new ICmpInst(ICmpInst::getFlippedStrictnessPredicate(Pred), A,
4769+
Constant::getNullValue(A->getType()));
4770+
47484771
return nullptr;
47494772
}
47504773

‎llvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-sge-to-icmp-sle.ll

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,7 @@ declare i8 @gen8()
9898
define i1 @c0() {
9999
; CHECK-LABEL: @c0(
100100
; CHECK-NEXT: [[X:%.*]] = call i8 @gen8()
101-
; CHECK-NEXT: [[TMP0:%.*]] = and i8 [[X]], 3
102-
; CHECK-NEXT: [[RET:%.*]] = icmp sge i8 [[X]], [[TMP0]]
101+
; CHECK-NEXT: [[RET:%.*]] = icmp sgt i8 [[X]], -1
103102
; CHECK-NEXT: ret i1 [[RET]]
104103
;
105104
%x = call i8 @gen8()

‎llvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-sgt-to-icmp-sgt.ll

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,7 @@ define i1 @oneuse0() {
125125

126126
define i1 @c0(i8 %x) {
127127
; CHECK-LABEL: @c0(
128-
; CHECK-NEXT: [[TMP0:%.*]] = and i8 [[X:%.*]], 3
129-
; CHECK-NEXT: [[RET:%.*]] = icmp sgt i8 [[TMP0]], [[X]]
128+
; CHECK-NEXT: [[RET:%.*]] = icmp slt i8 [[X:%.*]], 0
130129
; CHECK-NEXT: ret i1 [[RET]]
131130
;
132131
%tmp0 = and i8 %x, 3

‎llvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-sle-to-icmp-sle.ll

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,7 @@ define i1 @oneuse0() {
113113

114114
define i1 @c0(i8 %x) {
115115
; CHECK-LABEL: @c0(
116-
; CHECK-NEXT: [[TMP0:%.*]] = and i8 [[X:%.*]], 3
117-
; CHECK-NEXT: [[RET:%.*]] = icmp sle i8 [[TMP0]], [[X]]
116+
; CHECK-NEXT: [[RET:%.*]] = icmp sgt i8 [[X:%.*]], -1
118117
; CHECK-NEXT: ret i1 [[RET]]
119118
;
120119
%tmp0 = and i8 %x, 3

‎llvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-slt-to-icmp-sgt.ll

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,7 @@ declare i8 @gen8()
108108
define i1 @c0() {
109109
; CHECK-LABEL: @c0(
110110
; CHECK-NEXT: [[X:%.*]] = call i8 @gen8()
111-
; CHECK-NEXT: [[TMP0:%.*]] = and i8 [[X]], 3
112-
; CHECK-NEXT: [[RET:%.*]] = icmp slt i8 [[X]], [[TMP0]]
111+
; CHECK-NEXT: [[RET:%.*]] = icmp slt i8 [[X]], 0
113112
; CHECK-NEXT: ret i1 [[RET]]
114113
;
115114
%x = call i8 @gen8()

‎llvm/test/Transforms/InstCombine/icmp-and-lowbit-mask.ll

Lines changed: 34 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ define i1 @src_is_mask_zext(i16 %x_in, i8 %y) {
77
; CHECK-LABEL: @src_is_mask_zext(
88
; CHECK-NEXT: [[M_IN:%.*]] = lshr i8 -1, [[Y:%.*]]
99
; CHECK-NEXT: [[MASK:%.*]] = zext i8 [[M_IN]] to i16
10-
; CHECK-NEXT: [[X:%.*]] = xor i16 [[X_IN:%.*]], 123
11-
; CHECK-NEXT: [[R:%.*]] = icmp ule i16 [[X]], [[MASK]]
10+
; CHECK-NEXT: [[TMP1:%.*]] = xor i16 [[X_IN:%.*]], 123
11+
; CHECK-NEXT: [[R:%.*]] = icmp ule i16 [[TMP1]], [[MASK]]
1212
; CHECK-NEXT: ret i1 [[R]]
1313
;
1414
%x = xor i16 %x_in, 123
@@ -83,8 +83,8 @@ define i1 @src_is_mask_and(i8 %x_in, i8 %y, i8 %z) {
8383
; CHECK-NEXT: [[MY:%.*]] = lshr i8 7, [[Y:%.*]]
8484
; CHECK-NEXT: [[MZ:%.*]] = lshr i8 -1, [[Z:%.*]]
8585
; CHECK-NEXT: [[MASK:%.*]] = and i8 [[MY]], [[MZ]]
86-
; CHECK-NEXT: [[X:%.*]] = xor i8 [[X_IN:%.*]], 123
87-
; CHECK-NEXT: [[R:%.*]] = icmp ule i8 [[X]], [[MASK]]
86+
; CHECK-NEXT: [[TMP1:%.*]] = xor i8 [[X_IN:%.*]], 123
87+
; CHECK-NEXT: [[R:%.*]] = icmp ule i8 [[TMP1]], [[MASK]]
8888
; CHECK-NEXT: ret i1 [[R]]
8989
;
9090
%x = xor i8 %x_in, 123
@@ -121,8 +121,8 @@ define i1 @src_is_mask_or(i8 %x_in, i8 %y) {
121121
; CHECK-LABEL: @src_is_mask_or(
122122
; CHECK-NEXT: [[MY:%.*]] = lshr i8 -1, [[Y:%.*]]
123123
; CHECK-NEXT: [[MASK:%.*]] = and i8 [[MY]], 7
124-
; CHECK-NEXT: [[X:%.*]] = xor i8 [[X_IN:%.*]], 123
125-
; CHECK-NEXT: [[R:%.*]] = icmp ule i8 [[X]], [[MASK]]
124+
; CHECK-NEXT: [[TMP1:%.*]] = xor i8 [[X_IN:%.*]], 123
125+
; CHECK-NEXT: [[R:%.*]] = icmp ule i8 [[TMP1]], [[MASK]]
126126
; CHECK-NEXT: ret i1 [[R]]
127127
;
128128
%x = xor i8 %x_in, 123
@@ -138,8 +138,8 @@ define i1 @src_is_mask_xor(i8 %x_in, i8 %y) {
138138
; CHECK-LABEL: @src_is_mask_xor(
139139
; CHECK-NEXT: [[Y_M1:%.*]] = add i8 [[Y:%.*]], -1
140140
; CHECK-NEXT: [[MASK:%.*]] = xor i8 [[Y_M1]], [[Y]]
141-
; CHECK-NEXT: [[X:%.*]] = xor i8 [[X_IN:%.*]], 123
142-
; CHECK-NEXT: [[R:%.*]] = icmp ugt i8 [[X]], [[MASK]]
141+
; CHECK-NEXT: [[TMP1:%.*]] = xor i8 [[X_IN:%.*]], 123
142+
; CHECK-NEXT: [[R:%.*]] = icmp ugt i8 [[TMP1]], [[MASK]]
143143
; CHECK-NEXT: ret i1 [[R]]
144144
;
145145
%x = xor i8 %x_in, 123
@@ -173,8 +173,8 @@ define i1 @src_is_mask_select(i8 %x_in, i8 %y, i1 %cond) {
173173
; CHECK-NEXT: [[Y_M1:%.*]] = add i8 [[Y:%.*]], -1
174174
; CHECK-NEXT: [[YMASK:%.*]] = xor i8 [[Y_M1]], [[Y]]
175175
; CHECK-NEXT: [[MASK:%.*]] = select i1 [[COND:%.*]], i8 [[YMASK]], i8 15
176-
; CHECK-NEXT: [[X:%.*]] = xor i8 [[X_IN:%.*]], 123
177-
; CHECK-NEXT: [[R:%.*]] = icmp ugt i8 [[X]], [[MASK]]
176+
; CHECK-NEXT: [[TMP1:%.*]] = xor i8 [[X_IN:%.*]], 123
177+
; CHECK-NEXT: [[R:%.*]] = icmp ugt i8 [[TMP1]], [[MASK]]
178178
; CHECK-NEXT: ret i1 [[R]]
179179
;
180180
%x = xor i8 %x_in, 123
@@ -249,8 +249,8 @@ define i1 @src_is_mask_lshr(i8 %x_in, i8 %y, i8 %z, i1 %cond) {
249249
; CHECK-NEXT: [[YMASK:%.*]] = xor i8 [[Y_M1]], [[Y]]
250250
; CHECK-NEXT: [[SMASK:%.*]] = select i1 [[COND:%.*]], i8 [[YMASK]], i8 15
251251
; CHECK-NEXT: [[MASK:%.*]] = lshr i8 [[SMASK]], [[Z:%.*]]
252-
; CHECK-NEXT: [[X:%.*]] = xor i8 [[X_IN:%.*]], 123
253-
; CHECK-NEXT: [[R:%.*]] = icmp ugt i8 [[X]], [[MASK]]
252+
; CHECK-NEXT: [[TMP1:%.*]] = xor i8 [[X_IN:%.*]], 123
253+
; CHECK-NEXT: [[R:%.*]] = icmp ugt i8 [[TMP1]], [[MASK]]
254254
; CHECK-NEXT: ret i1 [[R]]
255255
;
256256
%x = xor i8 %x_in, 123
@@ -269,8 +269,8 @@ define i1 @src_is_mask_ashr(i8 %x_in, i8 %y, i8 %z, i1 %cond) {
269269
; CHECK-NEXT: [[YMASK:%.*]] = xor i8 [[Y_M1]], [[Y]]
270270
; CHECK-NEXT: [[SMASK:%.*]] = select i1 [[COND:%.*]], i8 [[YMASK]], i8 15
271271
; CHECK-NEXT: [[MASK:%.*]] = ashr i8 [[SMASK]], [[Z:%.*]]
272-
; CHECK-NEXT: [[X:%.*]] = xor i8 [[X_IN:%.*]], 123
273-
; CHECK-NEXT: [[R:%.*]] = icmp ugt i8 [[X]], [[MASK]]
272+
; CHECK-NEXT: [[TMP1:%.*]] = xor i8 [[X_IN:%.*]], 123
273+
; CHECK-NEXT: [[R:%.*]] = icmp ugt i8 [[TMP1]], [[MASK]]
274274
; CHECK-NEXT: ret i1 [[R]]
275275
;
276276
%x = xor i8 %x_in, 123
@@ -287,8 +287,8 @@ define i1 @src_is_mask_p2_m1(i8 %x_in, i8 %y) {
287287
; CHECK-LABEL: @src_is_mask_p2_m1(
288288
; CHECK-NEXT: [[P2ORZ:%.*]] = shl i8 2, [[Y:%.*]]
289289
; CHECK-NEXT: [[MASK:%.*]] = add i8 [[P2ORZ]], -1
290-
; CHECK-NEXT: [[X:%.*]] = xor i8 [[X_IN:%.*]], 123
291-
; CHECK-NEXT: [[R:%.*]] = icmp ugt i8 [[X]], [[MASK]]
290+
; CHECK-NEXT: [[TMP1:%.*]] = xor i8 [[X_IN:%.*]], 123
291+
; CHECK-NEXT: [[R:%.*]] = icmp ugt i8 [[TMP1]], [[MASK]]
292292
; CHECK-NEXT: ret i1 [[R]]
293293
;
294294
%x = xor i8 %x_in, 123
@@ -304,8 +304,8 @@ define i1 @src_is_mask_umax(i8 %x_in, i8 %y) {
304304
; CHECK-NEXT: [[Y_M1:%.*]] = add i8 [[Y:%.*]], -1
305305
; CHECK-NEXT: [[YMASK:%.*]] = xor i8 [[Y_M1]], [[Y]]
306306
; CHECK-NEXT: [[MASK:%.*]] = call i8 @llvm.umax.i8(i8 [[YMASK]], i8 3)
307-
; CHECK-NEXT: [[X:%.*]] = xor i8 [[X_IN:%.*]], 123
308-
; CHECK-NEXT: [[R:%.*]] = icmp ugt i8 [[X]], [[MASK]]
307+
; CHECK-NEXT: [[TMP1:%.*]] = xor i8 [[X_IN:%.*]], 123
308+
; CHECK-NEXT: [[R:%.*]] = icmp ugt i8 [[TMP1]], [[MASK]]
309309
; CHECK-NEXT: ret i1 [[R]]
310310
;
311311
%x = xor i8 %x_in, 123
@@ -324,8 +324,8 @@ define i1 @src_is_mask_umin(i8 %x_in, i8 %y, i8 %z) {
324324
; CHECK-NEXT: [[YMASK:%.*]] = xor i8 [[Y_M1]], [[Y]]
325325
; CHECK-NEXT: [[ZMASK:%.*]] = lshr i8 15, [[Z:%.*]]
326326
; CHECK-NEXT: [[MASK:%.*]] = call i8 @llvm.umin.i8(i8 [[YMASK]], i8 [[ZMASK]])
327-
; CHECK-NEXT: [[X:%.*]] = xor i8 [[X_IN:%.*]], 123
328-
; CHECK-NEXT: [[R:%.*]] = icmp ugt i8 [[X]], [[MASK]]
327+
; CHECK-NEXT: [[TMP1:%.*]] = xor i8 [[X_IN:%.*]], 123
328+
; CHECK-NEXT: [[R:%.*]] = icmp ugt i8 [[TMP1]], [[MASK]]
329329
; CHECK-NEXT: ret i1 [[R]]
330330
;
331331
%x = xor i8 %x_in, 123
@@ -364,8 +364,8 @@ define i1 @src_is_mask_smax(i8 %x_in, i8 %y) {
364364
; CHECK-NEXT: [[Y_M1:%.*]] = add i8 [[Y:%.*]], -1
365365
; CHECK-NEXT: [[YMASK:%.*]] = xor i8 [[Y_M1]], [[Y]]
366366
; CHECK-NEXT: [[MASK:%.*]] = call i8 @llvm.smax.i8(i8 [[YMASK]], i8 -1)
367-
; CHECK-NEXT: [[X:%.*]] = xor i8 [[X_IN:%.*]], 123
368-
; CHECK-NEXT: [[R:%.*]] = icmp ule i8 [[X]], [[MASK]]
367+
; CHECK-NEXT: [[TMP1:%.*]] = xor i8 [[X_IN:%.*]], 123
368+
; CHECK-NEXT: [[R:%.*]] = icmp ule i8 [[TMP1]], [[MASK]]
369369
; CHECK-NEXT: ret i1 [[R]]
370370
;
371371
%x = xor i8 %x_in, 123
@@ -383,8 +383,8 @@ define i1 @src_is_mask_smin(i8 %x_in, i8 %y) {
383383
; CHECK-NEXT: [[Y_M1:%.*]] = add i8 [[Y:%.*]], -1
384384
; CHECK-NEXT: [[YMASK:%.*]] = xor i8 [[Y_M1]], [[Y]]
385385
; CHECK-NEXT: [[MASK:%.*]] = call i8 @llvm.smin.i8(i8 [[YMASK]], i8 0)
386-
; CHECK-NEXT: [[X:%.*]] = xor i8 [[X_IN:%.*]], 123
387-
; CHECK-NEXT: [[R:%.*]] = icmp ule i8 [[X]], [[MASK]]
386+
; CHECK-NEXT: [[TMP1:%.*]] = xor i8 [[X_IN:%.*]], 123
387+
; CHECK-NEXT: [[R:%.*]] = icmp ule i8 [[TMP1]], [[MASK]]
388388
; CHECK-NEXT: ret i1 [[R]]
389389
;
390390
%x = xor i8 %x_in, 123
@@ -401,8 +401,8 @@ define i1 @src_is_mask_bitreverse_not_mask(i8 %x_in, i8 %y) {
401401
; CHECK-LABEL: @src_is_mask_bitreverse_not_mask(
402402
; CHECK-NEXT: [[NMASK:%.*]] = shl nsw i8 -1, [[Y:%.*]]
403403
; CHECK-NEXT: [[MASK:%.*]] = call i8 @llvm.bitreverse.i8(i8 [[NMASK]])
404-
; CHECK-NEXT: [[X:%.*]] = xor i8 [[X_IN:%.*]], 123
405-
; CHECK-NEXT: [[R:%.*]] = icmp ule i8 [[X]], [[MASK]]
404+
; CHECK-NEXT: [[TMP1:%.*]] = xor i8 [[X_IN:%.*]], 123
405+
; CHECK-NEXT: [[R:%.*]] = icmp ule i8 [[TMP1]], [[MASK]]
406406
; CHECK-NEXT: ret i1 [[R]]
407407
;
408408
%x = xor i8 %x_in, 123
@@ -455,9 +455,9 @@ define i1 @src_is_notmask_shl(i8 %x_in, i8 %y, i1 %cond) {
455455
define i1 @src_is_notmask_x_xor_neg_x(i8 %x_in, i8 %y, i1 %cond) {
456456
; CHECK-LABEL: @src_is_notmask_x_xor_neg_x(
457457
; CHECK-NEXT: [[X:%.*]] = xor i8 [[X_IN:%.*]], 123
458-
; CHECK-NEXT: [[NEG_Y:%.*]] = add i8 [[Y:%.*]], -1
459-
; CHECK-NEXT: [[NOTMASK0:%.*]] = xor i8 [[NEG_Y]], [[Y]]
460-
; CHECK-NEXT: [[TMP3:%.*]] = select i1 [[COND:%.*]], i8 [[NOTMASK0]], i8 7
458+
; CHECK-NEXT: [[TMP1:%.*]] = add i8 [[Y:%.*]], -1
459+
; CHECK-NEXT: [[TMP2:%.*]] = xor i8 [[TMP1]], [[Y]]
460+
; CHECK-NEXT: [[TMP3:%.*]] = select i1 [[COND:%.*]], i8 [[TMP2]], i8 7
461461
; CHECK-NEXT: [[R:%.*]] = icmp ule i8 [[X]], [[TMP3]]
462462
; CHECK-NEXT: ret i1 [[R]]
463463
;
@@ -473,9 +473,9 @@ define i1 @src_is_notmask_x_xor_neg_x(i8 %x_in, i8 %y, i1 %cond) {
473473
define i1 @src_is_notmask_x_xor_neg_x_inv(i8 %x_in, i8 %y, i1 %cond) {
474474
; CHECK-LABEL: @src_is_notmask_x_xor_neg_x_inv(
475475
; CHECK-NEXT: [[X:%.*]] = xor i8 [[X_IN:%.*]], 123
476-
; CHECK-NEXT: [[NEG_Y:%.*]] = add i8 [[Y:%.*]], -1
477-
; CHECK-NEXT: [[NOTMASK0:%.*]] = xor i8 [[NEG_Y]], [[Y]]
478-
; CHECK-NEXT: [[TMP3:%.*]] = select i1 [[COND:%.*]], i8 [[NOTMASK0]], i8 7
476+
; CHECK-NEXT: [[TMP1:%.*]] = add i8 [[Y:%.*]], -1
477+
; CHECK-NEXT: [[TMP2:%.*]] = xor i8 [[TMP1]], [[Y]]
478+
; CHECK-NEXT: [[TMP3:%.*]] = select i1 [[COND:%.*]], i8 [[TMP2]], i8 7
479479
; CHECK-NEXT: [[R:%.*]] = icmp ule i8 [[X]], [[TMP3]]
480480
; CHECK-NEXT: ret i1 [[R]]
481481
;
@@ -625,9 +625,7 @@ define i1 @src_is_notmask_xor_fail(i8 %x_in, i8 %y) {
625625

626626
define i1 @src_is_mask_const_slt(i8 %x_in) {
627627
; CHECK-LABEL: @src_is_mask_const_slt(
628-
; CHECK-NEXT: [[X:%.*]] = xor i8 [[X_IN:%.*]], 123
629-
; CHECK-NEXT: [[AND:%.*]] = and i8 [[X]], 7
630-
; CHECK-NEXT: [[R:%.*]] = icmp slt i8 [[X]], [[AND]]
628+
; CHECK-NEXT: [[R:%.*]] = icmp slt i8 [[X_IN:%.*]], 0
631629
; CHECK-NEXT: ret i1 [[R]]
632630
;
633631
%x = xor i8 %x_in, 123
@@ -650,9 +648,7 @@ define i1 @src_is_mask_const_sgt(i8 %x_in) {
650648

651649
define i1 @src_is_mask_const_sle(i8 %x_in) {
652650
; CHECK-LABEL: @src_is_mask_const_sle(
653-
; CHECK-NEXT: [[X:%.*]] = xor i8 [[X_IN:%.*]], 123
654-
; CHECK-NEXT: [[AND:%.*]] = and i8 [[X]], 31
655-
; CHECK-NEXT: [[R:%.*]] = icmp sle i8 [[AND]], [[X]]
651+
; CHECK-NEXT: [[R:%.*]] = icmp sgt i8 [[X_IN:%.*]], -1
656652
; CHECK-NEXT: ret i1 [[R]]
657653
;
658654
%x = xor i8 %x_in, 123

‎llvm/test/Transforms/InstCombine/icmp-of-and-x.ll

Lines changed: 13 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ define i1 @icmp_sge_x_negy(i8 %x, i8 %y) {
5858
; CHECK-NEXT: [[CY:%.*]] = icmp slt i8 [[Y:%.*]], 0
5959
; CHECK-NEXT: call void @llvm.assume(i1 [[CY]])
6060
; CHECK-NEXT: [[AND:%.*]] = and i8 [[X:%.*]], [[Y]]
61-
; CHECK-NEXT: [[Z:%.*]] = icmp sge i8 [[AND]], [[X]]
61+
; CHECK-NEXT: [[Z:%.*]] = icmp eq i8 [[AND]], [[X]]
6262
; CHECK-NEXT: ret i1 [[Z]]
6363
;
6464
%cy = icmp slt i8 %y, 0
@@ -74,7 +74,7 @@ define i1 @icmp_slt_x_negy(i8 %x, i8 %y) {
7474
; CHECK-NEXT: br i1 [[CY]], label [[NEGY:%.*]], label [[POSY:%.*]]
7575
; CHECK: negy:
7676
; CHECK-NEXT: [[AND:%.*]] = and i8 [[X:%.*]], [[Y]]
77-
; CHECK-NEXT: [[Z:%.*]] = icmp slt i8 [[AND]], [[X]]
77+
; CHECK-NEXT: [[Z:%.*]] = icmp ne i8 [[AND]], [[X]]
7878
; CHECK-NEXT: ret i1 [[Z]]
7979
; CHECK: posy:
8080
; CHECK-NEXT: [[R:%.*]] = call i1 @barrier()
@@ -116,10 +116,7 @@ posy:
116116

117117
define i1 @icmp_sle_x_negy(i8 %x, i8 %yy) {
118118
; CHECK-LABEL: @icmp_sle_x_negy(
119-
; CHECK-NEXT: [[Y:%.*]] = or i8 [[YY:%.*]], -128
120-
; CHECK-NEXT: [[AND:%.*]] = and i8 [[Y]], [[X:%.*]]
121-
; CHECK-NEXT: [[Z:%.*]] = icmp sle i8 [[AND]], [[X]]
122-
; CHECK-NEXT: ret i1 [[Z]]
119+
; CHECK-NEXT: ret i1 true
123120
;
124121
%y = or i8 %yy, 128
125122
%and = and i8 %y, %x
@@ -129,10 +126,7 @@ define i1 @icmp_sle_x_negy(i8 %x, i8 %yy) {
129126

130127
define <2 x i1> @icmp_sgt_x_negy(<2 x i8> %x, <2 x i8> %yy) {
131128
; CHECK-LABEL: @icmp_sgt_x_negy(
132-
; CHECK-NEXT: [[Y:%.*]] = or <2 x i8> [[YY:%.*]], <i8 -128, i8 -128>
133-
; CHECK-NEXT: [[AND:%.*]] = and <2 x i8> [[Y]], [[X:%.*]]
134-
; CHECK-NEXT: [[Z:%.*]] = icmp sgt <2 x i8> [[AND]], [[X]]
135-
; CHECK-NEXT: ret <2 x i1> [[Z]]
129+
; CHECK-NEXT: ret <2 x i1> zeroinitializer
136130
;
137131
%y = or <2 x i8> %yy, <i8 128, i8 128>
138132
%and = and <2 x i8> %y, %x
@@ -155,9 +149,7 @@ define <2 x i1> @icmp_sgt_x_negy_fail_partial(<2 x i8> %x, <2 x i8> %yy) {
155149

156150
define <2 x i1> @icmp_sle_x_posy(<2 x i8> %x, <2 x i8> %yy) {
157151
; CHECK-LABEL: @icmp_sle_x_posy(
158-
; CHECK-NEXT: [[Y:%.*]] = and <2 x i8> [[YY:%.*]], <i8 127, i8 127>
159-
; CHECK-NEXT: [[AND:%.*]] = and <2 x i8> [[Y]], [[X:%.*]]
160-
; CHECK-NEXT: [[Z:%.*]] = icmp sle <2 x i8> [[AND]], [[X]]
152+
; CHECK-NEXT: [[Z:%.*]] = icmp sgt <2 x i8> [[X:%.*]], <i8 -1, i8 -1>
161153
; CHECK-NEXT: ret <2 x i1> [[Z]]
162154
;
163155
%y = and <2 x i8> %yy, <i8 127, i8 127>
@@ -183,8 +175,7 @@ define i1 @icmp_sgt_x_posy(i8 %x, i8 %y) {
183175
; CHECK-LABEL: @icmp_sgt_x_posy(
184176
; CHECK-NEXT: [[CY:%.*]] = icmp sgt i8 [[Y:%.*]], -1
185177
; CHECK-NEXT: call void @llvm.assume(i1 [[CY]])
186-
; CHECK-NEXT: [[AND:%.*]] = and i8 [[X:%.*]], [[Y]]
187-
; CHECK-NEXT: [[Z:%.*]] = icmp sgt i8 [[AND]], [[X]]
178+
; CHECK-NEXT: [[Z:%.*]] = icmp slt i8 [[X:%.*]], 0
188179
; CHECK-NEXT: ret i1 [[Z]]
189180
;
190181
%cy = icmp sge i8 %y, 0
@@ -196,9 +187,7 @@ define i1 @icmp_sgt_x_posy(i8 %x, i8 %y) {
196187

197188
define <2 x i1> @icmp_sgt_negx_y(<2 x i8> %xx, <2 x i8> %y) {
198189
; CHECK-LABEL: @icmp_sgt_negx_y(
199-
; CHECK-NEXT: [[X:%.*]] = or <2 x i8> [[XX:%.*]], <i8 -128, i8 -128>
200-
; CHECK-NEXT: [[AND:%.*]] = and <2 x i8> [[X]], [[Y:%.*]]
201-
; CHECK-NEXT: [[Z:%.*]] = icmp sgt <2 x i8> [[AND]], [[X]]
190+
; CHECK-NEXT: [[Z:%.*]] = icmp sgt <2 x i8> [[Y:%.*]], <i8 -1, i8 -1>
202191
; CHECK-NEXT: ret <2 x i1> [[Z]]
203192
;
204193
%x = or <2 x i8> %xx, <i8 128, i8 128>
@@ -211,8 +200,7 @@ define i1 @icmp_sle_negx_y(i8 %x, i8 %y) {
211200
; CHECK-LABEL: @icmp_sle_negx_y(
212201
; CHECK-NEXT: [[CX:%.*]] = icmp slt i8 [[X:%.*]], 0
213202
; CHECK-NEXT: call void @llvm.assume(i1 [[CX]])
214-
; CHECK-NEXT: [[AND:%.*]] = and i8 [[X]], [[Y:%.*]]
215-
; CHECK-NEXT: [[Z:%.*]] = icmp sle i8 [[AND]], [[X]]
203+
; CHECK-NEXT: [[Z:%.*]] = icmp slt i8 [[Y:%.*]], 0
216204
; CHECK-NEXT: ret i1 [[Z]]
217205
;
218206
%cx = icmp slt i8 %x, 0
@@ -239,9 +227,9 @@ define i1 @icmp_sle_negx_y_fail_maybe_zero(i8 %x, i8 %y) {
239227

240228
define i1 @icmp_eq_x_invertable_y_todo(i8 %x, i1 %y) {
241229
; CHECK-LABEL: @icmp_eq_x_invertable_y_todo(
242-
; CHECK-NEXT: [[YY:%.*]] = select i1 [[Y:%.*]], i8 -8, i8 -25
243-
; CHECK-NEXT: [[AND:%.*]] = and i8 [[YY]], [[X:%.*]]
244-
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[AND]], 0
230+
; CHECK-NEXT: [[TMP1:%.*]] = select i1 [[Y:%.*]], i8 -8, i8 -25
231+
; CHECK-NEXT: [[TMP2:%.*]] = and i8 [[TMP1]], [[X:%.*]]
232+
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[TMP2]], 0
245233
; CHECK-NEXT: ret i1 [[R]]
246234
;
247235
%yy = select i1 %y, i8 7, i8 24
@@ -252,8 +240,8 @@ define i1 @icmp_eq_x_invertable_y_todo(i8 %x, i1 %y) {
252240

253241
define i1 @icmp_eq_x_invertable_y(i8 %x, i8 %y) {
254242
; CHECK-LABEL: @icmp_eq_x_invertable_y(
255-
; CHECK-NEXT: [[AND:%.*]] = and i8 [[YY:%.*]], [[X:%.*]]
256-
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[AND]], 0
243+
; CHECK-NEXT: [[TMP1:%.*]] = and i8 [[X:%.*]], [[Y:%.*]]
244+
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[TMP1]], 0
257245
; CHECK-NEXT: ret i1 [[R]]
258246
;
259247
%yy = xor i8 %y, -1

0 commit comments

Comments
 (0)