Skip to content

Commit c458f92

Browse files
authored
[NFC][clang][test][asan] Make instantiation-depth-default.cpp a valid test case under asan and ubsan configs (#75254)
Clang test `instantiation-depth-default.cpp` fails on Windows when built with `ubsan` due to extra warnings printed by the compiler: ```console File instantiation-depth-default.cpp Line 11: stack nearly exhausted; compilation time may suffer, and crashes due to stack overflow are likely ``` The test case was disabled for `asan` in 571a647 because of the extra stack usage. Since `ubsan` also increases stack usage, seems like the two configs should be treated uniformly. On the other hand, we might be able to re-enable this test case for `asan`. During some preliminary testing on Windows, Linux, and macOS with the host compiler being as old as clang-10, the test case exited successfully if the `stack-exhausted` warnings are suppressed, though I haven't done exhaustive testing across platforms and clang versions. Any insights into whether this change will introduce any risks to existing buildbots is appreciated. Enabling this test case for `asan` helps to improve our test coverage, but if it causes problems on any buildbot, marking it as unsupported for `ubsan` is also a viable solution.
1 parent 0eefcaf commit c458f92

File tree

1 file changed

+5
-11
lines changed

1 file changed

+5
-11
lines changed

clang/test/SemaTemplate/instantiation-depth-default.cpp

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,12 @@
1-
// RUN: %clang_cc1 -fsyntax-only -verify -ftemplate-backtrace-limit=2 %s
2-
//
3-
// FIXME: Disable this test when Clang was built with ASan, because ASan
4-
// increases our per-frame stack usage enough that this test no longer fits
5-
// within our normal stack space allocation.
6-
// UNSUPPORTED: asan
7-
//
1+
// RUN: %clang_cc1 -fsyntax-only -verify -ftemplate-backtrace-limit=2 %if {{asan|ubsan}} %{ -Wno-stack-exhausted %} %s
82
// The default stack size on NetBSD is too small for this test.
93
// UNSUPPORTED: system-netbsd
104

115
template<int N, typename T> struct X : X<N+1, T*> {};
12-
// expected-error-re@11 {{recursive template instantiation exceeded maximum depth of 1024{{$}}}}
13-
// expected-note@11 {{instantiation of template class}}
14-
// expected-note@11 {{skipping 1023 contexts in backtrace}}
15-
// expected-note@11 {{use -ftemplate-depth=N to increase recursive template instantiation depth}}
6+
// expected-error-re@5 {{recursive template instantiation exceeded maximum depth of 1024{{$}}}}
7+
// expected-note@5 {{instantiation of template class}}
8+
// expected-note@5 {{skipping 1023 contexts in backtrace}}
9+
// expected-note@5 {{use -ftemplate-depth=N to increase recursive template instantiation depth}}
1610

1711
X<0, int> x; // expected-note {{in instantiation of}}
1812

0 commit comments

Comments
 (0)