Skip to content

Commit c4d6867

Browse files
authored
InstSimplify: strip bad TODO (NFC) (#92754)
foldIdentityShuffles requires two sets of canceling shuffles. If there are any intervening instructions, they are feeding in the result of the first set of shuffles. To eliminate the two sets of shuffles, you'd have to rewrite the head of the intervening instructions to feed in the operand of the first set of shuffles. Since modifying the IR in any way is disallowed by an analysis, strip this bad TODO.
1 parent 56a1f0a commit c4d6867

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

llvm/lib/Analysis/InstructionSimplify.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5346,9 +5346,6 @@ static Value *foldIdentityShuffles(int DestElt, Value *Op0, Value *Op1,
53465346
SourceShuf->getMaskValue(RootElt), RootVec, MaxRecurse);
53475347
}
53485348

5349-
// TODO: Look through bitcasts? What if the bitcast changes the vector element
5350-
// size?
5351-
53525349
// The source operand is not a shuffle. Initialize the root vector value for
53535350
// this shuffle if that has not been done yet.
53545351
if (!RootVec)

0 commit comments

Comments
 (0)