Skip to content

Commit ca87823

Browse files
authored
[LLDB][NFC]Refactor common test setup into SetUp method (#131203)
1 parent 8f66fb7 commit ca87823

File tree

1 file changed

+12
-19
lines changed

1 file changed

+12
-19
lines changed

lldb/unittests/Core/TelemetryTest.cpp

Lines changed: 12 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,16 @@ using namespace lldb_private::telemetry;
8181
class TelemetryTest : public testing::Test {
8282
public:
8383
lldb_private::SubsystemRAII<lldb_private::FakePlugin> subsystems;
84+
std::vector<std::unique_ptr<::llvm::telemetry::TelemetryInfo>>
85+
received_entries;
86+
87+
void SetUp() override {
88+
auto *ins = lldb_private::telemetry::TelemetryManager::GetInstance();
89+
ASSERT_NE(ins, nullptr);
90+
91+
ins->addDestination(
92+
std::make_unique<lldb_private::TestDestination>(&received_entries));
93+
}
8494
};
8595

8696
#if LLVM_ENABLE_TELEMETRY
@@ -90,17 +100,8 @@ class TelemetryTest : public testing::Test {
90100
#endif
91101

92102
TELEMETRY_TEST(TelemetryTest, PluginTest) {
93-
// This would have been called by the plugin reg in a "real" plugin
94-
// For tests, we just call it directly.
95-
lldb_private::FakePlugin::Initialize();
96-
97-
auto *ins = lldb_private::telemetry::TelemetryManager::GetInstance();
98-
ASSERT_NE(ins, nullptr);
99-
100-
std::vector<std::unique_ptr<::llvm::telemetry::TelemetryInfo>>
101-
received_entries;
102-
ins->addDestination(
103-
std::make_unique<lldb_private::TestDestination>(&received_entries));
103+
lldb_private::telemetry::TelemetryManager *ins =
104+
lldb_private::telemetry::TelemetryManager::GetInstance();
104105

105106
lldb_private::FakeTelemetryInfo entry;
106107
entry.msg = "";
@@ -115,14 +116,6 @@ TELEMETRY_TEST(TelemetryTest, PluginTest) {
115116
}
116117

117118
TELEMETRY_TEST(TelemetryTest, ScopedDispatcherTest) {
118-
lldb_private::FakePlugin::Initialize();
119-
auto *ins = TelemetryManager::GetInstance();
120-
ASSERT_NE(ins, nullptr);
121-
std::vector<std::unique_ptr<::llvm::telemetry::TelemetryInfo>>
122-
received_entries;
123-
ins->addDestination(
124-
std::make_unique<lldb_private::TestDestination>(&received_entries));
125-
126119
{
127120
ScopedDispatcher<lldb_private::FakeTelemetryInfo> helper(
128121
[](lldb_private::FakeTelemetryInfo *info) { info->num = 0; });

0 commit comments

Comments
 (0)