Skip to content

Commit ce01d4b

Browse files
committed
Address review comment.
1 parent 4db8f43 commit ce01d4b

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

clang/lib/Sema/SemaAttr.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -302,10 +302,9 @@ void Sema::inferLifetimeCaptureByAttribute(FunctionDecl *FD) {
302302
// Infer for the map's operator []:
303303
// std::map<string_view, ...> m;
304304
// m[ReturnString(..)] = ...; // !dangling references in m.
305-
if (MD->getOverloadedOperator() != OO_Subscript ||
306-
!MapLikeContainer.contains(MD->getParent()->getName()))
307-
return;
308-
Annotate(MD);
305+
if (MD->getOverloadedOperator() == OO_Subscript &&
306+
MapLikeContainer.contains(MD->getParent()->getName()))
307+
Annotate(MD);
309308
return;
310309
}
311310
static const llvm::StringSet<> CapturingMethods{"insert", "push",

0 commit comments

Comments
 (0)