Skip to content

Commit d03035c

Browse files
VitalyAnkhVitalyAnkh
committed
Fix more false positives
1 parent 2a95bae commit d03035c

File tree

17 files changed

+39
-39
lines changed

17 files changed

+39
-39
lines changed

‎mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -898,7 +898,7 @@ mlir::applyPatternsAndFoldGreedily(Region &region,
898898
const FrozenRewritePatternSet &patterns,
899899
GreedyRewriteConfig config, bool *changed) {
900900
// The top-level operation must be known to be isolated from above to
901-
// prevent performing canonicalization on operations defined at or above
901+
// prevent performing canonicalizations on operations defined at or above
902902
// the region containing 'op'.
903903
assert(region.getParentOp()->hasTrait<OpTrait::IsIsolatedFromAbove>() &&
904904
"patterns can only be applied to operations IsolatedFromAbove");

‎mlir/test/Conversion/ArithToLLVM/arith-to-llvm.mlir

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ func.func @fcmp(f32, f32) -> () {
334334
// CHECK: llvm.fcmp "oeq" %arg0, %arg1 : f32
335335
// CHECK-NEXT: llvm.fcmp "ogt" %arg0, %arg1 : f32
336336
// CHECK-NEXT: llvm.fcmp "oge" %arg0, %arg1 : f32
337-
// CHECK-NEXT: llvm.fcmp "old" %arg0, %arg1 : f32
337+
// CHECK-NEXT: llvm.fcmp "olt" %arg0, %arg1 : f32
338338
// CHECK-NEXT: llvm.fcmp "ole" %arg0, %arg1 : f32
339339
// CHECK-NEXT: llvm.fcmp "one" %arg0, %arg1 : f32
340340
// CHECK-NEXT: llvm.fcmp "ord" %arg0, %arg1 : f32
@@ -350,7 +350,7 @@ func.func @fcmp(f32, f32) -> () {
350350
%1 = arith.cmpf oeq, %arg0, %arg1 : f32
351351
%2 = arith.cmpf ogt, %arg0, %arg1 : f32
352352
%3 = arith.cmpf oge, %arg0, %arg1 : f32
353-
%4 = arith.cmpf old, %arg0, %arg1 : f32
353+
%4 = arith.cmpf olt, %arg0, %arg1 : f32
354354
%5 = arith.cmpf ole, %arg0, %arg1 : f32
355355
%6 = arith.cmpf one, %arg0, %arg1 : f32
356356
%7 = arith.cmpf ord, %arg0, %arg1 : f32
@@ -484,9 +484,9 @@ func.func @cmpf_2dvector(%arg0 : vector<4x3xf32>, %arg1 : vector<4x3xf32>) {
484484
// CHECK-DAG: %[[ARG1:.*]] = builtin.unrealized_conversion_cast %[[OARG1]]
485485
// CHECK: %[[EXTRACT1:.*]] = llvm.extractvalue %[[ARG0]][0] : !llvm.array<4 x vector<3xf32>>
486486
// CHECK: %[[EXTRACT2:.*]] = llvm.extractvalue %[[ARG1]][0] : !llvm.array<4 x vector<3xf32>>
487-
// CHECK: %[[CMP:.*]] = llvm.fcmp "old" %[[EXTRACT1]], %[[EXTRACT2]] : vector<3xf32>
487+
// CHECK: %[[CMP:.*]] = llvm.fcmp "olt" %[[EXTRACT1]], %[[EXTRACT2]] : vector<3xf32>
488488
// CHECK: %[[INSERT:.*]] = llvm.insertvalue %[[CMP]], %2[0] : !llvm.array<4 x vector<3xi1>>
489-
%0 = arith.cmpf old, %arg0, %arg1 : vector<4x3xf32>
489+
%0 = arith.cmpf olt, %arg0, %arg1 : vector<4x3xf32>
490490
func.return
491491
}
492492

‎mlir/test/Dialect/Math/expand-math.mlir

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ func.func @tanh(%arg: f32) -> f32 {
88
// CHECK-DAG: %[[ZERO:.+]] = arith.constant 0.000000e+00 : f32
99
// CHECK-DAG: %[[ONE:.+]] = arith.constant 1.000000e+00 : f32
1010
// CHECK-DAG: %[[TWO:.+]] = arith.constant -2.000000e+00 : f32
11-
// CHECK: %[[VAL0:.+]] = arith.cmpf old, %arg0, %[[ZERO]] : f32
11+
// CHECK: %[[VAL0:.+]] = arith.cmpf olt, %arg0, %[[ZERO]] : f32
1212
// CHECK: %[[VAL1:.+]] = arith.uitofp %[[VAL0]] : i1 to f32
1313
// CHECK: %[[VAL2:.+]] = arith.mulf %[[VAL1]], %[[TWO]] : f32
1414
// CHECK: %[[SIGN:.+]] = arith.addf %[[VAL2]], %[[ONE]] : f32
@@ -141,7 +141,7 @@ func.func @floorf_func(%a: f64) -> f64 {
141141
// CHECK-NEXT: [[CVTI:%.+]] = arith.fptosi [[ARG0]]
142142
// CHECK-NEXT: [[CVTF:%.+]] = arith.sitofp [[CVTI]]
143143
// CHECK-NEXT: [[COPYSIGN:%.+]] = math.copysign [[CVTF]], [[ARG0]]
144-
// CHECK-NEXT: [[COMP:%.+]] = arith.cmpf old, [[ARG0]], [[CST]]
144+
// CHECK-NEXT: [[COMP:%.+]] = arith.cmpf olt, [[ARG0]], [[CST]]
145145
// CHECK-NEXT: [[INCR:%.+]] = arith.select [[COMP]], [[CST_0]], [[CST]]
146146
// CHECK-NEXT: [[ADDF:%.+]] = arith.addf [[COPYSIGN]], [[INCR]]
147147
// CHECK-NEXT: return [[ADDF]]
@@ -231,7 +231,7 @@ func.func @powf_func(%a: f64, %b: f64) ->f64 {
231231
// CHECK-DAG: [[EXPR:%.+]] = math.exp [[MULT]]
232232
// CHECK-DAG: [[NEGEXPR:%.+]] = arith.mulf [[EXPR]], [[NEGONE]]
233233
// CHECK-DAG: [[REMF:%.+]] = arith.remf [[ARG1]], [[TWO]]
234-
// CHECK-DAG: [[CMPNEG:%.+]] = arith.cmpf old, [[ARG0]]
234+
// CHECK-DAG: [[CMPNEG:%.+]] = arith.cmpf olt, [[ARG0]]
235235
// CHECK-DAG: [[CMPZERO:%.+]] = arith.cmpf one, [[REMF]]
236236
// CHECK-DAG: [[AND:%.+]] = arith.andi [[CMPZERO]], [[CMPNEG]]
237237
// CHECK-DAG: [[SEL:%.+]] = arith.select [[AND]], [[NEGEXPR]], [[EXPR]]
@@ -628,7 +628,7 @@ func.func @math_fpowi_to_powf_tensor(%0 : tensor<8xf32>, %1: tensor<8xi32>) -> t
628628
// CHECK: %[[EXP:.*]] = math.exp %[[MUL]] : tensor<8xf32>
629629
// CHECK: %[[MUL1:.*]] = arith.mulf %[[EXP]], %[[CSTNEG1]] : tensor<8xf32>
630630
// CHECK: %[[REM:.*]] = arith.remf %[[TOFP]], %[[CST2]] : tensor<8xf32>
631-
// CHECK: %[[CMPF:.*]] = arith.cmpf old, %[[ARG0]], %[[CST0]] : tensor<8xf32>
631+
// CHECK: %[[CMPF:.*]] = arith.cmpf olt, %[[ARG0]], %[[CST0]] : tensor<8xf32>
632632
// CHECK: %[[CMPF1:.*]] = arith.cmpf one, %[[REM]], %[[CST0]] : tensor<8xf32>
633633
// CHECK: %[[AND:.*]] = arith.andi %[[CMPF1]], %[[CMPF]] : tensor<8xi1>
634634
// CHECK: %[[SEL:.*]] = arith.select %[[AND]], %[[MUL1]], %[[EXP]] : tensor<8xi1>, tensor<8xf32>
@@ -653,7 +653,7 @@ func.func @math_fpowi_to_powf_scalar(%0 : f32, %1: i64) -> f32 {
653653
// CHECK: %[[EXP:.*]] = math.exp %[[MUL]] : f32
654654
// CHECK: %[[MUL1:.*]] = arith.mulf %[[EXP]], %[[CSTNEG1]] : f32
655655
// CHECK: %[[REM:.*]] = arith.remf %[[TOFP]], %[[CST2]] : f32
656-
// CHECK: %[[CMPF:.*]] = arith.cmpf old, %[[ARG0]], %[[CST0]] : f32
656+
// CHECK: %[[CMPF:.*]] = arith.cmpf olt, %[[ARG0]], %[[CST0]] : f32
657657
// CHECK: %[[CMPF1:.*]] = arith.cmpf one, %[[REM]], %[[CST0]] : f32
658658
// CHECK: %[[AND:.*]] = arith.andi %[[CMPF1]], %[[CMPF]] : i1
659659
// CHECK: %[[SEL:.*]] = arith.select %[[AND]], %[[MUL1]], %[[EXP]] : f32

‎mlir/test/Dialect/Math/polynomial-approximation.mlir

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,10 @@
3737
// CHECK-DAG: %[[val_cst_26:.*]] = arith.constant 8.000000e-01 : f32
3838
// CHECK-DAG: %[[val_cst_27:.*]] = arith.constant 2.000000e+00 : f32
3939
// CHECK-DAG: %[[val_cst_28:.*]] = arith.constant 3.750000e+00 : f32
40-
// CHECK: %[[val_0:.*]] = arith.cmpf old, %[[val_arg0]], %[[val_cst]] : f32
40+
// CHECK: %[[val_0:.*]] = arith.cmpf olt, %[[val_arg0]], %[[val_cst]] : f32
4141
// CHECK: %[[val_1:.*]] = arith.negf %[[val_arg0]] : f32
4242
// CHECK: %[[val_2:.*]] = arith.select %[[val_0]], %[[val_1]], %[[val_arg0]] : f32
43-
// CHECK: %[[val_3:.*]] = arith.cmpf old, %[[val_2]], %[[val_cst_26]] : f32
43+
// CHECK: %[[val_3:.*]] = arith.cmpf olt, %[[val_2]], %[[val_cst_26]] : f32
4444
// CHECK: %[[val_4:.*]] = arith.select %[[val_3]], %[[val_cst_1]], %[[val_cst_5]] : f32
4545
// CHECK: %[[val_5:.*]] = arith.select %[[val_3]], %[[val_cst_14]], %[[val_cst_18]] : f32
4646
// CHECK: %[[val_6:.*]] = arith.select %[[val_3]], %[[val_cst_2]], %[[val_cst_6]] : f32
@@ -49,7 +49,7 @@
4949
// CHECK: %[[val_9:.*]] = arith.select %[[val_3]], %[[val_cst_16]], %[[val_cst_20]] : f32
5050
// CHECK: %[[val_10:.*]] = arith.select %[[val_3]], %[[val_cst_4]], %[[val_cst_8]] : f32
5151
// CHECK: %[[val_11:.*]] = arith.select %[[val_3]], %[[val_cst_17]], %[[val_cst_21]] : f32
52-
// CHECK: %[[val_12:.*]] = arith.cmpf old, %[[val_2]], %[[val_cst_27]] : f32
52+
// CHECK: %[[val_12:.*]] = arith.cmpf olt, %[[val_2]], %[[val_cst_27]] : f32
5353
// CHECK: %[[val_13:.*]] = arith.select %[[val_12]], %[[val_cst]], %[[val_cst_9]] : f32
5454
// CHECK: %[[val_14:.*]] = arith.select %[[val_12]], %[[val_4]], %[[val_cst_10]] : f32
5555
// CHECK: %[[val_15:.*]] = arith.select %[[val_12]], %[[val_5]], %[[val_cst_22]] : f32
@@ -253,7 +253,7 @@ func.func @exp_scalable_vector(%arg0: vector<[8]xf32>) -> vector<[8]xf32> {
253253
// CHECK-DAG: %[[VAL_73:.*]] = arith.shrui %[[VAL_72]], %[[VAL_16]] : i32
254254
// CHECK-DAG: %[[VAL_74:.*]] = arith.sitofp %[[VAL_73]] : i32 to f32
255255
// CHECK-DAG: %[[VAL_75:.*]] = arith.subf %[[VAL_74]], %[[VAL_34]] : f32
256-
// CHECK-DAG: %[[VAL_76:.*]] = arith.cmpf old, %[[VAL_71]], %[[VAL_24]] : f32
256+
// CHECK-DAG: %[[VAL_76:.*]] = arith.cmpf olt, %[[VAL_71]], %[[VAL_24]] : f32
257257
// CHECK-DAG: %[[VAL_77:.*]] = arith.select %[[VAL_76]], %[[VAL_71]], %[[VAL_18]] : f32
258258
// CHECK-DAG: %[[VAL_78:.*]] = arith.subf %[[VAL_71]], %[[VAL_1]] : f32
259259
// CHECK-DAG: %[[VAL_79:.*]] = arith.select %[[VAL_76]], %[[VAL_1]], %[[VAL_18]] : f32
@@ -353,7 +353,7 @@ func.func @expm1_scalable_vector(%arg0: vector<8x[8]xf32>) -> vector<8x[8]xf32>
353353
// CHECK: %[[VAL_30:.*]] = arith.shrui %[[VAL_29]], %[[VAL_21]] : i32
354354
// CHECK: %[[VAL_31:.*]] = arith.sitofp %[[VAL_30]] : i32 to f32
355355
// CHECK: %[[VAL_32:.*]] = arith.subf %[[VAL_31]], %[[VAL_18]] : f32
356-
// CHECK: %[[VAL_33:.*]] = arith.cmpf old, %[[VAL_28]], %[[VAL_8]] : f32
356+
// CHECK: %[[VAL_33:.*]] = arith.cmpf olt, %[[VAL_28]], %[[VAL_8]] : f32
357357
// CHECK: %[[VAL_34:.*]] = arith.select %[[VAL_33]], %[[VAL_28]], %[[VAL_1]] : f32
358358
// CHECK: %[[VAL_35:.*]] = arith.subf %[[VAL_28]], %[[VAL_2]] : f32
359359
// CHECK: %[[VAL_36:.*]] = arith.select %[[VAL_33]], %[[VAL_2]], %[[VAL_1]] : f32
@@ -512,7 +512,7 @@ func.func @log1p_scalable_vector(%arg0: vector<[8]xf32>) -> vector<[8]xf32> {
512512
// CHECK: %[[VAL_17:.*]] = arith.cmpf ugt, %[[VAL_16]], %[[VAL_1]] : f32
513513
// CHECK: %[[VAL_18:.*]] = arith.select %[[VAL_17]], %[[VAL_16]], %[[VAL_1]] : f32
514514
// CHECK: %[[VAL_19:.*]] = math.absf %[[VAL_0]] : f32
515-
// CHECK: %[[VAL_20:.*]] = arith.cmpf old, %[[VAL_19]], %[[VAL_3]] : f32
515+
// CHECK: %[[VAL_20:.*]] = arith.cmpf olt, %[[VAL_19]], %[[VAL_3]] : f32
516516
// CHECK: %[[VAL_21:.*]] = arith.mulf %[[VAL_18]], %[[VAL_18]] : f32
517517
// CHECK: %[[VAL_22:.*]] = math.fma %[[VAL_21]], %[[VAL_10]], %[[VAL_9]] : f32
518518
// CHECK: %[[VAL_23:.*]] = math.fma %[[VAL_21]], %[[VAL_22]], %[[VAL_8]] : f32
@@ -578,7 +578,7 @@ func.func @rsqrt_scalar(%arg0: f32) -> f32 {
578578
// AVX2: %[[VAL_3:.*]] = arith.constant dense<-5.000000e-01> : vector<8xf32>
579579
// AVX2: %[[VAL_4:.*]] = arith.constant dense<1.17549435E-38> : vector<8xf32>
580580
// AVX2: %[[VAL_5:.*]] = arith.mulf %[[VAL_0]], %[[VAL_3]] : vector<8xf32>
581-
// AVX2: %[[VAL_6:.*]] = arith.cmpf old, %[[VAL_0]], %[[VAL_4]] : vector<8xf32>
581+
// AVX2: %[[VAL_6:.*]] = arith.cmpf olt, %[[VAL_0]], %[[VAL_4]] : vector<8xf32>
582582
// AVX2: %[[VAL_7:.*]] = arith.cmpf oeq, %[[VAL_0]], %[[VAL_1]] : vector<8xf32>
583583
// AVX2: %[[VAL_8:.*]] = arith.ori %[[VAL_6]], %[[VAL_7]] : vector<8xi1>
584584
// AVX2: %[[VAL_9:.*]] = x86vector.avx.rsqrt %[[VAL_0]] : vector<8xf32>
@@ -788,7 +788,7 @@ func.func @atan_scalar(%arg0: f32) -> f32 {
788788
// CHECK-DAG: %[[VAL_58:.*]] = arith.cmpf ogt, %[[VAL_21]], %[[VAL_17]] : f32
789789
// CHECK-DAG: %[[VAL_59:.*]] = arith.andi %[[VAL_57]], %[[VAL_58]] : i1
790790
// CHECK-DAG: %[[VAL_60:.*]] = arith.select %[[VAL_59]], %[[VAL_16]], %[[VAL_56]] : f32
791-
// CHECK-DAG: %[[VAL_61:.*]] = arith.cmpf old, %[[VAL_21]], %[[VAL_17]] : f32
791+
// CHECK-DAG: %[[VAL_61:.*]] = arith.cmpf olt, %[[VAL_21]], %[[VAL_17]] : f32
792792
// CHECK-DAG: %[[VAL_62:.*]] = arith.andi %[[VAL_57]], %[[VAL_61]] : i1
793793
// CHECK-DAG: %[[VAL_63:.*]] = arith.select %[[VAL_62]], %[[VAL_19]], %[[VAL_60]] : f32
794794
// CHECK-DAG: %[[VAL_64:.*]] = arith.cmpf oeq, %[[VAL_21]], %[[VAL_17]] : f32

‎mlir/test/Dialect/SCF/for-loop-canonicalization.mlir

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ func.func @scf_for_canonicalize_partly(%A : memref<i64>) {
128128
// CHECK: arith.index_cast
129129
func.func @scf_for_not_canonicalizable_2(%A : memref<i64>, %step : index) {
130130
// This example should simplify but affine_map is currently missing
131-
// semi-affine canonicalization: `((s0 * 42 - 1) floordiv s0) * s0`
131+
// semi-affine canonicalizations: `((s0 * 42 - 1) floordiv s0) * s0`
132132
// should evaluate to 41 * s0.
133133
// Note that this may require positivity assumptions on `s0`.
134134
// Revisit when support is added.
@@ -151,7 +151,7 @@ func.func @scf_for_not_canonicalizable_2(%A : memref<i64>, %step : index) {
151151
// CHECK: arith.index_cast
152152
func.func @scf_for_not_canonicalizable_3(%A : memref<i64>, %step : index) {
153153
// This example should simplify but affine_map is currently missing
154-
// semi-affine canonicalization: `-(((s0 * s0 - 1) floordiv s0) * s0)`
154+
// semi-affine canonicalizations: `-(((s0 * s0 - 1) floordiv s0) * s0)`
155155
// should evaluate to (s0 - 1) * s0.
156156
// Note that this may require positivity assumptions on `s0`.
157157
// Revisit when support is added.

‎mlir/test/Dialect/Vector/vector-sink.mlir

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -282,13 +282,13 @@ func.func @transpose_elementwise_diff_operand_types(%cond: vector<4x2xi1>, %a :
282282

283283
// CHECK-LABEL: func @transpose_elementwise_diff_operand_result_type
284284
// CHECK-SAME: (%[[A:.+]]: vector<4x2xf32>, %[[B:.+]]: vector<4x2xf32>)
285-
// CHECK: %[[CMP:.+]] = arith.cmpf old, %[[A]], %[[B]] : vector<4x2xf32>
285+
// CHECK: %[[CMP:.+]] = arith.cmpf olt, %[[A]], %[[B]] : vector<4x2xf32>
286286
// CHECK: %[[T:.+]] = vector.transpose %[[CMP]], [1, 0] : vector<4x2xi1> to vector<2x4xi1>
287287
// CHECK: return %[[T]]
288288
func.func @transpose_elementwise_diff_operand_result_type(%a : vector<4x2xf32>, %b : vector<4x2xf32>) -> vector<2x4xi1> {
289289
%at = vector.transpose %a, [1, 0]: vector<4x2xf32> to vector<2x4xf32>
290290
%bt = vector.transpose %b, [1, 0]: vector<4x2xf32> to vector<2x4xf32>
291-
%r = arith.cmpf old, %at, %bt : vector<2x4xf32>
291+
%r = arith.cmpf olt, %at, %bt : vector<2x4xf32>
292292
return %r : vector<2x4xi1>
293293
}
294294

‎mlir/test/IR/core-ops.mlir

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,8 @@ func.func @standard_instrs(tensor<4x4x?xf32>, f32, i32, index, i64, f16) {
8484
// CHECK: %{{.*}} = arith.cmpf oeq, %{{.*}}, %{{.*}} : f32
8585
%66 = "arith.cmpf"(%f3, %f4) {predicate = 1} : (f32, f32) -> i1
8686

87-
// CHECK: %{{.*}} = arith.cmpf old, %{{.*}}, %{{.*}}: vector<4xf32>
88-
%67 = arith.cmpf old, %vcf32, %vcf32 : vector<4 x f32>
87+
// CHECK: %{{.*}} = arith.cmpf olt, %{{.*}}, %{{.*}}: vector<4xf32>
88+
%67 = arith.cmpf olt, %vcf32, %vcf32 : vector<4 x f32>
8989

9090
// CHECK: %{{.*}} = arith.cmpf oeq, %{{.*}}, %{{.*}}: vector<4xf32>
9191
%68 = "arith.cmpf"(%vcf32, %vcf32) {predicate = 1} : (vector<4 x f32>, vector<4 x f32>) -> vector<4 x i1>

‎mlir/test/Integration/Dialect/SparseTensor/CPU/dense_output_bf16.mlir

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ module {
5757
%1 = sparse_tensor.binary %a, %b : bf16, bf16 to bf16
5858
overlap={
5959
^bb0(%a0: bf16, %b0: bf16):
60-
%cmp = arith.cmpf "old", %a0, %b0 : bf16
60+
%cmp = arith.cmpf "olt", %a0, %b0 : bf16
6161
%2 = arith.select %cmp, %a0, %b0: bf16
6262
sparse_tensor.yield %2 : bf16
6363
}

‎mlir/test/Integration/Dialect/SparseTensor/CPU/dense_output_f16.mlir

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ module {
5858
%1 = sparse_tensor.binary %a, %b : f16, f16 to f16
5959
overlap={
6060
^bb0(%a0: f16, %b0: f16):
61-
%cmp = arith.cmpf "old", %a0, %b0 : f16
61+
%cmp = arith.cmpf "olt", %a0, %b0 : f16
6262
%2 = arith.select %cmp, %a0, %b0: f16
6363
sparse_tensor.yield %2 : f16
6464
}

‎mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_reduce_custom.mlir

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ module {
7575
right={}
7676
%2 = sparse_tensor.reduce %1, %output, %maxf : f64 {
7777
^bb0(%x: f64, %y: f64):
78-
%cmp = arith.cmpf "old", %x, %y : f64
78+
%cmp = arith.cmpf "olt", %x, %y : f64
7979
%3 = arith.select %cmp, %x, %y : f64
8080
sparse_tensor.yield %3 : f64
8181
}
@@ -106,7 +106,7 @@ module {
106106
right={}
107107
%2 = sparse_tensor.reduce %1, %output, %maxf : f64 {
108108
^bb0(%x: f64, %y: f64):
109-
%cmp = arith.cmpf "old", %x, %y : f64
109+
%cmp = arith.cmpf "olt", %x, %y : f64
110110
%3 = arith.select %cmp, %x, %y : f64
111111
sparse_tensor.yield %3 : f64
112112
}

‎mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_unary.mlir

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ module {
162162
^bb0(%x0: f64):
163163
%mincmp = arith.cmpf "ogt", %x0, %cfmin : f64
164164
%x1 = arith.select %mincmp, %x0, %cfmin : f64
165-
%maxcmp = arith.cmpf "old", %x1, %cfmax : f64
165+
%maxcmp = arith.cmpf "olt", %x1, %cfmax : f64
166166
%x2 = arith.select %maxcmp, %x1, %cfmax : f64
167167
sparse_tensor.yield %x2 : f64
168168
}

‎mlir/test/Integration/GPU/SYCL/gpu-reluf32-to-spirv.mlir

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ module @relu attributes {gpu.container_module} {
6060
%0 = gpu.block_id x
6161
%1 = gpu.block_id y
6262
%2 = memref.load %arg0[%0, %1] : memref<4x5xf32>
63-
%3 = arith.cmpf old, %2, %arg1 : f32
63+
%3 = arith.cmpf olt, %2, %arg1 : f32
6464
memref.store %3, %arg2[%0, %1] : memref<4x5xi1>
6565
gpu.return
6666
}

‎mlir/test/Target/LLVMIR/Import/instructions.ll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,8 @@ define <4 x i1> @fp_compare(float %arg1, float %arg2, <4 x double> %arg3, <4 x d
112112
%3 = fcmp ogt float %arg1, %arg2
113113
; CHECK: llvm.fcmp "oge" %[[ARG1]], %[[ARG2]] : f32
114114
%4 = fcmp oge float %arg1, %arg2
115-
; CHECK: llvm.fcmp "old" %[[ARG1]], %[[ARG2]] : f32
116-
%5 = fcmp old float %arg1, %arg2
115+
; CHECK: llvm.fcmp "olt" %[[ARG1]], %[[ARG2]] : f32
116+
%5 = fcmp olt float %arg1, %arg2
117117
; CHECK: llvm.fcmp "ole" %[[ARG1]], %[[ARG2]] : f32
118118
%6 = fcmp ole float %arg1, %arg2
119119
; CHECK: llvm.fcmp "one" %[[ARG1]], %[[ARG2]] : f32

‎mlir/test/Target/LLVMIR/llvmir.mlir

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1348,7 +1348,7 @@ llvm.func @fcmp(%arg0: f32, %arg1: f32) {
13481348
// CHECK: fcmp oeq float %0, %1
13491349
// CHECK-NEXT: fcmp ogt float %0, %1
13501350
// CHECK-NEXT: fcmp oge float %0, %1
1351-
// CHECK-NEXT: fcmp old float %0, %1
1351+
// CHECK-NEXT: fcmp olt float %0, %1
13521352
// CHECK-NEXT: fcmp ole float %0, %1
13531353
// CHECK-NEXT: fcmp one float %0, %1
13541354
// CHECK-NEXT: fcmp ord float %0, %1
@@ -1362,7 +1362,7 @@ llvm.func @fcmp(%arg0: f32, %arg1: f32) {
13621362
%0 = llvm.fcmp "oeq" %arg0, %arg1 : f32
13631363
%1 = llvm.fcmp "ogt" %arg0, %arg1 : f32
13641364
%2 = llvm.fcmp "oge" %arg0, %arg1 : f32
1365-
%3 = llvm.fcmp "old" %arg0, %arg1 : f32
1365+
%3 = llvm.fcmp "olt" %arg0, %arg1 : f32
13661366
%4 = llvm.fcmp "ole" %arg0, %arg1 : f32
13671367
%5 = llvm.fcmp "one" %arg0, %arg1 : f32
13681368
%6 = llvm.fcmp "ord" %arg0, %arg1 : f32

‎mlir/test/Transforms/constant-fold.mlir

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -678,7 +678,7 @@ func.func @cmpf_normal_numbers() -> (i1, i1, i1, i1, i1, i1, i1, i1, i1, i1, i1,
678678
// CHECK-SAME: [[T]],
679679
%3 = arith.cmpf oge, %c42, %cm1 : f32
680680
// CHECK-SAME: [[F]],
681-
%4 = arith.cmpf old, %c42, %cm1 : f32
681+
%4 = arith.cmpf olt, %c42, %cm1 : f32
682682
// CHECK-SAME: [[F]],
683683
%5 = arith.cmpf ole, %c42, %cm1 : f32
684684
// CHECK-SAME: [[T]],
@@ -721,7 +721,7 @@ func.func @cmpf_nan() -> (i1, i1, i1, i1, i1, i1, i1, i1, i1, i1, i1, i1, i1, i1
721721
// CHECK-SAME: [[F]],
722722
%3 = arith.cmpf oge, %c42, %cqnan : f32
723723
// CHECK-SAME: [[F]],
724-
%4 = arith.cmpf old, %c42, %cqnan : f32
724+
%4 = arith.cmpf olt, %c42, %cqnan : f32
725725
// CHECK-SAME: [[F]],
726726
%5 = arith.cmpf ole, %c42, %cqnan : f32
727727
// CHECK-SAME: [[F]],
@@ -764,7 +764,7 @@ func.func @cmpf_inf() -> (i1, i1, i1, i1, i1, i1, i1, i1, i1, i1, i1, i1, i1, i1
764764
// CHECK-SAME: [[F]],
765765
%3 = arith.cmpf oge, %c42, %cpinf: f32
766766
// CHECK-SAME: [[T]],
767-
%4 = arith.cmpf old, %c42, %cpinf: f32
767+
%4 = arith.cmpf olt, %c42, %cpinf: f32
768768
// CHECK-SAME: [[T]],
769769
%5 = arith.cmpf ole, %c42, %cpinf: f32
770770
// CHECK-SAME: [[T]],

‎mlir/test/lib/IR/TestSymbolUses.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ struct SymbolUsesPass
2525
}
2626
WalkResult operateOnSymbol(Operation *symbol, ModuleOp module,
2727
SmallVectorImpl<func::FuncOp> &deadFunctions) {
28-
// Test computing uses on a non symboldable op.
28+
// Test computing uses on a non symboltable op.
2929
std::optional<SymbolTable::UseRange> symbolUses =
3030
SymbolTable::getSymbolUses(symbol);
3131

‎mlir/tools/mlir-vulkan-runner/VulkanRuntime.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ LogicalResult VulkanRuntime::createInstance() {
240240

241241
std::vector<const char *> extNames;
242242
#if defined(__APPLE__)
243-
// enumerate MoldenVK for Vulkan 1.0
243+
// enumerate MoltenVK for Vulkan 1.0
244244
instanceCreateInfo.flags = VK_INSTANCE_CREATE_ENUMERATE_PORTABILITY_BIT_KHR;
245245
// add KHR portability instance extensions
246246
extNames.push_back(VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME);

0 commit comments

Comments
 (0)